Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Update warnings in kmem debug code 

This fix was long overdue.  Most of the ground work was laid long
ago to include the exact function and line number in the error message
which there was an issue with a memory allocation call.  However,
probably due to lack of time at the moment that informatin never
made it in to the error message.  This patch fixes that and trys
to standardize the kmem debug messages as well.
This commit is contained in:
Brian Behlendorf 2010-06-16 15:57:04 -07:00
parent 8ffef449ef
commit 3cb77549d1
1 changed files with 49 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

85
module/spl/spl-kmem.c
View File

@ -431,14 +431,17 @@ kmem_alloc_track(size_t size, int flags, const char *func, int line,
flags & ~__GFP_ZERO); flags & ~__GFP_ZERO);
if (dptr == NULL) { if (dptr == NULL) {
CWARN("kmem_alloc(%ld, 0x%x) debug failed\n", CDEBUG_LIMIT(D_CONSOLE | D_WARNING, "debug "
sizeof(kmem_debug_t), flags); "kmem_alloc(%ld, 0x%x) at %s:%d failed (%lld/%llu)\n",
sizeof(kmem_debug_t), flags, func, line,
kmem_alloc_used_read(), kmem_alloc_max);
} else { } else {
/* Marked unlikely because we should never be doing this, /* Marked unlikely because we should never be doing this,
* we tolerate to up 2 pages but a single page is best. */ * we tolerate to up 2 pages but a single page is best. */
if (unlikely((size > PAGE_SIZE*2) && !(flags & KM_NODEBUG))) { if (unlikely((size > PAGE_SIZE*2) && !(flags & KM_NODEBUG))) {
CWARN("Large kmem_alloc(%llu, 0x%x) (%lld/%llu)\n", CDEBUG_LIMIT(D_CONSOLE | D_WARNING, "large "
(unsigned long long) size, flags, "kmem_alloc(%llu, 0x%x) at %s:%d (%lld/%llu)\n",
(unsigned long long) size, flags, func, line,
kmem_alloc_used_read(), kmem_alloc_max); kmem_alloc_used_read(), kmem_alloc_max);
spl_debug_dumpstack(NULL); spl_debug_dumpstack(NULL);
} }
@ -449,9 +452,9 @@ kmem_alloc_track(size_t size, int flags, const char *func, int line,
dptr->kd_func = kstrdup(func, flags & ~__GFP_ZERO); dptr->kd_func = kstrdup(func, flags & ~__GFP_ZERO);
if (unlikely(dptr->kd_func == NULL)) { if (unlikely(dptr->kd_func == NULL)) {
kfree(dptr); kfree(dptr);
CWARN("kstrdup() failed in kmem_alloc(%llu, 0x%x) " CDEBUG_LIMIT(D_CONSOLE | D_WARNING,
"(%lld/%llu)\n", (unsigned long long) size, flags, "debug kstrdup() at %s:%d failed (%lld/%llu)\n",
kmem_alloc_used_read(), kmem_alloc_max); func, line, kmem_alloc_used_read(), kmem_alloc_max);
goto out; goto out;
} }
@ -468,8 +471,9 @@ kmem_alloc_track(size_t size, int flags, const char *func, int line,
if (unlikely(ptr == NULL)) { if (unlikely(ptr == NULL)) {
kfree(dptr->kd_func); kfree(dptr->kd_func);
kfree(dptr); kfree(dptr);
CWARN("kmem_alloc(%llu, 0x%x) failed (%lld/%llu)\n", CDEBUG_LIMIT(D_CONSOLE | D_WARNING, "kmem_alloc"
(unsigned long long) size, flags, "(%llu, 0x%x) at %s:%d failed (%lld/%llu)\n",
(unsigned long long) size, flags, func, line,
kmem_alloc_used_read(), kmem_alloc_max); kmem_alloc_used_read(), kmem_alloc_max);
goto out; goto out;
} }
@ -491,10 +495,10 @@ kmem_alloc_track(size_t size, int flags, const char *func, int line,
list_add_tail(&dptr->kd_list, &kmem_list); list_add_tail(&dptr->kd_list, &kmem_list);
spin_unlock_irqrestore(&kmem_lock, irq_flags); spin_unlock_irqrestore(&kmem_lock, irq_flags);
CDEBUG_LIMIT(D_INFO, "kmem_alloc(%llu, 0x%x) = %p " CDEBUG_LIMIT(D_INFO,
"(%lld/%llu)\n", (unsigned long long) size, flags, "kmem_alloc(%llu, 0x%x) at %s:%d = %p (%lld/%llu)\n",
ptr, kmem_alloc_used_read(), (unsigned long long) size, flags, func, line, ptr,
kmem_alloc_max); kmem_alloc_used_read(), kmem_alloc_max);
} }
out: out:
RETURN(ptr); RETURN(ptr);
@ -549,8 +553,10 @@ vmem_alloc_track(size_t size, int flags, const char *func, int line)
dptr = (kmem_debug_t *) kmalloc_nofail(sizeof(kmem_debug_t), dptr = (kmem_debug_t *) kmalloc_nofail(sizeof(kmem_debug_t),
flags & ~__GFP_ZERO); flags & ~__GFP_ZERO);
if (dptr == NULL) { if (dptr == NULL) {
CWARN("vmem_alloc(%ld, 0x%x) debug failed\n", CDEBUG_LIMIT(D_CONSOLE | D_WARNING, "debug "
sizeof(kmem_debug_t), flags); "vmem_alloc(%ld, 0x%x) at %s:%d failed (%lld/%llu)\n",
sizeof(kmem_debug_t), flags, func, line,
vmem_alloc_used_read(), vmem_alloc_max);
} else { } else {
/* We use kstrdup() below because the string pointed to by /* We use kstrdup() below because the string pointed to by
* __FUNCTION__ might not be available by the time we want * __FUNCTION__ might not be available by the time we want
@ -558,9 +564,9 @@ vmem_alloc_track(size_t size, int flags, const char *func, int line)
dptr->kd_func = kstrdup(func, flags & ~__GFP_ZERO); dptr->kd_func = kstrdup(func, flags & ~__GFP_ZERO);
if (unlikely(dptr->kd_func == NULL)) { if (unlikely(dptr->kd_func == NULL)) {
kfree(dptr); kfree(dptr);
CWARN("kstrdup() failed in vmem_alloc(%llu, 0x%x) " CDEBUG_LIMIT(D_CONSOLE | D_WARNING,
"(%lld/%llu)\n", (unsigned long long) size, flags, "debug kstrdup() at %s:%d failed (%lld/%llu)\n",
vmem_alloc_used_read(), vmem_alloc_max); func, line, vmem_alloc_used_read(), vmem_alloc_max);
goto out; goto out;
} }
@ -570,8 +576,9 @@ vmem_alloc_track(size_t size, int flags, const char *func, int line)
if (unlikely(ptr == NULL)) { if (unlikely(ptr == NULL)) {
kfree(dptr->kd_func); kfree(dptr->kd_func);
kfree(dptr); kfree(dptr);
CWARN("vmem_alloc(%llu, 0x%x) failed (%lld/%llu)\n", CDEBUG_LIMIT(D_CONSOLE | D_WARNING, "vmem_alloc"
(unsigned long long) size, flags, "(%llu, 0x%x) at %s:%d failed (%lld/%llu)\n",
(unsigned long long) size, flags, func, line,
vmem_alloc_used_read(), vmem_alloc_max); vmem_alloc_used_read(), vmem_alloc_max);
goto out; goto out;
} }
@ -596,10 +603,10 @@ vmem_alloc_track(size_t size, int flags, const char *func, int line)
list_add_tail(&dptr->kd_list, &vmem_list); list_add_tail(&dptr->kd_list, &vmem_list);
spin_unlock_irqrestore(&vmem_lock, irq_flags); spin_unlock_irqrestore(&vmem_lock, irq_flags);
CDEBUG_LIMIT(D_INFO, "vmem_alloc(%llu, 0x%x) = %p " CDEBUG_LIMIT(D_INFO,
"(%lld/%llu)\n", (unsigned long long) size, flags, "vmem_alloc(%llu, 0x%x) at %s:%d = %p (%lld/%llu)\n",
ptr, vmem_alloc_used_read(), (unsigned long long) size, flags, func, line,
vmem_alloc_max); ptr, vmem_alloc_used_read(), vmem_alloc_max);
} }
out: out:
RETURN(ptr); RETURN(ptr);
@ -652,8 +659,9 @@ kmem_alloc_debug(size_t size, int flags, const char *func, int line,
/* Marked unlikely because we should never be doing this, /* Marked unlikely because we should never be doing this,
* we tolerate to up 2 pages but a single page is best. */ * we tolerate to up 2 pages but a single page is best. */
if (unlikely((size > PAGE_SIZE * 2) && !(flags & KM_NODEBUG))) { if (unlikely((size > PAGE_SIZE * 2) && !(flags & KM_NODEBUG))) {
CWARN("Large kmem_alloc(%llu, 0x%x) (%lld/%llu)\n", CDEBUG(D_CONSOLE | D_WARNING,
(unsigned long long) size, flags, "Large kmem_alloc(%llu, 0x%x) at %s:%d (%lld/%llu)\n",
(unsigned long long) size, flags, func, line,
kmem_alloc_used_read(), kmem_alloc_max); kmem_alloc_used_read(), kmem_alloc_max);
spl_debug_dumpstack(NULL); spl_debug_dumpstack(NULL);
} }
@ -669,16 +677,18 @@ kmem_alloc_debug(size_t size, int flags, const char *func, int line,
} }
if (ptr == NULL) { if (ptr == NULL) {
CWARN("kmem_alloc(%llu, 0x%x) failed (%lld/%llu)\n", CDEBUG_LIMIT(D_CONSOLE | D_WARNING,
(unsigned long long) size, flags, "kmem_alloc(%llu, 0x%x) at %s:%d failed (%lld/%llu)\n",
(unsigned long long) size, flags, func, line,
kmem_alloc_used_read(), kmem_alloc_max); kmem_alloc_used_read(), kmem_alloc_max);
} else { } else {
kmem_alloc_used_add(size); kmem_alloc_used_add(size);
if (unlikely(kmem_alloc_used_read() > kmem_alloc_max)) if (unlikely(kmem_alloc_used_read() > kmem_alloc_max))
kmem_alloc_max = kmem_alloc_used_read(); kmem_alloc_max = kmem_alloc_used_read();
CDEBUG_LIMIT(D_INFO, "kmem_alloc(%llu, 0x%x) = %p " CDEBUG_LIMIT(D_INFO,
"(%lld/%llu)\n", (unsigned long long) size, flags, ptr, "kmem_alloc(%llu, 0x%x) at %s:%d = %p (%lld/%llu)\n",
(unsigned long long) size, flags, func, line, ptr,
kmem_alloc_used_read(), kmem_alloc_max); kmem_alloc_used_read(), kmem_alloc_max);
} }
RETURN(ptr); RETURN(ptr);
@ -716,8 +726,9 @@ vmem_alloc_debug(size_t size, int flags, const char *func, int line)
ptr = __vmalloc(size, (flags | __GFP_HIGHMEM) & ~__GFP_ZERO, ptr = __vmalloc(size, (flags | __GFP_HIGHMEM) & ~__GFP_ZERO,
PAGE_KERNEL); PAGE_KERNEL);
if (ptr == NULL) { if (ptr == NULL) {
CWARN("vmem_alloc(%llu, 0x%x) failed (%lld/%llu)\n", CDEBUG_LIMIT(D_CONSOLE | D_WARNING,
(unsigned long long) size, flags, "vmem_alloc(%llu, 0x%x) at %s:%d failed (%lld/%llu)\n",
(unsigned long long) size, flags, func, line,
vmem_alloc_used_read(), vmem_alloc_max); vmem_alloc_used_read(), vmem_alloc_max);
} else { } else {
if (flags & __GFP_ZERO) if (flags & __GFP_ZERO)
@ -2036,13 +2047,15 @@ spl_kmem_fini(void)
* at that address to aid in debugging. Performance is not * at that address to aid in debugging. Performance is not
* a serious concern here since it is module unload time. */ * a serious concern here since it is module unload time. */
if (kmem_alloc_used_read() != 0) if (kmem_alloc_used_read() != 0)
CWARN("kmem leaked %ld/%ld bytes\n", CDEBUG_LIMIT(D_CONSOLE | D_WARNING,
kmem_alloc_used_read(), kmem_alloc_max); "kmem leaked %ld/%ld bytes\n",
kmem_alloc_used_read(), kmem_alloc_max);
if (vmem_alloc_used_read() != 0) if (vmem_alloc_used_read() != 0)
CWARN("vmem leaked %ld/%ld bytes\n", CDEBUG_LIMIT(D_CONSOLE | D_WARNING,
vmem_alloc_used_read(), vmem_alloc_max); "vmem leaked %ld/%ld bytes\n",
vmem_alloc_used_read(), vmem_alloc_max);
spl_kmem_fini_tracking(&kmem_list, &kmem_lock); spl_kmem_fini_tracking(&kmem_list, &kmem_lock);
spl_kmem_fini_tracking(&vmem_list, &vmem_lock); spl_kmem_fini_tracking(&vmem_list, &vmem_lock);