Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

DLPX-40252 integrate EP-476 compressed zfs send/receive 

Authored by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: Tom Caputi <tcaputi@datto.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Ported by: David Quigley <david.quigley@intel.com>
Issue #5078
This commit is contained in:
Dan Kimmel 2016-07-11 13:45:52 -04:00 committed by Brian Behlendorf
parent d3c2ae1c08
commit 2aa34383b9
24 changed files with 1062 additions and 550 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
cmd/zfs/zfs_main.c
View File

@ -261,7 +261,7 @@ get_usage(zfs_help_t idx)
case HELP_ROLLBACK: case HELP_ROLLBACK:
return (gettext("\trollback [-rRf] <snapshot>\n")); return (gettext("\trollback [-rRf] <snapshot>\n"));
case HELP_SEND: case HELP_SEND:
return (gettext("\tsend [-DnPpRvLe] [-[iI] snapshot] " return (gettext("\tsend [-DnPpRvLec] [-[iI] snapshot] "
"<snapshot>\n" "<snapshot>\n"
"\tsend [-Le] [-i snapshot|bookmark] " "\tsend [-Le] [-i snapshot|bookmark] "
"<filesystem|volume|snapshot>\n" "<filesystem|volume|snapshot>\n"
@ -3733,7 +3733,7 @@ zfs_do_send(int argc, char **argv)
boolean_t extraverbose = B_FALSE; boolean_t extraverbose = B_FALSE;
/* check options */ /* check options */
while ((c = getopt(argc, argv, ":i:I:RDpvnPLet:")) != -1) { while ((c = getopt(argc, argv, ":i:I:RDpvnPLet:c")) != -1) {
switch (c) { switch (c) {
case 'i': case 'i':
if (fromname) if (fromname)
@ -3777,6 +3777,9 @@ zfs_do_send(int argc, char **argv)
case 't': case 't':
resume_token = optarg; resume_token = optarg;
break; break;
case 'c':
flags.compress = B_TRUE;
break;
case ':': case ':':
(void) fprintf(stderr, gettext("missing argument for " (void) fprintf(stderr, gettext("missing argument for "
"'%c' option\n"), optopt); "'%c' option\n"), optopt);
@ -3853,6 +3856,8 @@ zfs_do_send(int argc, char **argv)
lzc_flags |= LZC_SEND_FLAG_LARGE_BLOCK; lzc_flags |= LZC_SEND_FLAG_LARGE_BLOCK;
if (flags.embed_data) if (flags.embed_data)
lzc_flags |= LZC_SEND_FLAG_EMBED_DATA; lzc_flags |= LZC_SEND_FLAG_EMBED_DATA;
if (flags.compress)
lzc_flags |= LZC_SEND_FLAG_COMPRESS;
if (fromname != NULL && if (fromname != NULL &&
(fromname[0] == '#' || fromname[0] == '@')) { (fromname[0] == '#' || fromname[0] == '@')) {

30
cmd/zstreamdump/zstreamdump.c
View File

@ -27,7 +27,7 @@
*/ */
/* /*
* Copyright (c) 2013, 2014 by Delphix. All rights reserved. * Copyright (c) 2013, 2015 by Delphix. All rights reserved.
*/ */
#include <ctype.h> #include <ctype.h>
@ -40,6 +40,7 @@
#include <sys/dmu.h> #include <sys/dmu.h>
#include <sys/zfs_ioctl.h> #include <sys/zfs_ioctl.h>
#include <sys/zio.h>
#include <zfs_fletcher.h> #include <zfs_fletcher.h>
/* /*
@ -252,6 +253,7 @@ main(int argc, char *argv[])
(void) fprintf(stderr, "invalid option '%c'\n", (void) fprintf(stderr, "invalid option '%c'\n",
optopt); optopt);
usage(); usage();
break;
} }
} }
@ -457,38 +459,50 @@ main(int argc, char *argv[])
drrw->drr_object = BSWAP_64(drrw->drr_object); drrw->drr_object = BSWAP_64(drrw->drr_object);
drrw->drr_type = BSWAP_32(drrw->drr_type); drrw->drr_type = BSWAP_32(drrw->drr_type);
drrw->drr_offset = BSWAP_64(drrw->drr_offset); drrw->drr_offset = BSWAP_64(drrw->drr_offset);
drrw->drr_length = BSWAP_64(drrw->drr_length); drrw->drr_logical_size =
BSWAP_64(drrw->drr_logical_size);
drrw->drr_toguid = BSWAP_64(drrw->drr_toguid); drrw->drr_toguid = BSWAP_64(drrw->drr_toguid);
drrw->drr_key.ddk_prop = drrw->drr_key.ddk_prop =
BSWAP_64(drrw->drr_key.ddk_prop); BSWAP_64(drrw->drr_key.ddk_prop);
drrw->drr_compressed_size =
BSWAP_64(drrw->drr_compressed_size);
} }
uint64_t payload_size = DRR_WRITE_PAYLOAD_SIZE(drrw);
/* /*
* If this is verbose and/or dump output, * If this is verbose and/or dump output,
* print info on the modified block * print info on the modified block
*/ */
if (verbose) { if (verbose) {
(void) printf("WRITE object = %llu type = %u " (void) printf("WRITE object = %llu type = %u "
"checksum type = %u\n" "checksum type = %u compression type = %u\n"
" offset = %llu length = %llu " " offset = %llu logical_size = %llu "
"compressed_size = %llu "
"payload_size = %llu "
"props = %llx\n", "props = %llx\n",
(u_longlong_t)drrw->drr_object, (u_longlong_t)drrw->drr_object,
drrw->drr_type, drrw->drr_type,
drrw->drr_checksumtype, drrw->drr_checksumtype,
drrw->drr_compressiontype,
(u_longlong_t)drrw->drr_offset, (u_longlong_t)drrw->drr_offset,
(u_longlong_t)drrw->drr_length, (u_longlong_t)drrw->drr_logical_size,
(u_longlong_t)drrw->drr_compressed_size,
(u_longlong_t)payload_size,
(u_longlong_t)drrw->drr_key.ddk_prop); (u_longlong_t)drrw->drr_key.ddk_prop);
} }
/* /*
* Read the contents of the block in from STDIN to buf * Read the contents of the block in from STDIN to buf
*/ */
(void) ssread(buf, drrw->drr_length, &zc); (void) ssread(buf, payload_size, &zc);
/* /*
* If in dump mode * If in dump mode
*/ */
if (dump) { if (dump) {
print_block(buf, drrw->drr_length); print_block(buf, payload_size);
} }
total_write_size += drrw->drr_length; total_write_size += payload_size;
break; break;
case DRR_WRITE_BYREF: case DRR_WRITE_BYREF:

3
include/libzfs.h
View File

@ -631,6 +631,9 @@ typedef struct sendflags {
/* WRITE_EMBEDDED records of type DATA are permitted */ /* WRITE_EMBEDDED records of type DATA are permitted */
boolean_t embed_data; boolean_t embed_data;
/* compressed WRITE records are permitted */
boolean_t compress;
} sendflags_t; } sendflags_t;
typedef boolean_t (snapfilter_cb_t)(zfs_handle_t *, void *); typedef boolean_t (snapfilter_cb_t)(zfs_handle_t *, void *);

5
include/libzfs_core.h
View File

@ -54,13 +54,14 @@ int lzc_get_holds(const char *, nvlist_t **);
enum lzc_send_flags { enum lzc_send_flags {
LZC_SEND_FLAG_EMBED_DATA = 1 << 0, LZC_SEND_FLAG_EMBED_DATA = 1 << 0,
LZC_SEND_FLAG_LARGE_BLOCK = 1 << 1 LZC_SEND_FLAG_LARGE_BLOCK = 1 << 1,
LZC_SEND_FLAG_COMPRESS = 1 << 2
}; };
int lzc_send(const char *, const char *, int, enum lzc_send_flags); int lzc_send(const char *, const char *, int, enum lzc_send_flags);
int lzc_send_resume(const char *, const char *, int, int lzc_send_resume(const char *, const char *, int,
enum lzc_send_flags, uint64_t, uint64_t); enum lzc_send_flags, uint64_t, uint64_t);
int lzc_send_space(const char *, const char *, uint64_t *); int lzc_send_space(const char *, const char *, enum lzc_send_flags, uint64_t *);
struct dmu_replay_record; struct dmu_replay_record;

20
include/sys/arc.h
View File

@ -142,11 +142,17 @@ typedef enum arc_flags
} arc_flags_t; } arc_flags_t;
typedef enum arc_buf_flags {
ARC_BUF_FLAG_SHARED = 1 << 0,
ARC_BUF_FLAG_COMPRESSED = 1 << 1
} arc_buf_flags_t;
struct arc_buf { struct arc_buf {
arc_buf_hdr_t *b_hdr; arc_buf_hdr_t *b_hdr;
arc_buf_t *b_next; arc_buf_t *b_next;
kmutex_t b_evict_lock; kmutex_t b_evict_lock;
void *b_data; void *b_data;
arc_buf_flags_t b_prop_flags;
}; };
typedef enum arc_buf_contents { typedef enum arc_buf_contents {
@ -201,14 +207,22 @@ typedef struct arc_buf_info {
void arc_space_consume(uint64_t space, arc_space_type_t type); void arc_space_consume(uint64_t space, arc_space_type_t type);
void arc_space_return(uint64_t space, arc_space_type_t type); void arc_space_return(uint64_t space, arc_space_type_t type);
arc_buf_t *arc_alloc_buf(spa_t *spa, int32_t size, void *tag, boolean_t arc_is_metadata(arc_buf_t *buf);
arc_buf_contents_t type); enum zio_compress arc_get_compression(arc_buf_t *buf);
arc_buf_t *arc_loan_buf(spa_t *spa, uint64_t size); int arc_decompress(arc_buf_t *buf);
arc_buf_t *arc_alloc_buf(spa_t *spa, void *tag, arc_buf_contents_t type,
int32_t size);
arc_buf_t *arc_alloc_compressed_buf(spa_t *spa, void *tag,
uint64_t psize, uint64_t lsize, enum zio_compress compression_type);
arc_buf_t *arc_loan_buf(spa_t *spa, boolean_t is_metadata, int size);
arc_buf_t *arc_loan_compressed_buf(spa_t *spa, uint64_t psize, uint64_t lsize,
enum zio_compress compression_type);
void arc_return_buf(arc_buf_t *buf, void *tag); void arc_return_buf(arc_buf_t *buf, void *tag);
void arc_loan_inuse_buf(arc_buf_t *buf, void *tag); void arc_loan_inuse_buf(arc_buf_t *buf, void *tag);
void arc_buf_destroy(arc_buf_t *buf, void *tag); void arc_buf_destroy(arc_buf_t *buf, void *tag);
void arc_buf_info(arc_buf_t *buf, arc_buf_info_t *abi, int state_index); void arc_buf_info(arc_buf_t *buf, arc_buf_info_t *abi, int state_index);
uint64_t arc_buf_size(arc_buf_t *buf); uint64_t arc_buf_size(arc_buf_t *buf);
uint64_t arc_buf_lsize(arc_buf_t *buf);
void arc_release(arc_buf_t *buf, void *tag); void arc_release(arc_buf_t *buf, void *tag);
int arc_released(arc_buf_t *buf); int arc_released(arc_buf_t *buf);
void arc_buf_sigsegv(int sig, siginfo_t *si, void *unused); void arc_buf_sigsegv(int sig, siginfo_t *si, void *unused);

1
include/sys/arc_impl.h
View File

@ -92,6 +92,7 @@ struct arc_callback {
void *acb_private; void *acb_private;
arc_done_func_t *acb_done; arc_done_func_t *acb_done;
arc_buf_t *acb_buf; arc_buf_t *acb_buf;
boolean_t acb_compressed;
zio_t *acb_zio_dummy; zio_t *acb_zio_dummy;
arc_callback_t *acb_next; arc_callback_t *acb_next;
}; };

5
include/sys/dmu.h
View File

@ -44,6 +44,7 @@
#include <sys/inttypes.h> #include <sys/inttypes.h>
#include <sys/cred.h> #include <sys/cred.h>
#include <sys/fs/zfs.h> #include <sys/fs/zfs.h>
#include <sys/zio_compress.h>
#include <sys/zio_priority.h> #include <sys/zio_priority.h>
#include <sys/uio.h> #include <sys/uio.h>
@ -421,8 +422,8 @@ dmu_write_embedded(objset_t *os, uint64_t object, uint64_t offset,
#define WP_DMU_SYNC 0x2 #define WP_DMU_SYNC 0x2
#define WP_SPILL 0x4 #define WP_SPILL 0x4
void dmu_write_policy(objset_t *os, dnode_t *dn, int level, int wp, void dmu_write_policy(objset_t *os, struct dnode *dn, int level, int wp,
struct zio_prop *zp); enum zio_compress compress_override, struct zio_prop *zp);
/* /*
* The bonus data is accessed more or less like a regular buffer. * The bonus data is accessed more or less like a regular buffer.
* You must dmu_bonus_hold() to get the buffer, which will give you a * You must dmu_bonus_hold() to get the buffer, which will give you a

10
include/sys/dmu_send.h
View File

@ -41,14 +41,14 @@ struct dmu_replay_record;
extern const char *recv_clone_name; extern const char *recv_clone_name;
int dmu_send(const char *tosnap, const char *fromsnap, boolean_t embedok, int dmu_send(const char *tosnap, const char *fromsnap, boolean_t embedok,
boolean_t large_block_ok, int outfd, uint64_t resumeobj, uint64_t resumeoff, boolean_t large_block_ok, boolean_t compressok, int outfd,
struct vnode *vp, offset_t *off); uint64_t resumeobj, uint64_t resumeoff, struct vnode *vp, offset_t *off);
int dmu_send_estimate(struct dsl_dataset *ds, struct dsl_dataset *fromds, int dmu_send_estimate(struct dsl_dataset *ds, struct dsl_dataset *fromds,
uint64_t *sizep); boolean_t stream_compressed, uint64_t *sizep);
int dmu_send_estimate_from_txg(struct dsl_dataset *ds, uint64_t fromtxg, int dmu_send_estimate_from_txg(struct dsl_dataset *ds, uint64_t fromtxg,
uint64_t *sizep); boolean_t stream_compressed, uint64_t *sizep);
int dmu_send_obj(const char *pool, uint64_t tosnap, uint64_t fromsnap, int dmu_send_obj(const char *pool, uint64_t tosnap, uint64_t fromsnap,
boolean_t embedok, boolean_t large_block_ok, boolean_t embedok, boolean_t large_block_ok, boolean_t compressok,
int outfd, struct vnode *vp, offset_t *off); int outfd, struct vnode *vp, offset_t *off);
typedef struct dmu_recv_cookie { typedef struct dmu_recv_cookie {

2
include/sys/dsl_dataset.h
View File

@ -108,7 +108,9 @@ struct dsl_pool;
#define DS_FIELD_RESUME_OBJECT "com.delphix:resume_object" #define DS_FIELD_RESUME_OBJECT "com.delphix:resume_object"
#define DS_FIELD_RESUME_OFFSET "com.delphix:resume_offset" #define DS_FIELD_RESUME_OFFSET "com.delphix:resume_offset"
#define DS_FIELD_RESUME_BYTES "com.delphix:resume_bytes" #define DS_FIELD_RESUME_BYTES "com.delphix:resume_bytes"
#define DS_FIELD_RESUME_LARGEBLOCK "com.delphix:resume_largeblockok"
#define DS_FIELD_RESUME_EMBEDOK "com.delphix:resume_embedok" #define DS_FIELD_RESUME_EMBEDOK "com.delphix:resume_embedok"
#define DS_FIELD_RESUME_COMPRESSOK "com.delphix:resume_compressok"
/* /*
* DS_FLAG_CI_DATASET is set if the dataset contains a file system whose * DS_FLAG_CI_DATASET is set if the dataset contains a file system whose

2
include/sys/refcount.h
View File

@ -98,7 +98,7 @@ typedef struct refcount {
atomic_add_64(&(src)->rc_count, -__tmp); \ atomic_add_64(&(src)->rc_count, -__tmp); \
atomic_add_64(&(dst)->rc_count, __tmp); \ atomic_add_64(&(dst)->rc_count, __tmp); \
} }
#define refcount_transfer_ownership(rc, current_holder, new_holder) #define refcount_transfer_ownership(rc, current_holder, new_holder) (void)0
#define refcount_init() #define refcount_init()
#define refcount_fini() #define refcount_fini()

23
include/sys/zfs_ioctl.h
View File

@ -96,20 +96,21 @@ typedef enum drr_headertype {
#define DMU_BACKUP_FEATURE_SA_SPILL (1 << 2) #define DMU_BACKUP_FEATURE_SA_SPILL (1 << 2)
/* flags #3 - #15 are reserved for incompatible closed-source implementations */ /* flags #3 - #15 are reserved for incompatible closed-source implementations */
#define DMU_BACKUP_FEATURE_EMBED_DATA (1 << 16) #define DMU_BACKUP_FEATURE_EMBED_DATA (1 << 16)
#define DMU_BACKUP_FEATURE_EMBED_DATA_LZ4 (1 << 17) #define DMU_BACKUP_FEATURE_LZ4 (1 << 17)
/* flag #18 is reserved for a Delphix feature */ /* flag #18 is reserved for a Delphix feature */
#define DMU_BACKUP_FEATURE_LARGE_BLOCKS (1 << 19) #define DMU_BACKUP_FEATURE_LARGE_BLOCKS (1 << 19)
#define DMU_BACKUP_FEATURE_RESUMING (1 << 20) #define DMU_BACKUP_FEATURE_RESUMING (1 << 20)
#define DMU_BACKUP_FEATURE_LARGE_DNODE (1 << 21) #define DMU_BACKUP_FEATURE_LARGE_DNODE (1 << 21)
#define DMU_BACKUP_FEATURE_COMPRESSED (1 << 22)
/* /*
* Mask of all supported backup features * Mask of all supported backup features
*/ */
#define DMU_BACKUP_FEATURE_MASK (DMU_BACKUP_FEATURE_DEDUP | \ #define DMU_BACKUP_FEATURE_MASK (DMU_BACKUP_FEATURE_DEDUP | \
DMU_BACKUP_FEATURE_DEDUPPROPS | DMU_BACKUP_FEATURE_SA_SPILL | \ DMU_BACKUP_FEATURE_DEDUPPROPS | DMU_BACKUP_FEATURE_SA_SPILL | \
DMU_BACKUP_FEATURE_EMBED_DATA | DMU_BACKUP_FEATURE_EMBED_DATA_LZ4 | \ DMU_BACKUP_FEATURE_EMBED_DATA | DMU_BACKUP_FEATURE_LZ4 | \
DMU_BACKUP_FEATURE_RESUMING | DMU_BACKUP_FEATURE_LARGE_BLOCKS | \ DMU_BACKUP_FEATURE_RESUMING | DMU_BACKUP_FEATURE_LARGE_BLOCKS | \
DMU_BACKUP_FEATURE_LARGE_DNODE) DMU_BACKUP_FEATURE_COMPRESSED | DMU_BACKUP_FEATURE_LARGE_DNODE)
/* Are all features in the given flag word currently supported? */ /* Are all features in the given flag word currently supported? */
#define DMU_STREAM_SUPPORTED(x) (!((x) & ~DMU_BACKUP_FEATURE_MASK)) #define DMU_STREAM_SUPPORTED(x) (!((x) & ~DMU_BACKUP_FEATURE_MASK))
@ -162,6 +163,12 @@ typedef enum dmu_send_resume_token_version {
#define DRR_IS_DEDUP_CAPABLE(flags) ((flags) & DRR_CHECKSUM_DEDUP) #define DRR_IS_DEDUP_CAPABLE(flags) ((flags) & DRR_CHECKSUM_DEDUP)
/* deal with compressed drr_write replay records */
#define DRR_WRITE_COMPRESSED(drrw) ((drrw)->drr_compressiontype != 0)
#define DRR_WRITE_PAYLOAD_SIZE(drrw) \
(DRR_WRITE_COMPRESSED(drrw) ? (drrw)->drr_compressed_size : \
(drrw)->drr_logical_size)
/* /*
* zfs ioctl command structure * zfs ioctl command structure
*/ */
@ -210,12 +217,16 @@ typedef struct dmu_replay_record {
dmu_object_type_t drr_type; dmu_object_type_t drr_type;
uint32_t drr_pad; uint32_t drr_pad;
uint64_t drr_offset; uint64_t drr_offset;
uint64_t drr_length; uint64_t drr_logical_size;
uint64_t drr_toguid; uint64_t drr_toguid;
uint8_t drr_checksumtype; uint8_t drr_checksumtype;
uint8_t drr_checksumflags; uint8_t drr_checksumflags;
uint8_t drr_pad2[6]; uint8_t drr_compressiontype;
ddt_key_t drr_key; /* deduplication key */ uint8_t drr_pad2[5];
/* deduplication key */
ddt_key_t drr_key;
/* only nonzero if drr_compressiontype is not 0 */
uint64_t drr_compressed_size;
/* content follows */ /* content follows */
} drr_write; } drr_write;
struct drr_free { struct drr_free {

26
include/sys/zio.h
View File

@ -98,26 +98,6 @@ enum zio_checksum {
#define ZIO_DEDUPCHECKSUM ZIO_CHECKSUM_SHA256 #define ZIO_DEDUPCHECKSUM ZIO_CHECKSUM_SHA256
#define ZIO_DEDUPDITTO_MIN 100 #define ZIO_DEDUPDITTO_MIN 100
enum zio_compress {
ZIO_COMPRESS_INHERIT = 0,
ZIO_COMPRESS_ON,
ZIO_COMPRESS_OFF,
ZIO_COMPRESS_LZJB,
ZIO_COMPRESS_EMPTY,
ZIO_COMPRESS_GZIP_1,
ZIO_COMPRESS_GZIP_2,
ZIO_COMPRESS_GZIP_3,
ZIO_COMPRESS_GZIP_4,
ZIO_COMPRESS_GZIP_5,
ZIO_COMPRESS_GZIP_6,
ZIO_COMPRESS_GZIP_7,
ZIO_COMPRESS_GZIP_8,
ZIO_COMPRESS_GZIP_9,
ZIO_COMPRESS_ZLE,
ZIO_COMPRESS_LZ4,
ZIO_COMPRESS_FUNCTIONS
};
/* /*
* The number of "legacy" compression functions which can be set on individual * The number of "legacy" compression functions which can be set on individual
* objects. * objects.
@ -407,6 +387,8 @@ struct zio {
void *io_private; void *io_private;
int64_t io_prev_space_delta; /* DMU private */ int64_t io_prev_space_delta; /* DMU private */
blkptr_t io_bp_orig; blkptr_t io_bp_orig;
/* io_lsize != io_orig_size iff this is a raw write */
uint64_t io_lsize;
/* Data represented by this I/O */ /* Data represented by this I/O */
void *io_data; void *io_data;
@ -464,11 +446,11 @@ extern zio_t *zio_root(spa_t *spa,
zio_done_func_t *done, void *private, enum zio_flag flags); zio_done_func_t *done, void *private, enum zio_flag flags);
extern zio_t *zio_read(zio_t *pio, spa_t *spa, const blkptr_t *bp, void *data, extern zio_t *zio_read(zio_t *pio, spa_t *spa, const blkptr_t *bp, void *data,
uint64_t size, zio_done_func_t *done, void *private, uint64_t lsize, zio_done_func_t *done, void *private,
zio_priority_t priority, enum zio_flag flags, const zbookmark_phys_t *zb); zio_priority_t priority, enum zio_flag flags, const zbookmark_phys_t *zb);
extern zio_t *zio_write(zio_t *pio, spa_t *spa, uint64_t txg, blkptr_t *bp, extern zio_t *zio_write(zio_t *pio, spa_t *spa, uint64_t txg, blkptr_t *bp,
void *data, uint64_t size, const zio_prop_t *zp, void *data, uint64_t size, uint64_t psize, const zio_prop_t *zp,
zio_done_func_t *ready, zio_done_func_t *children_ready, zio_done_func_t *ready, zio_done_func_t *children_ready,
zio_done_func_t *physdone, zio_done_func_t *done, zio_done_func_t *physdone, zio_done_func_t *done,
void *private, zio_priority_t priority, enum zio_flag flags, void *private, zio_priority_t priority, enum zio_flag flags,

23
include/sys/zio_compress.h
View File

@ -22,17 +22,36 @@
/* /*
* Copyright 2009 Sun Microsystems, Inc. All rights reserved. * Copyright 2009 Sun Microsystems, Inc. All rights reserved.
* Use is subject to license terms. * Use is subject to license terms.
* Copyright (c) 2015 by Delphix. All rights reserved.
*/ */
#ifndef _SYS_ZIO_COMPRESS_H #ifndef _SYS_ZIO_COMPRESS_H
#define _SYS_ZIO_COMPRESS_H #define _SYS_ZIO_COMPRESS_H
#include <sys/zio.h>
#ifdef __cplusplus #ifdef __cplusplus
extern "C" { extern "C" {
#endif #endif
enum zio_compress {
ZIO_COMPRESS_INHERIT = 0,
ZIO_COMPRESS_ON,
ZIO_COMPRESS_OFF,
ZIO_COMPRESS_LZJB,
ZIO_COMPRESS_EMPTY,
ZIO_COMPRESS_GZIP_1,
ZIO_COMPRESS_GZIP_2,
ZIO_COMPRESS_GZIP_3,
ZIO_COMPRESS_GZIP_4,
ZIO_COMPRESS_GZIP_5,
ZIO_COMPRESS_GZIP_6,
ZIO_COMPRESS_GZIP_7,
ZIO_COMPRESS_GZIP_8,
ZIO_COMPRESS_GZIP_9,
ZIO_COMPRESS_ZLE,
ZIO_COMPRESS_LZ4,
ZIO_COMPRESS_FUNCTIONS
};
/* Common signature for all zio compress functions. */ /* Common signature for all zio compress functions. */
typedef size_t zio_compress_func_t(void *src, void *dst, typedef size_t zio_compress_func_t(void *src, void *dst,
size_t s_len, size_t d_len, int); size_t s_len, size_t d_len, int);

51
lib/libzfs/libzfs_sendrecv.c
View File

@ -352,8 +352,10 @@ cksummer(void *arg)
{ {
struct drr_write *drrw = &drr->drr_u.drr_write; struct drr_write *drrw = &drr->drr_u.drr_write;
dataref_t dataref; dataref_t dataref;
uint64_t payload_size;
(void) ssread(buf, drrw->drr_length, ofp); payload_size = DRR_WRITE_PAYLOAD_SIZE(drrw);
(void) ssread(buf, payload_size, ofp);
/* /*
* Use the existing checksum if it's dedup-capable, * Use the existing checksum if it's dedup-capable,
@ -366,7 +368,7 @@ cksummer(void *arg)
zio_cksum_t tmpsha256; zio_cksum_t tmpsha256;
zio_checksum_SHA256(buf, zio_checksum_SHA256(buf,
drrw->drr_length, &tmpsha256); payload_size, &tmpsha256);
drrw->drr_key.ddk_cksum.zc_word[0] = drrw->drr_key.ddk_cksum.zc_word[0] =
BE_64(tmpsha256.zc_word[0]); BE_64(tmpsha256.zc_word[0]);
@ -396,7 +398,7 @@ cksummer(void *arg)
wbr_drrr->drr_object = drrw->drr_object; wbr_drrr->drr_object = drrw->drr_object;
wbr_drrr->drr_offset = drrw->drr_offset; wbr_drrr->drr_offset = drrw->drr_offset;
wbr_drrr->drr_length = drrw->drr_length; wbr_drrr->drr_length = drrw->drr_logical_size;
wbr_drrr->drr_toguid = drrw->drr_toguid; wbr_drrr->drr_toguid = drrw->drr_toguid;
wbr_drrr->drr_refguid = dataref.ref_guid; wbr_drrr->drr_refguid = dataref.ref_guid;
wbr_drrr->drr_refobject = wbr_drrr->drr_refobject =
@ -418,7 +420,7 @@ cksummer(void *arg)
goto out; goto out;
} else { } else {
/* block not previously seen */ /* block not previously seen */
if (dump_record(drr, buf, drrw->drr_length, if (dump_record(drr, buf, payload_size,
&stream_cksum, outfd) != 0) &stream_cksum, outfd) != 0)
goto out; goto out;
} }
@ -836,7 +838,7 @@ typedef struct send_dump_data {
uint64_t prevsnap_obj; uint64_t prevsnap_obj;
boolean_t seenfrom, seento, replicate, doall, fromorigin; boolean_t seenfrom, seento, replicate, doall, fromorigin;
boolean_t verbose, dryrun, parsable, progress, embed_data, std_out; boolean_t verbose, dryrun, parsable, progress, embed_data, std_out;
boolean_t large_block; boolean_t large_block, compress;
int outfd; int outfd;
boolean_t err; boolean_t err;
nvlist_t *fss; nvlist_t *fss;
@ -852,7 +854,7 @@ typedef struct send_dump_data {
static int static int
estimate_ioctl(zfs_handle_t *zhp, uint64_t fromsnap_obj, estimate_ioctl(zfs_handle_t *zhp, uint64_t fromsnap_obj,
boolean_t fromorigin, uint64_t *sizep) boolean_t fromorigin, enum lzc_send_flags flags, uint64_t *sizep)
{ {
zfs_cmd_t zc = {"\0"}; zfs_cmd_t zc = {"\0"};
libzfs_handle_t *hdl = zhp->zfs_hdl; libzfs_handle_t *hdl = zhp->zfs_hdl;
@ -865,6 +867,7 @@ estimate_ioctl(zfs_handle_t *zhp, uint64_t fromsnap_obj,
zc.zc_sendobj = zfs_prop_get_int(zhp, ZFS_PROP_OBJSETID); zc.zc_sendobj = zfs_prop_get_int(zhp, ZFS_PROP_OBJSETID);
zc.zc_fromobj = fromsnap_obj; zc.zc_fromobj = fromsnap_obj;
zc.zc_guid = 1; /* estimate flag */ zc.zc_guid = 1; /* estimate flag */
zc.zc_flags = flags;
if (zfs_ioctl(zhp->zfs_hdl, ZFS_IOC_SEND, &zc) != 0) { if (zfs_ioctl(zhp->zfs_hdl, ZFS_IOC_SEND, &zc) != 0) {
char errbuf[1024]; char errbuf[1024];
@ -1103,6 +1106,7 @@ dump_snapshot(zfs_handle_t *zhp, void *arg)
progress_arg_t pa = { 0 }; progress_arg_t pa = { 0 };
pthread_t tid; pthread_t tid;
char *thissnap; char *thissnap;
enum lzc_send_flags flags = 0;
int err; int err;
boolean_t isfromsnap, istosnap, fromorigin; boolean_t isfromsnap, istosnap, fromorigin;
boolean_t exclude = B_FALSE; boolean_t exclude = B_FALSE;
@ -1131,6 +1135,13 @@ dump_snapshot(zfs_handle_t *zhp, void *arg)
if (istosnap) if (istosnap)
sdd->seento = B_TRUE; sdd->seento = B_TRUE;
if (sdd->large_block)
flags |= LZC_SEND_FLAG_LARGE_BLOCK;
if (sdd->embed_data)
flags |= LZC_SEND_FLAG_EMBED_DATA;
if (sdd->compress)
flags |= LZC_SEND_FLAG_COMPRESS;
if (!sdd->doall && !isfromsnap && !istosnap) { if (!sdd->doall && !isfromsnap && !istosnap) {
if (sdd->replicate) { if (sdd->replicate) {
char *snapname; char *snapname;
@ -1177,7 +1188,7 @@ dump_snapshot(zfs_handle_t *zhp, void *arg)
if (sdd->verbose) { if (sdd->verbose) {
uint64_t size = 0; uint64_t size = 0;
(void) estimate_ioctl(zhp, sdd->prevsnap_obj, (void) estimate_ioctl(zhp, sdd->prevsnap_obj,
fromorigin, &size); fromorigin, flags, &size);
send_print_verbose(fout, zhp->zfs_name, send_print_verbose(fout, zhp->zfs_name,
sdd->prevsnap[0] ? sdd->prevsnap : NULL, sdd->prevsnap[0] ? sdd->prevsnap : NULL,
@ -1202,12 +1213,6 @@ dump_snapshot(zfs_handle_t *zhp, void *arg)
} }
} }
enum lzc_send_flags flags = 0;
if (sdd->large_block)
flags |= LZC_SEND_FLAG_LARGE_BLOCK;
if (sdd->embed_data)
flags |= LZC_SEND_FLAG_EMBED_DATA;
err = dump_ioctl(zhp, sdd->prevsnap, sdd->prevsnap_obj, err = dump_ioctl(zhp, sdd->prevsnap, sdd->prevsnap_obj,
fromorigin, sdd->outfd, flags, sdd->debugnv); fromorigin, sdd->outfd, flags, sdd->debugnv);
@ -1513,8 +1518,12 @@ zfs_send_resume(libzfs_handle_t *hdl, sendflags_t *flags, int outfd,
fromguid = 0; fromguid = 0;
(void) nvlist_lookup_uint64(resume_nvl, "fromguid", &fromguid); (void) nvlist_lookup_uint64(resume_nvl, "fromguid", &fromguid);
if (flags->largeblock || nvlist_exists(resume_nvl, "largeblockok"))
lzc_flags |= LZC_SEND_FLAG_LARGE_BLOCK;
if (flags->embed_data || nvlist_exists(resume_nvl, "embedok")) if (flags->embed_data || nvlist_exists(resume_nvl, "embedok"))
lzc_flags |= LZC_SEND_FLAG_EMBED_DATA; lzc_flags |= LZC_SEND_FLAG_EMBED_DATA;
if (flags->compress || nvlist_exists(resume_nvl, "compressok"))
lzc_flags |= LZC_SEND_FLAG_COMPRESS;
if (guid_to_name(hdl, toname, toguid, B_FALSE, name) != 0) { if (guid_to_name(hdl, toname, toguid, B_FALSE, name) != 0) {
if (zfs_dataset_exists(hdl, toname, ZFS_TYPE_DATASET)) { if (zfs_dataset_exists(hdl, toname, ZFS_TYPE_DATASET)) {
@ -1547,7 +1556,8 @@ zfs_send_resume(libzfs_handle_t *hdl, sendflags_t *flags, int outfd,
if (flags->verbose) { if (flags->verbose) {
uint64_t size = 0; uint64_t size = 0;
error = lzc_send_space(zhp->zfs_name, fromname, &size); error = lzc_send_space(zhp->zfs_name, fromname,
lzc_flags, &size);
if (error == 0) if (error == 0)
size = MAX(0, (int64_t)(size - bytes)); size = MAX(0, (int64_t)(size - bytes));
send_print_verbose(stderr, zhp->zfs_name, fromname, send_print_verbose(stderr, zhp->zfs_name, fromname,
@ -1776,6 +1786,7 @@ zfs_send(zfs_handle_t *zhp, const char *fromsnap, const char *tosnap,
sdd.dryrun = flags->dryrun; sdd.dryrun = flags->dryrun;
sdd.large_block = flags->largeblock; sdd.large_block = flags->largeblock;
sdd.embed_data = flags->embed_data; sdd.embed_data = flags->embed_data;
sdd.compress = flags->compress;
sdd.filter_cb = filter_func; sdd.filter_cb = filter_func;
sdd.filter_cb_arg = cb_arg; sdd.filter_cb_arg = cb_arg;
if (debugnvp) if (debugnvp)
@ -2871,11 +2882,17 @@ recv_skip(libzfs_handle_t *hdl, int fd, boolean_t byteswap)
case DRR_WRITE: case DRR_WRITE:
if (byteswap) { if (byteswap) {
drr->drr_u.drr_write.drr_length = drr->drr_u.drr_write.drr_logical_size =
BSWAP_64(drr->drr_u.drr_write.drr_length); BSWAP_64(
drr->drr_u.drr_write.drr_logical_size);
drr->drr_u.drr_write.drr_compressed_size =
BSWAP_64(
drr->drr_u.drr_write.drr_compressed_size);
} }
uint64_t payload_size =
DRR_WRITE_PAYLOAD_SIZE(&drr->drr_u.drr_write);
(void) recv_read(hdl, fd, buf, (void) recv_read(hdl, fd, buf,
drr->drr_u.drr_write.drr_length, B_FALSE, NULL); payload_size, B_FALSE, NULL);
break; break;
case DRR_SPILL: case DRR_SPILL:
if (byteswap) { if (byteswap) {

11
lib/libzfs_core/libzfs_core.c
View File

@ -484,6 +484,8 @@ lzc_send_resume(const char *snapname, const char *from, int fd,
fnvlist_add_string(args, "fromsnap", from); fnvlist_add_string(args, "fromsnap", from);
if (flags & LZC_SEND_FLAG_LARGE_BLOCK) if (flags & LZC_SEND_FLAG_LARGE_BLOCK)
fnvlist_add_boolean(args, "largeblockok"); fnvlist_add_boolean(args, "largeblockok");
if (flags & LZC_SEND_FLAG_COMPRESS)
fnvlist_add_boolean(args, "compressok");
if (flags & LZC_SEND_FLAG_EMBED_DATA) if (flags & LZC_SEND_FLAG_EMBED_DATA)
fnvlist_add_boolean(args, "embedok"); fnvlist_add_boolean(args, "embedok");
if (resumeobj != 0 || resumeoff != 0) { if (resumeobj != 0 || resumeoff != 0) {
@ -511,7 +513,8 @@ lzc_send_resume(const char *snapname, const char *from, int fd,
* an equivalent snapshot. * an equivalent snapshot.
*/ */
int int
lzc_send_space(const char *snapname, const char *from, uint64_t *spacep) lzc_send_space(const char *snapname, const char *from,
enum lzc_send_flags flags, uint64_t *spacep)
{ {
nvlist_t *args; nvlist_t *args;
nvlist_t *result; nvlist_t *result;
@ -520,6 +523,12 @@ lzc_send_space(const char *snapname, const char *from, uint64_t *spacep)
args = fnvlist_alloc(); args = fnvlist_alloc();
if (from != NULL) if (from != NULL)
fnvlist_add_string(args, "from", from); fnvlist_add_string(args, "from", from);
if (flags & LZC_SEND_FLAG_LARGE_BLOCK)
fnvlist_add_boolean(args, "largeblockok");
if (flags & LZC_SEND_FLAG_EMBED_DATA)
fnvlist_add_boolean(args, "embedok");
if (flags & LZC_SEND_FLAG_COMPRESS)
fnvlist_add_boolean(args, "compressok");
err = lzc_ioctl(ZFS_IOC_SEND_SPACE, snapname, args, &result); err = lzc_ioctl(ZFS_IOC_SEND_SPACE, snapname, args, &result);
nvlist_free(args); nvlist_free(args);
if (err == 0) if (err == 0)

38
man/man8/zfs.8
View File

@ -175,7 +175,7 @@ zfs \- configures ZFS file systems
.LP .LP
.nf .nf
\fBzfs\fR \fBsend\fR [\fB-DnPpRveL\fR] [\fB-\fR[\fBiI\fR] \fIsnapshot\fR] \fIsnapshot\fR \fBzfs\fR \fBsend\fR [\fB-DnPpRveLc\fR] [\fB-\fR[\fBiI\fR] \fIsnapshot\fR] \fIsnapshot\fR
.fi .fi
.LP .LP
@ -2687,7 +2687,7 @@ See \fBzpool-features\fR(5) for details on ZFS feature flags and the
.sp .sp
.ne 2 .ne 2
.na .na
\fBzfs send\fR [\fB-DnPpRveL\fR] [\fB-\fR[\fBiI\fR] \fIsnapshot\fR] \fIsnapshot\fR \fBzfs send\fR [\fB-DnPpRveLc\fR] [\fB-\fR[\fBiI\fR] \fIsnapshot\fR] \fIsnapshot\fR
.ad .ad
.sp .6 .sp .6
.RS 4n .RS 4n
@ -2768,6 +2768,22 @@ then the receiving system must have that feature enabled as well. See
\fBembedded_data\fR feature. \fBembedded_data\fR feature.
.RE .RE
.sp
.ne 2
.na
\fB\fB-c\fR, \fB--compressed\fR\fR
.ad
.sp .6
.RS 4n
Generate a more compact stream by using compressed WRITE records for blocks
which are compressed on disk and in memory (see the \fBcompression\fR property
for details). If the \fBlz4_compress\fR feature is active on the sending
system, then the receiving system must have that feature enabled as well. If
the \fBlarge_blocks\fR feature is enabled on the sending system but the \fB-L\fR
option is not supplied in conjunction with \fB-c\fR, then the data will be
decompressed before sending so it can be split into smaller block sizes.
.RE
.sp .sp
.ne 2 .ne 2
.na .na
@ -2820,7 +2836,7 @@ The format of the stream is committed. You will be able to receive your streams
.sp .sp
.ne 2 .ne 2
.na .na
\fBzfs send\fR [\fB-Le\fR] [\fB-i\fR \fIsnapshot\fR|\fIbookmark\fR] \fIfilesystem\fR|\fIvolume\fR|\fIsnapshot\fR \fBzfs send\fR [\fB-Lec\fR] [\fB-i\fR \fIsnapshot\fR|\fIbookmark\fR] \fIfilesystem\fR|\fIvolume\fR|\fIsnapshot\fR
.ad .ad
.sp .6 .sp .6
.RS 4n .RS 4n
@ -2862,6 +2878,22 @@ then the receiving system must have that feature enabled as well. See
\fBembedded_data\fR feature. \fBembedded_data\fR feature.
.RE .RE
.sp
.ne 2
.na
\fB\fB-c\fR, \fB--compressed\fR\fR
.ad
.sp .6
.RS 4n
Generate a more compact stream by using compressed WRITE records for blocks
which are compressed on disk and in memory (see the \fBcompression\fR property
for details). If the \fBlz4_compress\fR feature is active on the sending
system, then the receiving system must have that feature enabled as well. If
the \fBlarge_blocks\fR feature is enabled on the sending system but the \fB-L\fR
option is not supplied in conjunction with \fB-c\fR, then the data will be
decompressed before sending so it can be split into smaller block sizes.
.RE
.sp .sp
.ne 2 .ne 2
.na .na

782
module/zfs/arc.c
View File

File diff suppressed because it is too large Load Diff

173
module/zfs/dbuf.c
View File

@ -901,7 +901,7 @@ dbuf_loan_arcbuf(dmu_buf_impl_t *db)
spa_t *spa = db->db_objset->os_spa; spa_t *spa = db->db_objset->os_spa;
mutex_exit(&db->db_mtx); mutex_exit(&db->db_mtx);
abuf = arc_loan_buf(spa, blksz); abuf = arc_loan_buf(spa, B_FALSE, blksz);
bcopy(db->db.db_data, abuf->b_data, blksz); bcopy(db->db.db_data, abuf->b_data, blksz);
} else { } else {
abuf = db->db_buf; abuf = db->db_buf;
@ -1030,8 +1030,8 @@ dbuf_read_impl(dmu_buf_impl_t *db, zio_t *zio, uint32_t flags)
BP_IS_HOLE(db->db_blkptr)))) { BP_IS_HOLE(db->db_blkptr)))) {
arc_buf_contents_t type = DBUF_GET_BUFC_TYPE(db); arc_buf_contents_t type = DBUF_GET_BUFC_TYPE(db);
dbuf_set_data(db, arc_alloc_buf(db->db_objset->os_spa, dbuf_set_data(db, arc_alloc_buf(db->db_objset->os_spa, db, type,
db->db.db_size, db, type)); db->db.db_size));
bzero(db->db.db_data, db->db.db_size); bzero(db->db.db_data, db->db.db_size);
if (db->db_blkptr != NULL && db->db_level > 0 && if (db->db_blkptr != NULL && db->db_level > 0 &&
@ -1083,6 +1083,70 @@ dbuf_read_impl(dmu_buf_impl_t *db, zio_t *zio, uint32_t flags)
return (SET_ERROR(err)); return (SET_ERROR(err));
} }
/*
* This is our just-in-time copy function. It makes a copy of buffers that
* have been modified in a previous transaction group before we access them in
* the current active group.
*
* This function is used in three places: when we are dirtying a buffer for the
* first time in a txg, when we are freeing a range in a dnode that includes
* this buffer, and when we are accessing a buffer which was received compressed
* and later referenced in a WRITE_BYREF record.
*
* Note that when we are called from dbuf_free_range() we do not put a hold on
* the buffer, we just traverse the active dbuf list for the dnode.
*/
static void
dbuf_fix_old_data(dmu_buf_impl_t *db, uint64_t txg)
{
dbuf_dirty_record_t *dr = db->db_last_dirty;
ASSERT(MUTEX_HELD(&db->db_mtx));
ASSERT(db->db.db_data != NULL);
ASSERT(db->db_level == 0);
ASSERT(db->db.db_object != DMU_META_DNODE_OBJECT);
if (dr == NULL ||
(dr->dt.dl.dr_data !=
((db->db_blkid == DMU_BONUS_BLKID) ? db->db.db_data : db->db_buf)))
return;
/*
* If the last dirty record for this dbuf has not yet synced
* and its referencing the dbuf data, either:
* reset the reference to point to a new copy,
* or (if there a no active holders)
* just null out the current db_data pointer.
*/
ASSERT(dr->dr_txg >= txg - 2);
if (db->db_blkid == DMU_BONUS_BLKID) {
/* Note that the data bufs here are zio_bufs */
dnode_t *dn = DB_DNODE(db);
int bonuslen = DN_SLOTS_TO_BONUSLEN(dn->dn_num_slots);
dr->dt.dl.dr_data = zio_buf_alloc(bonuslen);
arc_space_consume(bonuslen, ARC_SPACE_BONUS);
bcopy(db->db.db_data, dr->dt.dl.dr_data, bonuslen);
} else if (refcount_count(&db->db_holds) > db->db_dirtycnt) {
int size = arc_buf_size(db->db_buf);
arc_buf_contents_t type = DBUF_GET_BUFC_TYPE(db);
spa_t *spa = db->db_objset->os_spa;
enum zio_compress compress_type =
arc_get_compression(db->db_buf);
if (compress_type == ZIO_COMPRESS_OFF) {
dr->dt.dl.dr_data = arc_alloc_buf(spa, db, type, size);
} else {
ASSERT3U(type, ==, ARC_BUFC_DATA);
dr->dt.dl.dr_data = arc_alloc_compressed_buf(spa, db,
size, arc_buf_lsize(db->db_buf), compress_type);
}
bcopy(db->db.db_data, dr->dt.dl.dr_data->b_data, size);
} else {
db->db_buf = NULL;
dbuf_clear_data(db);
}
}
int int
dbuf_read(dmu_buf_impl_t *db, zio_t *zio, uint32_t flags) dbuf_read(dmu_buf_impl_t *db, zio_t *zio, uint32_t flags)
{ {
@ -1111,6 +1175,18 @@ dbuf_read(dmu_buf_impl_t *db, zio_t *zio, uint32_t flags)
mutex_enter(&db->db_mtx); mutex_enter(&db->db_mtx);
if (db->db_state == DB_CACHED) { if (db->db_state == DB_CACHED) {
/*
* If the arc buf is compressed, we need to decompress it to
* read the data. This could happen during the "zfs receive" of
* a stream which is compressed and deduplicated.
*/
if (db->db_buf != NULL &&
arc_get_compression(db->db_buf) != ZIO_COMPRESS_OFF) {
dbuf_fix_old_data(db,
spa_syncing_txg(dmu_objset_spa(db->db_objset)));
err = arc_decompress(db->db_buf);
dbuf_set_data(db, db->db_buf);
}
mutex_exit(&db->db_mtx); mutex_exit(&db->db_mtx);
if (prefetch) if (prefetch)
dmu_zfetch(&dn->dn_zfetch, db->db_blkid, 1, B_TRUE); dmu_zfetch(&dn->dn_zfetch, db->db_blkid, 1, B_TRUE);
@ -1187,7 +1263,7 @@ dbuf_noread(dmu_buf_impl_t *db)
ASSERT(db->db_buf == NULL); ASSERT(db->db_buf == NULL);
ASSERT(db->db.db_data == NULL); ASSERT(db->db.db_data == NULL);
dbuf_set_data(db, arc_alloc_buf(spa, db->db.db_size, db, type)); dbuf_set_data(db, arc_alloc_buf(spa, db, type, db->db.db_size));
db->db_state = DB_FILL; db->db_state = DB_FILL;
} else if (db->db_state == DB_NOFILL) { } else if (db->db_state == DB_NOFILL) {
dbuf_clear_data(db); dbuf_clear_data(db);
@ -1197,62 +1273,6 @@ dbuf_noread(dmu_buf_impl_t *db)
mutex_exit(&db->db_mtx); mutex_exit(&db->db_mtx);
} }
/*
* This is our just-in-time copy function. It makes a copy of
* buffers, that have been modified in a previous transaction
* group, before we modify them in the current active group.
*
* This function is used in two places: when we are dirtying a
* buffer for the first time in a txg, and when we are freeing
* a range in a dnode that includes this buffer.
*
* Note that when we are called from dbuf_free_range() we do
* not put a hold on the buffer, we just traverse the active
* dbuf list for the dnode.
*/
static void
dbuf_fix_old_data(dmu_buf_impl_t *db, uint64_t txg)
{
dbuf_dirty_record_t *dr = db->db_last_dirty;
ASSERT(MUTEX_HELD(&db->db_mtx));
ASSERT(db->db.db_data != NULL);
ASSERT(db->db_level == 0);
ASSERT(db->db.db_object != DMU_META_DNODE_OBJECT);
if (dr == NULL ||
(dr->dt.dl.dr_data !=
((db->db_blkid == DMU_BONUS_BLKID) ? db->db.db_data : db->db_buf)))
return;
/*
* If the last dirty record for this dbuf has not yet synced
* and its referencing the dbuf data, either:
* reset the reference to point to a new copy,
* or (if there a no active holders)
* just null out the current db_data pointer.
*/
ASSERT(dr->dr_txg >= txg - 2);
if (db->db_blkid == DMU_BONUS_BLKID) {
/* Note that the data bufs here are zio_bufs */
dnode_t *dn = DB_DNODE(db);
int bonuslen = DN_SLOTS_TO_BONUSLEN(dn->dn_num_slots);
dr->dt.dl.dr_data = zio_buf_alloc(bonuslen);
arc_space_consume(bonuslen, ARC_SPACE_BONUS);
bcopy(db->db.db_data, dr->dt.dl.dr_data, bonuslen);
} else if (refcount_count(&db->db_holds) > db->db_dirtycnt) {
int size = db->db.db_size;
arc_buf_contents_t type = DBUF_GET_BUFC_TYPE(db);
spa_t *spa = db->db_objset->os_spa;
dr->dt.dl.dr_data = arc_alloc_buf(spa, size, db, type);
bcopy(db->db.db_data, dr->dt.dl.dr_data->b_data, size);
} else {
db->db_buf = NULL;
dbuf_clear_data(db);
}
}
void void
dbuf_unoverride(dbuf_dirty_record_t *dr) dbuf_unoverride(dbuf_dirty_record_t *dr)
{ {
@ -1480,7 +1500,7 @@ dbuf_new_size(dmu_buf_impl_t *db, int size, dmu_tx_t *tx)
dmu_buf_will_dirty(&db->db, tx); dmu_buf_will_dirty(&db->db, tx);
/* create the data buffer for the new block */ /* create the data buffer for the new block */
buf = arc_alloc_buf(dn->dn_objset->os_spa, size, db, type); buf = arc_alloc_buf(dn->dn_objset->os_spa, db, type, size);
/* copy old block data to the new block */ /* copy old block data to the new block */
obuf = db->db_buf; obuf = db->db_buf;
@ -2053,9 +2073,9 @@ dbuf_assign_arcbuf(dmu_buf_impl_t *db, arc_buf_t *buf, dmu_tx_t *tx)
ASSERT(!refcount_is_zero(&db->db_holds)); ASSERT(!refcount_is_zero(&db->db_holds));
ASSERT(db->db_blkid != DMU_BONUS_BLKID); ASSERT(db->db_blkid != DMU_BONUS_BLKID);
ASSERT(db->db_level == 0); ASSERT(db->db_level == 0);
ASSERT(DBUF_GET_BUFC_TYPE(db) == ARC_BUFC_DATA); ASSERT3U(dbuf_is_metadata(db), ==, arc_is_metadata(buf));
ASSERT(buf != NULL); ASSERT(buf != NULL);
ASSERT(arc_buf_size(buf) == db->db.db_size); ASSERT(arc_buf_lsize(buf) == db->db.db_size);
ASSERT(tx->tx_txg != 0); ASSERT(tx->tx_txg != 0);
arc_return_buf(buf, db); arc_return_buf(buf, db);
@ -2698,7 +2718,7 @@ __dbuf_hold_impl(struct dbuf_hold_impl_data *dh)
dbuf_set_data(dh->dh_db, dbuf_set_data(dh->dh_db,
arc_alloc_buf(dh->dh_dn->dn_objset->os_spa, arc_alloc_buf(dh->dh_dn->dn_objset->os_spa,
dh->dh_db->db.db_size, dh->dh_db, dh->dh_type)); dh->dh_db, dh->dh_type, dh->dh_db->db.db_size));
bcopy(dh->dh_dr->dt.dl.dr_data->b_data, bcopy(dh->dh_dr->dt.dl.dr_data->b_data,
dh->dh_db->db.db_data, dh->dh_db->db.db_size); dh->dh_db->db.db_data, dh->dh_db->db.db_size);
} }
@ -3329,10 +3349,19 @@ dbuf_sync_leaf(dbuf_dirty_record_t *dr, dmu_tx_t *tx)
* objects only modified in the syncing context (e.g. * objects only modified in the syncing context (e.g.
* DNONE_DNODE blocks). * DNONE_DNODE blocks).
*/ */
int blksz = arc_buf_size(*datap); int psize = arc_buf_size(*datap);
arc_buf_contents_t type = DBUF_GET_BUFC_TYPE(db); arc_buf_contents_t type = DBUF_GET_BUFC_TYPE(db);
*datap = arc_alloc_buf(os->os_spa, blksz, db, type); enum zio_compress compress_type = arc_get_compression(*datap);
bcopy(db->db.db_data, (*datap)->b_data, blksz);
if (compress_type == ZIO_COMPRESS_OFF) {
*datap = arc_alloc_buf(os->os_spa, db, type, psize);
} else {
int lsize = arc_buf_lsize(*datap);
ASSERT3U(type, ==, ARC_BUFC_DATA);
*datap = arc_alloc_compressed_buf(os->os_spa, db,
psize, lsize, compress_type);
}
bcopy(db->db.db_data, (*datap)->b_data, psize);
} }
db->db_data_pending = dr; db->db_data_pending = dr;
@ -3742,7 +3771,9 @@ dbuf_write(dbuf_dirty_record_t *dr, arc_buf_t *data, dmu_tx_t *tx)
wp_flag = WP_SPILL; wp_flag = WP_SPILL;
wp_flag |= (db->db_state == DB_NOFILL) ? WP_NOFILL : 0; wp_flag |= (db->db_state == DB_NOFILL) ? WP_NOFILL : 0;
dmu_write_policy(os, dn, db->db_level, wp_flag, &zp); dmu_write_policy(os, dn, db->db_level, wp_flag,
(data != NULL && arc_get_compression(data) != ZIO_COMPRESS_OFF) ?
arc_get_compression(data) : ZIO_COMPRESS_INHERIT, &zp);
DB_DNODE_EXIT(db); DB_DNODE_EXIT(db);
/* /*
@ -3762,8 +3793,8 @@ dbuf_write(dbuf_dirty_record_t *dr, arc_buf_t *data, dmu_tx_t *tx)
void *contents = (data != NULL) ? data->b_data : NULL; void *contents = (data != NULL) ? data->b_data : NULL;
dr->dr_zio = zio_write(zio, os->os_spa, txg, dr->dr_zio = zio_write(zio, os->os_spa, txg,
&dr->dr_bp_copy, contents, db->db.db_size, &zp, &dr->dr_bp_copy, contents, db->db.db_size, db->db.db_size,
dbuf_write_override_ready, NULL, NULL, &zp, dbuf_write_override_ready, NULL, NULL,
dbuf_write_override_done, dbuf_write_override_done,
dr, ZIO_PRIORITY_ASYNC_WRITE, ZIO_FLAG_MUSTSUCCEED, &zb); dr, ZIO_PRIORITY_ASYNC_WRITE, ZIO_FLAG_MUSTSUCCEED, &zb);
mutex_enter(&db->db_mtx); mutex_enter(&db->db_mtx);
@ -3774,7 +3805,7 @@ dbuf_write(dbuf_dirty_record_t *dr, arc_buf_t *data, dmu_tx_t *tx)
} else if (db->db_state == DB_NOFILL) { } else if (db->db_state == DB_NOFILL) {
ASSERT(zp.zp_checksum == ZIO_CHECKSUM_OFF); ASSERT(zp.zp_checksum == ZIO_CHECKSUM_OFF);
dr->dr_zio = zio_write(zio, os->os_spa, txg, dr->dr_zio = zio_write(zio, os->os_spa, txg,
&dr->dr_bp_copy, NULL, db->db.db_size, &zp, &dr->dr_bp_copy, NULL, db->db.db_size, db->db.db_size, &zp,
dbuf_write_nofill_ready, NULL, NULL, dbuf_write_nofill_ready, NULL, NULL,
dbuf_write_nofill_done, db, dbuf_write_nofill_done, db,
ZIO_PRIORITY_ASYNC_WRITE, ZIO_PRIORITY_ASYNC_WRITE,

36
module/zfs/dmu.c
View File

@ -1039,7 +1039,7 @@ dmu_xuio_add(xuio_t *xuio, arc_buf_t *abuf, offset_t off, size_t n)
int i = priv->next++; int i = priv->next++;
ASSERT(i < priv->cnt); ASSERT(i < priv->cnt);
ASSERT(off + n <= arc_buf_size(abuf)); ASSERT(off + n <= arc_buf_lsize(abuf));
iov = (iovec_t *)uio->uio_iov + i; iov = (iovec_t *)uio->uio_iov + i;
iov->iov_base = (char *)abuf->b_data + off; iov->iov_base = (char *)abuf->b_data + off;
iov->iov_len = n; iov->iov_len = n;
@ -1327,7 +1327,7 @@ dmu_request_arcbuf(dmu_buf_t *handle, int size)
{ {
dmu_buf_impl_t *db = (dmu_buf_impl_t *)handle; dmu_buf_impl_t *db = (dmu_buf_impl_t *)handle;
return (arc_loan_buf(db->db_objset->os_spa, size)); return (arc_loan_buf(db->db_objset->os_spa, B_FALSE, size));
} }
/* /*
@ -1352,7 +1352,7 @@ dmu_assign_arcbuf(dmu_buf_t *handle, uint64_t offset, arc_buf_t *buf,
dmu_buf_impl_t *dbuf = (dmu_buf_impl_t *)handle; dmu_buf_impl_t *dbuf = (dmu_buf_impl_t *)handle;
dnode_t *dn; dnode_t *dn;
dmu_buf_impl_t *db; dmu_buf_impl_t *db;
uint32_t blksz = (uint32_t)arc_buf_size(buf); uint32_t blksz = (uint32_t)arc_buf_lsize(buf);
uint64_t blkid; uint64_t blkid;
DB_DNODE_ENTER(dbuf); DB_DNODE_ENTER(dbuf);
@ -1365,18 +1365,19 @@ dmu_assign_arcbuf(dmu_buf_t *handle, uint64_t offset, arc_buf_t *buf,
/* /*
* We can only assign if the offset is aligned, the arc buf is the * We can only assign if the offset is aligned, the arc buf is the
* same size as the dbuf, and the dbuf is not metadata. It * same size as the dbuf, and the dbuf is not metadata.
* can't be metadata because the loaned arc buf comes from the
* user-data kmem area.
*/ */
if (offset == db->db.db_offset && blksz == db->db.db_size && if (offset == db->db.db_offset && blksz == db->db.db_size) {
DBUF_GET_BUFC_TYPE(db) == ARC_BUFC_DATA) {
dbuf_assign_arcbuf(db, buf, tx); dbuf_assign_arcbuf(db, buf, tx);
dbuf_rele(db, FTAG); dbuf_rele(db, FTAG);
} else { } else {
objset_t *os; objset_t *os;
uint64_t object; uint64_t object;
/* compressed bufs must always be assignable to their dbuf */
ASSERT3U(arc_get_compression(buf), ==, ZIO_COMPRESS_OFF);
ASSERT(!(buf->b_prop_flags & ARC_BUF_FLAG_COMPRESSED));
DB_DNODE_ENTER(dbuf); DB_DNODE_ENTER(dbuf);
dn = DB_DNODE(dbuf); dn = DB_DNODE(dbuf);
os = dn->dn_objset; os = dn->dn_objset;
@ -1527,7 +1528,7 @@ dmu_sync_late_arrival(zio_t *pio, objset_t *os, dmu_sync_cb_t *done, zgd_t *zgd,
zio_nowait(zio_write(pio, os->os_spa, dmu_tx_get_txg(tx), zio_nowait(zio_write(pio, os->os_spa, dmu_tx_get_txg(tx),
zgd->zgd_bp, zgd->zgd_db->db_data, zgd->zgd_db->db_size, zgd->zgd_bp, zgd->zgd_db->db_data, zgd->zgd_db->db_size,
zp, dmu_sync_late_arrival_ready, NULL, zgd->zgd_db->db_size, zp, dmu_sync_late_arrival_ready, NULL,
NULL, dmu_sync_late_arrival_done, dsa, ZIO_PRIORITY_SYNC_WRITE, NULL, dmu_sync_late_arrival_done, dsa, ZIO_PRIORITY_SYNC_WRITE,
ZIO_FLAG_CANFAIL, zb)); ZIO_FLAG_CANFAIL, zb));
@ -1580,7 +1581,8 @@ dmu_sync(zio_t *pio, uint64_t txg, dmu_sync_cb_t *done, zgd_t *zgd)
DB_DNODE_ENTER(db); DB_DNODE_ENTER(db);
dn = DB_DNODE(db); dn = DB_DNODE(db);
dmu_write_policy(os, dn, db->db_level, WP_DMU_SYNC, &zp); dmu_write_policy(os, dn, db->db_level, WP_DMU_SYNC,
ZIO_COMPRESS_INHERIT, &zp);
DB_DNODE_EXIT(db); DB_DNODE_EXIT(db);
/* /*
@ -1750,7 +1752,8 @@ int zfs_mdcomp_disable = 0;
int zfs_redundant_metadata_most_ditto_level = 2; int zfs_redundant_metadata_most_ditto_level = 2;
void void
dmu_write_policy(objset_t *os, dnode_t *dn, int level, int wp, zio_prop_t *zp) dmu_write_policy(objset_t *os, dnode_t *dn, int level, int wp,
enum zio_compress override_compress, zio_prop_t *zp)
{ {
dmu_object_type_t type = dn ? dn->dn_type : DMU_OT_OBJSET; dmu_object_type_t type = dn ? dn->dn_type : DMU_OT_OBJSET;
boolean_t ismd = (level > 0 || DMU_OT_IS_METADATA(type) || boolean_t ismd = (level > 0 || DMU_OT_IS_METADATA(type) ||
@ -1844,7 +1847,16 @@ dmu_write_policy(objset_t *os, dnode_t *dn, int level, int wp, zio_prop_t *zp)
} }
zp->zp_checksum = checksum; zp->zp_checksum = checksum;
zp->zp_compress = compress;
/*
* If we're writing a pre-compressed buffer, the compression type we use
* must match the data. If it hasn't been compressed yet, then we should
* use the value dictated by the policies above.
*/
zp->zp_compress = override_compress != ZIO_COMPRESS_INHERIT
? override_compress : compress;
ASSERT3U(zp->zp_compress, !=, ZIO_COMPRESS_INHERIT);
zp->zp_type = (wp & WP_SPILL) ? dn->dn_bonustype : type; zp->zp_type = (wp & WP_SPILL) ? dn->dn_bonustype : type;
zp->zp_level = level; zp->zp_level = level;
zp->zp_copies = MIN(copies, spa_max_replication(os->os_spa)); zp->zp_copies = MIN(copies, spa_max_replication(os->os_spa));

11
module/zfs/dmu_objset.c
View File

@ -374,9 +374,8 @@ dmu_objset_open_impl(spa_t *spa, dsl_dataset_t *ds, blkptr_t *bp,
/* Increase the blocksize if we are permitted. */ /* Increase the blocksize if we are permitted. */
if (spa_version(spa) >= SPA_VERSION_USERSPACE && if (spa_version(spa) >= SPA_VERSION_USERSPACE &&
arc_buf_size(os->os_phys_buf) < sizeof (objset_phys_t)) { arc_buf_size(os->os_phys_buf) < sizeof (objset_phys_t)) {
arc_buf_t *buf = arc_alloc_buf(spa, arc_buf_t *buf = arc_alloc_buf(spa, &os->os_phys_buf,
sizeof (objset_phys_t), &os->os_phys_buf, ARC_BUFC_METADATA, sizeof (objset_phys_t));
ARC_BUFC_METADATA);
bzero(buf->b_data, sizeof (objset_phys_t)); bzero(buf->b_data, sizeof (objset_phys_t));
bcopy(os->os_phys_buf->b_data, buf->b_data, bcopy(os->os_phys_buf->b_data, buf->b_data,
arc_buf_size(os->os_phys_buf)); arc_buf_size(os->os_phys_buf));
@ -389,8 +388,8 @@ dmu_objset_open_impl(spa_t *spa, dsl_dataset_t *ds, blkptr_t *bp,
} else { } else {
int size = spa_version(spa) >= SPA_VERSION_USERSPACE ? int size = spa_version(spa) >= SPA_VERSION_USERSPACE ?
sizeof (objset_phys_t) : OBJSET_OLD_PHYS_SIZE; sizeof (objset_phys_t) : OBJSET_OLD_PHYS_SIZE;
os->os_phys_buf = arc_alloc_buf(spa, size, os->os_phys_buf = arc_alloc_buf(spa, &os->os_phys_buf,
&os->os_phys_buf, ARC_BUFC_METADATA); ARC_BUFC_METADATA, size);
os->os_phys = os->os_phys_buf->b_data; os->os_phys = os->os_phys_buf->b_data;
bzero(os->os_phys, size); bzero(os->os_phys, size);
} }
@ -1175,7 +1174,7 @@ dmu_objset_sync(objset_t *os, zio_t *pio, dmu_tx_t *tx)
ZB_ROOT_OBJECT, ZB_ROOT_LEVEL, ZB_ROOT_BLKID); ZB_ROOT_OBJECT, ZB_ROOT_LEVEL, ZB_ROOT_BLKID);
arc_release(os->os_phys_buf, &os->os_phys_buf); arc_release(os->os_phys_buf, &os->os_phys_buf);
dmu_write_policy(os, NULL, 0, 0, &zp); dmu_write_policy(os, NULL, 0, 0, ZIO_COMPRESS_INHERIT, &zp);
zio = arc_write(pio, os->os_spa, tx->tx_txg, zio = arc_write(pio, os->os_spa, tx->tx_txg,
os->os_rootbp, os->os_phys_buf, DMU_OS_IS_L2CACHEABLE(os), os->os_rootbp, os->os_phys_buf, DMU_OS_IS_L2CACHEABLE(os),

224
module/zfs/dmu_send.c
View File

@ -278,8 +278,10 @@ dump_free(dmu_sendarg_t *dsp, uint64_t object, uint64_t offset,
static int static int
dump_write(dmu_sendarg_t *dsp, dmu_object_type_t type, dump_write(dmu_sendarg_t *dsp, dmu_object_type_t type,
uint64_t object, uint64_t offset, int blksz, const blkptr_t *bp, void *data) uint64_t object, uint64_t offset, int lsize, int psize, const blkptr_t *bp,
void *data)
{ {
uint64_t payload_size;
struct drr_write *drrw = &(dsp->dsa_drr->drr_u.drr_write); struct drr_write *drrw = &(dsp->dsa_drr->drr_u.drr_write);
/* /*
@ -290,7 +292,7 @@ dump_write(dmu_sendarg_t *dsp, dmu_object_type_t type,
(object == dsp->dsa_last_data_object && (object == dsp->dsa_last_data_object &&
offset > dsp->dsa_last_data_offset)); offset > dsp->dsa_last_data_offset));
dsp->dsa_last_data_object = object; dsp->dsa_last_data_object = object;
dsp->dsa_last_data_offset = offset + blksz - 1; dsp->dsa_last_data_offset = offset + lsize - 1;
/* /*
* If there is any kind of pending aggregation (currently either * If there is any kind of pending aggregation (currently either
@ -309,8 +311,26 @@ dump_write(dmu_sendarg_t *dsp, dmu_object_type_t type,
drrw->drr_object = object; drrw->drr_object = object;
drrw->drr_type = type; drrw->drr_type = type;
drrw->drr_offset = offset; drrw->drr_offset = offset;
drrw->drr_length = blksz;
drrw->drr_toguid = dsp->dsa_toguid; drrw->drr_toguid = dsp->dsa_toguid;
drrw->drr_logical_size = lsize;
/* only set the compression fields if the buf is compressed */
if (lsize != psize) {
ASSERT(dsp->dsa_featureflags & DMU_BACKUP_FEATURE_COMPRESSED);
ASSERT(!BP_IS_EMBEDDED(bp));
ASSERT(!BP_SHOULD_BYTESWAP(bp));
ASSERT(!DMU_OT_IS_METADATA(BP_GET_TYPE(bp)));
ASSERT3U(BP_GET_COMPRESS(bp), !=, ZIO_COMPRESS_OFF);
ASSERT3S(psize, >, 0);
ASSERT3S(lsize, >=, psize);
drrw->drr_compressiontype = BP_GET_COMPRESS(bp);
drrw->drr_compressed_size = psize;
payload_size = drrw->drr_compressed_size;
} else {
payload_size = drrw->drr_logical_size;
}
if (bp == NULL || BP_IS_EMBEDDED(bp)) { if (bp == NULL || BP_IS_EMBEDDED(bp)) {
/* /*
* There's no pre-computed checksum for partial-block * There's no pre-computed checksum for partial-block
@ -329,7 +349,7 @@ dump_write(dmu_sendarg_t *dsp, dmu_object_type_t type,
drrw->drr_key.ddk_cksum = bp->blk_cksum; drrw->drr_key.ddk_cksum = bp->blk_cksum;
} }
if (dump_record(dsp, data, blksz) != 0) if (dump_record(dsp, data, payload_size) != 0)
return (SET_ERROR(EINTR)); return (SET_ERROR(EINTR));
return (0); return (0);
} }
@ -505,7 +525,7 @@ backup_do_embed(dmu_sendarg_t *dsp, const blkptr_t *bp)
* Compression function must be legacy, or explicitly enabled. * Compression function must be legacy, or explicitly enabled.
*/ */
if ((BP_GET_COMPRESS(bp) >= ZIO_COMPRESS_LEGACY_FUNCTIONS && if ((BP_GET_COMPRESS(bp) >= ZIO_COMPRESS_LEGACY_FUNCTIONS &&
!(dsp->dsa_featureflags & DMU_BACKUP_FEATURE_EMBED_DATA_LZ4))) !(dsp->dsa_featureflags & DMU_BACKUP_FEATURE_LZ4)))
return (B_FALSE); return (B_FALSE);
/* /*
@ -672,20 +692,47 @@ do_dump(dmu_sendarg_t *dsa, struct send_block_record *data)
arc_buf_t *abuf; arc_buf_t *abuf;
int blksz = dblkszsec << SPA_MINBLOCKSHIFT; int blksz = dblkszsec << SPA_MINBLOCKSHIFT;
uint64_t offset; uint64_t offset;
enum zio_flag zioflags = ZIO_FLAG_CANFAIL;
/*
* If we have large blocks stored on disk but the send flags
* don't allow us to send large blocks, we split the data from
* the arc buf into chunks.
*/
boolean_t split_large_blocks =
data->datablkszsec > SPA_OLD_MAXBLOCKSIZE &&
!(dsa->dsa_featureflags & DMU_BACKUP_FEATURE_LARGE_BLOCKS);
/*
* We should only request compressed data from the ARC if all
* the following are true:
* - stream compression was requested
* - we aren't splitting large blocks into smaller chunks
* - the data won't need to be byteswapped before sending
* - this isn't an embedded block
* - this isn't metadata (if receiving on a different endian
* system it can be byteswapped more easily)
*/
boolean_t request_compressed =
(dsa->dsa_featureflags & DMU_BACKUP_FEATURE_COMPRESSED) &&
!split_large_blocks && !BP_SHOULD_BYTESWAP(bp) &&
!BP_IS_EMBEDDED(bp) && !DMU_OT_IS_METADATA(BP_GET_TYPE(bp));
ASSERT0(zb->zb_level); ASSERT0(zb->zb_level);
ASSERT(zb->zb_object > dsa->dsa_resume_object || ASSERT(zb->zb_object > dsa->dsa_resume_object ||
(zb->zb_object == dsa->dsa_resume_object && (zb->zb_object == dsa->dsa_resume_object &&
zb->zb_blkid * blksz >= dsa->dsa_resume_offset)); zb->zb_blkid * blksz >= dsa->dsa_resume_offset));
if (request_compressed)
zioflags |= ZIO_FLAG_RAW;
if (arc_read(NULL, spa, bp, arc_getbuf_func, &abuf, if (arc_read(NULL, spa, bp, arc_getbuf_func, &abuf,
ZIO_PRIORITY_ASYNC_READ, ZIO_FLAG_CANFAIL, ZIO_PRIORITY_ASYNC_READ, zioflags,
&aflags, zb) != 0) { &aflags, zb) != 0) {
if (zfs_send_corrupt_data) { if (zfs_send_corrupt_data) {
uint64_t *ptr; uint64_t *ptr;
/* Send a block filled with 0x"zfs badd bloc" */ /* Send a block filled with 0x"zfs badd bloc" */
abuf = arc_alloc_buf(spa, blksz, &abuf, abuf = arc_alloc_buf(spa, &abuf, ARC_BUFC_DATA,
ARC_BUFC_DATA); blksz);
for (ptr = abuf->b_data; for (ptr = abuf->b_data;
(char *)ptr < (char *)abuf->b_data + blksz; (char *)ptr < (char *)abuf->b_data + blksz;
ptr++) ptr++)
@ -697,21 +744,22 @@ do_dump(dmu_sendarg_t *dsa, struct send_block_record *data)
offset = zb->zb_blkid * blksz; offset = zb->zb_blkid * blksz;
if (!(dsa->dsa_featureflags & if (split_large_blocks) {
DMU_BACKUP_FEATURE_LARGE_BLOCKS) &&
blksz > SPA_OLD_MAXBLOCKSIZE) {
char *buf = abuf->b_data; char *buf = abuf->b_data;
ASSERT3U(arc_get_compression(abuf), ==,
ZIO_COMPRESS_OFF);
while (blksz > 0 && err == 0) { while (blksz > 0 && err == 0) {
int n = MIN(blksz, SPA_OLD_MAXBLOCKSIZE); int n = MIN(blksz, SPA_OLD_MAXBLOCKSIZE);
err = dump_write(dsa, type, zb->zb_object, err = dump_write(dsa, type, zb->zb_object,
offset, n, NULL, buf); offset, n, n, NULL, buf);
offset += n; offset += n;
buf += n; buf += n;
blksz -= n; blksz -= n;
} }
} else { } else {
err = dump_write(dsa, type, zb->zb_object, err = dump_write(dsa, type, zb->zb_object, offset,
offset, blksz, bp, abuf->b_data); blksz, arc_buf_size(abuf), bp,
abuf->b_data);
} }
arc_buf_destroy(abuf, &abuf); arc_buf_destroy(abuf, &abuf);
} }
@ -738,9 +786,9 @@ get_next_record(bqueue_t *bq, struct send_block_record *data)
*/ */
static int static int
dmu_send_impl(void *tag, dsl_pool_t *dp, dsl_dataset_t *to_ds, dmu_send_impl(void *tag, dsl_pool_t *dp, dsl_dataset_t *to_ds,
zfs_bookmark_phys_t *ancestor_zb, zfs_bookmark_phys_t *ancestor_zb, boolean_t is_clone,
boolean_t is_clone, boolean_t embedok, boolean_t large_block_ok, int outfd, boolean_t embedok, boolean_t large_block_ok, boolean_t compressok,
uint64_t resumeobj, uint64_t resumeoff, int outfd, uint64_t resumeobj, uint64_t resumeoff,
vnode_t *vp, offset_t *off) vnode_t *vp, offset_t *off)
{ {
objset_t *os; objset_t *os;
@ -789,8 +837,14 @@ dmu_send_impl(void *tag, dsl_pool_t *dp, dsl_dataset_t *to_ds,
if (embedok && if (embedok &&
spa_feature_is_active(dp->dp_spa, SPA_FEATURE_EMBEDDED_DATA)) { spa_feature_is_active(dp->dp_spa, SPA_FEATURE_EMBEDDED_DATA)) {
featureflags |= DMU_BACKUP_FEATURE_EMBED_DATA; featureflags |= DMU_BACKUP_FEATURE_EMBED_DATA;
if (spa_feature_is_active(dp->dp_spa, SPA_FEATURE_LZ4_COMPRESS)) }
featureflags |= DMU_BACKUP_FEATURE_EMBED_DATA_LZ4; if (compressok) {
featureflags |= DMU_BACKUP_FEATURE_COMPRESSED;
}
if ((featureflags &
(DMU_BACKUP_FEATURE_EMBED_DATA | DMU_BACKUP_FEATURE_COMPRESSED)) !=
0 && spa_feature_is_active(dp->dp_spa, SPA_FEATURE_LZ4_COMPRESS)) {
featureflags |= DMU_BACKUP_FEATURE_LZ4;
} }
if (resumeobj != 0 || resumeoff != 0) { if (resumeobj != 0 || resumeoff != 0) {
@ -935,7 +989,7 @@ out:
int int
dmu_send_obj(const char *pool, uint64_t tosnap, uint64_t fromsnap, dmu_send_obj(const char *pool, uint64_t tosnap, uint64_t fromsnap,
boolean_t embedok, boolean_t large_block_ok, boolean_t embedok, boolean_t large_block_ok, boolean_t compressok,
int outfd, vnode_t *vp, offset_t *off) int outfd, vnode_t *vp, offset_t *off)
{ {
dsl_pool_t *dp; dsl_pool_t *dp;
@ -972,10 +1026,10 @@ dmu_send_obj(const char *pool, uint64_t tosnap, uint64_t fromsnap,
is_clone = (fromds->ds_dir != ds->ds_dir); is_clone = (fromds->ds_dir != ds->ds_dir);
dsl_dataset_rele(fromds, FTAG); dsl_dataset_rele(fromds, FTAG);
err = dmu_send_impl(FTAG, dp, ds, &zb, is_clone, err = dmu_send_impl(FTAG, dp, ds, &zb, is_clone,
embedok, large_block_ok, outfd, 0, 0, vp, off); embedok, large_block_ok, compressok, outfd, 0, 0, vp, off);
} else { } else {
err = dmu_send_impl(FTAG, dp, ds, NULL, B_FALSE, err = dmu_send_impl(FTAG, dp, ds, NULL, B_FALSE,
embedok, large_block_ok, outfd, 0, 0, vp, off); embedok, large_block_ok, compressok, outfd, 0, 0, vp, off);
} }
dsl_dataset_rele(ds, FTAG); dsl_dataset_rele(ds, FTAG);
return (err); return (err);
@ -983,7 +1037,8 @@ dmu_send_obj(const char *pool, uint64_t tosnap, uint64_t fromsnap,
int int
dmu_send(const char *tosnap, const char *fromsnap, boolean_t embedok, dmu_send(const char *tosnap, const char *fromsnap, boolean_t embedok,
boolean_t large_block_ok, int outfd, uint64_t resumeobj, uint64_t resumeoff, boolean_t large_block_ok, boolean_t compressok, int outfd,
uint64_t resumeobj, uint64_t resumeoff,
vnode_t *vp, offset_t *off) vnode_t *vp, offset_t *off)
{ {
dsl_pool_t *dp; dsl_pool_t *dp;
@ -1051,11 +1106,11 @@ dmu_send(const char *tosnap, const char *fromsnap, boolean_t embedok,
return (err); return (err);
} }
err = dmu_send_impl(FTAG, dp, ds, &zb, is_clone, err = dmu_send_impl(FTAG, dp, ds, &zb, is_clone,
embedok, large_block_ok, embedok, large_block_ok, compressok,
outfd, resumeobj, resumeoff, vp, off); outfd, resumeobj, resumeoff, vp, off);
} else { } else {
err = dmu_send_impl(FTAG, dp, ds, NULL, B_FALSE, err = dmu_send_impl(FTAG, dp, ds, NULL, B_FALSE,
embedok, large_block_ok, embedok, large_block_ok, compressok,
outfd, resumeobj, resumeoff, vp, off); outfd, resumeobj, resumeoff, vp, off);
} }
if (owned) if (owned)
@ -1066,33 +1121,46 @@ dmu_send(const char *tosnap, const char *fromsnap, boolean_t embedok,
} }
static int static int
dmu_adjust_send_estimate_for_indirects(dsl_dataset_t *ds, uint64_t size, dmu_adjust_send_estimate_for_indirects(dsl_dataset_t *ds, uint64_t uncompressed,
uint64_t *sizep) uint64_t compressed, boolean_t stream_compressed, uint64_t *sizep)
{ {
int err; int err;
uint64_t size;
/* /*
* Assume that space (both on-disk and in-stream) is dominated by * Assume that space (both on-disk and in-stream) is dominated by
* data. We will adjust for indirect blocks and the copies property, * data. We will adjust for indirect blocks and the copies property,
* but ignore per-object space used (eg, dnodes and DRR_OBJECT records). * but ignore per-object space used (eg, dnodes and DRR_OBJECT records).
*/ */
uint64_t recordsize;
uint64_t record_count;
/* Assume all (uncompressed) blocks are recordsize. */
err = dsl_prop_get_int_ds(ds, zfs_prop_to_name(ZFS_PROP_RECORDSIZE),
&recordsize);
if (err != 0)
return (err);
record_count = uncompressed / recordsize;
/*
* If we're estimating a send size for a compressed stream, use the
* compressed data size to estimate the stream size. Otherwise, use the
* uncompressed data size.
*/
size = stream_compressed ? compressed : uncompressed;
/* /*
* Subtract out approximate space used by indirect blocks. * Subtract out approximate space used by indirect blocks.
* Assume most space is used by data blocks (non-indirect, non-dnode). * Assume most space is used by data blocks (non-indirect, non-dnode).
* Assume all blocks are recordsize. Assume ditto blocks and * Assume no ditto blocks or internal fragmentation.
* internal fragmentation counter out compression.
* *
* Therefore, space used by indirect blocks is sizeof(blkptr_t) per * Therefore, space used by indirect blocks is sizeof(blkptr_t) per
* block, which we observe in practice. * block.
*/ */
uint64_t recordsize; size -= record_count * sizeof (blkptr_t);
err = dsl_prop_get_int_ds(ds, "recordsize", &recordsize);
if (err != 0)
return (err);
size -= size / recordsize * sizeof (blkptr_t);
/* Add in the space for the record associated with each block. */ /* Add in the space for the record associated with each block. */
size += size / recordsize * sizeof (dmu_replay_record_t); size += record_count * sizeof (dmu_replay_record_t);
*sizep = size; *sizep = size;
@ -1100,10 +1168,11 @@ dmu_adjust_send_estimate_for_indirects(dsl_dataset_t *ds, uint64_t size,
} }
int int
dmu_send_estimate(dsl_dataset_t *ds, dsl_dataset_t *fromds, uint64_t *sizep) dmu_send_estimate(dsl_dataset_t *ds, dsl_dataset_t *fromds,
boolean_t stream_compressed, uint64_t *sizep)
{ {
int err; int err;
uint64_t size; uint64_t uncomp, comp;
ASSERT(dsl_pool_config_held(ds->ds_dir->dd_pool)); ASSERT(dsl_pool_config_held(ds->ds_dir->dd_pool));
@ -1122,33 +1191,41 @@ dmu_send_estimate(dsl_dataset_t *ds, dsl_dataset_t *fromds, uint64_t *sizep)
if (fromds != NULL && !dsl_dataset_is_before(ds, fromds, 0)) if (fromds != NULL && !dsl_dataset_is_before(ds, fromds, 0))
return (SET_ERROR(EXDEV)); return (SET_ERROR(EXDEV));
/* Get uncompressed size estimate of changed data. */ /* Get compressed and uncompressed size estimates of changed data. */
if (fromds == NULL) { if (fromds == NULL) {
size = dsl_dataset_phys(ds)->ds_uncompressed_bytes; uncomp = dsl_dataset_phys(ds)->ds_uncompressed_bytes;
comp = dsl_dataset_phys(ds)->ds_compressed_bytes;
} else { } else {
uint64_t used, comp; uint64_t used;
err = dsl_dataset_space_written(fromds, ds, err = dsl_dataset_space_written(fromds, ds,
&used, &comp, &size); &used, &comp, &uncomp);
if (err != 0) if (err != 0)
return (err); return (err);
} }
err = dmu_adjust_send_estimate_for_indirects(ds, size, sizep); err = dmu_adjust_send_estimate_for_indirects(ds, uncomp, comp,
stream_compressed, sizep);
return (err); return (err);
} }
struct calculate_send_arg {
uint64_t uncompressed;
uint64_t compressed;
};
/* /*
* Simple callback used to traverse the blocks of a snapshot and sum their * Simple callback used to traverse the blocks of a snapshot and sum their
* uncompressed size * uncompressed and compressed sizes.
*/ */
/* ARGSUSED */ /* ARGSUSED */
static int static int
dmu_calculate_send_traversal(spa_t *spa, zilog_t *zilog, const blkptr_t *bp, dmu_calculate_send_traversal(spa_t *spa, zilog_t *zilog, const blkptr_t *bp,
const zbookmark_phys_t *zb, const dnode_phys_t *dnp, void *arg) const zbookmark_phys_t *zb, const dnode_phys_t *dnp, void *arg)
{ {
uint64_t *spaceptr = arg; struct calculate_send_arg *space = arg;
if (bp != NULL && !BP_IS_HOLE(bp)) { if (bp != NULL && !BP_IS_HOLE(bp)) {
*spaceptr += BP_GET_UCSIZE(bp); space->uncompressed += BP_GET_UCSIZE(bp);
space->compressed += BP_GET_PSIZE(bp);
} }
return (0); return (0);
} }
@ -1160,10 +1237,10 @@ dmu_calculate_send_traversal(spa_t *spa, zilog_t *zilog, const blkptr_t *bp,
*/ */
int int
dmu_send_estimate_from_txg(dsl_dataset_t *ds, uint64_t from_txg, dmu_send_estimate_from_txg(dsl_dataset_t *ds, uint64_t from_txg,
uint64_t *sizep) boolean_t stream_compressed, uint64_t *sizep)
{ {
int err; int err;
uint64_t size = 0; struct calculate_send_arg size = { 0 };
ASSERT(dsl_pool_config_held(ds->ds_dir->dd_pool)); ASSERT(dsl_pool_config_held(ds->ds_dir->dd_pool));
@ -1181,10 +1258,12 @@ dmu_send_estimate_from_txg(dsl_dataset_t *ds, uint64_t from_txg,
*/ */
err = traverse_dataset(ds, from_txg, TRAVERSE_POST, err = traverse_dataset(ds, from_txg, TRAVERSE_POST,
dmu_calculate_send_traversal, &size); dmu_calculate_send_traversal, &size);
if (err) if (err)
return (err); return (err);
err = dmu_adjust_send_estimate_for_indirects(ds, size, sizep); err = dmu_adjust_send_estimate_for_indirects(ds, size.uncompressed,
size.compressed, stream_compressed, sizep);
return (err); return (err);
} }
@ -1315,14 +1394,14 @@ dmu_recv_begin_check(void *arg, dmu_tx_t *tx)
/* /*
* The receiving code doesn't know how to translate a WRITE_EMBEDDED * The receiving code doesn't know how to translate a WRITE_EMBEDDED
* record to a plan WRITE record, so the pool must have the * record to a plain WRITE record, so the pool must have the
* EMBEDDED_DATA feature enabled if the stream has WRITE_EMBEDDED * EMBEDDED_DATA feature enabled if the stream has WRITE_EMBEDDED
* records. Same with WRITE_EMBEDDED records that use LZ4 compression. * records. Same with WRITE_EMBEDDED records that use LZ4 compression.
*/ */
if ((featureflags & DMU_BACKUP_FEATURE_EMBED_DATA) && if ((featureflags & DMU_BACKUP_FEATURE_EMBED_DATA) &&
!spa_feature_is_enabled(dp->dp_spa, SPA_FEATURE_EMBEDDED_DATA)) !spa_feature_is_enabled(dp->dp_spa, SPA_FEATURE_EMBEDDED_DATA))
return (SET_ERROR(ENOTSUP)); return (SET_ERROR(ENOTSUP));
if ((featureflags & DMU_BACKUP_FEATURE_EMBED_DATA_LZ4) && if ((featureflags & DMU_BACKUP_FEATURE_LZ4) &&
!spa_feature_is_enabled(dp->dp_spa, SPA_FEATURE_LZ4_COMPRESS)) !spa_feature_is_enabled(dp->dp_spa, SPA_FEATURE_LZ4_COMPRESS))
return (SET_ERROR(ENOTSUP)); return (SET_ERROR(ENOTSUP));
@ -1501,11 +1580,21 @@ dmu_recv_begin_sync(void *arg, dmu_tx_t *tx)
8, 1, &zero, tx)); 8, 1, &zero, tx));
VERIFY0(zap_add(mos, dsobj, DS_FIELD_RESUME_BYTES, VERIFY0(zap_add(mos, dsobj, DS_FIELD_RESUME_BYTES,
8, 1, &zero, tx)); 8, 1, &zero, tx));
if (DMU_GET_FEATUREFLAGS(drrb->drr_versioninfo) &
DMU_BACKUP_FEATURE_LARGE_BLOCKS) {
VERIFY0(zap_add(mos, dsobj, DS_FIELD_RESUME_LARGEBLOCK,
8, 1, &one, tx));
}
if (DMU_GET_FEATUREFLAGS(drrb->drr_versioninfo) & if (DMU_GET_FEATUREFLAGS(drrb->drr_versioninfo) &
DMU_BACKUP_FEATURE_EMBED_DATA) { DMU_BACKUP_FEATURE_EMBED_DATA) {
VERIFY0(zap_add(mos, dsobj, DS_FIELD_RESUME_EMBEDOK, VERIFY0(zap_add(mos, dsobj, DS_FIELD_RESUME_EMBEDOK,
8, 1, &one, tx)); 8, 1, &one, tx));
} }
if (DMU_GET_FEATUREFLAGS(drrb->drr_versioninfo) &
DMU_BACKUP_FEATURE_COMPRESSED) {
VERIFY0(zap_add(mos, dsobj, DS_FIELD_RESUME_COMPRESSOK,
8, 1, &one, tx));
}
} }
dmu_buf_will_dirty(newds->ds_dbuf, tx); dmu_buf_will_dirty(newds->ds_dbuf, tx);
@ -1563,7 +1652,7 @@ dmu_recv_resume_begin_check(void *arg, dmu_tx_t *tx)
if ((featureflags & DMU_BACKUP_FEATURE_EMBED_DATA) && if ((featureflags & DMU_BACKUP_FEATURE_EMBED_DATA) &&
!spa_feature_is_enabled(dp->dp_spa, SPA_FEATURE_EMBEDDED_DATA)) !spa_feature_is_enabled(dp->dp_spa, SPA_FEATURE_EMBEDDED_DATA))
return (SET_ERROR(ENOTSUP)); return (SET_ERROR(ENOTSUP));
if ((featureflags & DMU_BACKUP_FEATURE_EMBED_DATA_LZ4) && if ((featureflags & DMU_BACKUP_FEATURE_LZ4) &&
!spa_feature_is_enabled(dp->dp_spa, SPA_FEATURE_LZ4_COMPRESS)) !spa_feature_is_enabled(dp->dp_spa, SPA_FEATURE_LZ4_COMPRESS))
return (SET_ERROR(ENOTSUP)); return (SET_ERROR(ENOTSUP));
@ -1888,10 +1977,11 @@ byteswap_record(dmu_replay_record_t *drr)
DO64(drr_write.drr_object); DO64(drr_write.drr_object);
DO32(drr_write.drr_type); DO32(drr_write.drr_type);
DO64(drr_write.drr_offset); DO64(drr_write.drr_offset);
DO64(drr_write.drr_length); DO64(drr_write.drr_logical_size);
DO64(drr_write.drr_toguid); DO64(drr_write.drr_toguid);
ZIO_CHECKSUM_BSWAP(&drr->drr_u.drr_write.drr_key.ddk_cksum); ZIO_CHECKSUM_BSWAP(&drr->drr_u.drr_write.drr_key.ddk_cksum);
DO64(drr_write.drr_key.ddk_prop); DO64(drr_write.drr_key.ddk_prop);
DO64(drr_write.drr_compressed_size);
break; break;
case DRR_WRITE_BYREF: case DRR_WRITE_BYREF:
DO64(drr_write_byref.drr_object); DO64(drr_write_byref.drr_object);
@ -2133,7 +2223,7 @@ receive_write(struct receive_writer_arg *rwa, struct drr_write *drrw,
dmu_buf_t *bonus; dmu_buf_t *bonus;
int err; int err;
if (drrw->drr_offset + drrw->drr_length < drrw->drr_offset || if (drrw->drr_offset + drrw->drr_logical_size < drrw->drr_offset ||
!DMU_OT_IS_VALID(drrw->drr_type)) !DMU_OT_IS_VALID(drrw->drr_type))
return (SET_ERROR(EINVAL)); return (SET_ERROR(EINVAL));
@ -2155,7 +2245,7 @@ receive_write(struct receive_writer_arg *rwa, struct drr_write *drrw,
tx = dmu_tx_create(rwa->os); tx = dmu_tx_create(rwa->os);
dmu_tx_hold_write(tx, drrw->drr_object, dmu_tx_hold_write(tx, drrw->drr_object,
drrw->drr_offset, drrw->drr_length); drrw->drr_offset, drrw->drr_logical_size);
err = dmu_tx_assign(tx, TXG_WAIT); err = dmu_tx_assign(tx, TXG_WAIT);
if (err != 0) { if (err != 0) {
dmu_tx_abort(tx); dmu_tx_abort(tx);
@ -2165,9 +2255,10 @@ receive_write(struct receive_writer_arg *rwa, struct drr_write *drrw,
dmu_object_byteswap_t byteswap = dmu_object_byteswap_t byteswap =
DMU_OT_BYTESWAP(drrw->drr_type); DMU_OT_BYTESWAP(drrw->drr_type);
dmu_ot_byteswap[byteswap].ob_func(abuf->b_data, dmu_ot_byteswap[byteswap].ob_func(abuf->b_data,
drrw->drr_length); DRR_WRITE_PAYLOAD_SIZE(drrw));
} }
/* use the bonus buf to look up the dnode in dmu_assign_arcbuf */
if (dmu_bonus_hold(rwa->os, drrw->drr_object, FTAG, &bonus) != 0) if (dmu_bonus_hold(rwa->os, drrw->drr_object, FTAG, &bonus) != 0)
return (SET_ERROR(EINVAL)); return (SET_ERROR(EINVAL));
dmu_assign_arcbuf(bonus, drrw->drr_offset, abuf, tx); dmu_assign_arcbuf(bonus, drrw->drr_offset, abuf, tx);
@ -2583,18 +2674,31 @@ receive_read_record(struct receive_arg *ra)
case DRR_WRITE: case DRR_WRITE:
{ {
struct drr_write *drrw = &ra->rrd->header.drr_u.drr_write; struct drr_write *drrw = &ra->rrd->header.drr_u.drr_write;
arc_buf_t *abuf = arc_loan_buf(dmu_objset_spa(ra->os), arc_buf_t *abuf;
drrw->drr_length); boolean_t is_meta = DMU_OT_IS_METADATA(drrw->drr_type);
if (DRR_WRITE_COMPRESSED(drrw)) {
ASSERT3U(drrw->drr_compressed_size, >, 0);
ASSERT3U(drrw->drr_logical_size, >=,
drrw->drr_compressed_size);
ASSERT(!is_meta);
abuf = arc_loan_compressed_buf(
dmu_objset_spa(ra->os),
drrw->drr_compressed_size, drrw->drr_logical_size,
drrw->drr_compressiontype);
} else {
abuf = arc_loan_buf(dmu_objset_spa(ra->os),
is_meta, drrw->drr_logical_size);
}
err = receive_read_payload_and_next_header(ra, err = receive_read_payload_and_next_header(ra,
drrw->drr_length, abuf->b_data); DRR_WRITE_PAYLOAD_SIZE(drrw), abuf->b_data);
if (err != 0) { if (err != 0) {
dmu_return_arcbuf(abuf); dmu_return_arcbuf(abuf);
return (err); return (err);
} }
ra->rrd->write_buf = abuf; ra->rrd->write_buf = abuf;
receive_read_prefetch(ra, drrw->drr_object, drrw->drr_offset, receive_read_prefetch(ra, drrw->drr_object, drrw->drr_offset,
drrw->drr_length); drrw->drr_logical_size);
return (err); return (err);
} }
case DRR_WRITE_BYREF: case DRR_WRITE_BYREF:

8
module/zfs/dsl_dataset.c
View File

@ -1759,10 +1759,18 @@ get_receive_resume_stats(dsl_dataset_t *ds, nvlist_t *nv)
DS_FIELD_RESUME_TONAME, 1, sizeof (buf), buf) == 0) { DS_FIELD_RESUME_TONAME, 1, sizeof (buf), buf) == 0) {
fnvlist_add_string(token_nv, "toname", buf); fnvlist_add_string(token_nv, "toname", buf);
} }
if (zap_contains(dp->dp_meta_objset, ds->ds_object,
DS_FIELD_RESUME_LARGEBLOCK) == 0) {
fnvlist_add_boolean(token_nv, "largeblockok");
}
if (zap_contains(dp->dp_meta_objset, ds->ds_object, if (zap_contains(dp->dp_meta_objset, ds->ds_object,
DS_FIELD_RESUME_EMBEDOK) == 0) { DS_FIELD_RESUME_EMBEDOK) == 0) {
fnvlist_add_boolean(token_nv, "embedok"); fnvlist_add_boolean(token_nv, "embedok");
} }
if (zap_contains(dp->dp_meta_objset, ds->ds_object,
DS_FIELD_RESUME_COMPRESSOK) == 0) {
fnvlist_add_boolean(token_nv, "compressok");
}
packed = fnvlist_pack(token_nv, &packed_size); packed = fnvlist_pack(token_nv, &packed_size);
fnvlist_free(token_nv); fnvlist_free(token_nv);
compressed = kmem_alloc(packed_size, KM_SLEEP); compressed = kmem_alloc(packed_size, KM_SLEEP);

35
module/zfs/zfs_ioctl.c
View File

@ -4461,6 +4461,7 @@ zfs_ioc_send(zfs_cmd_t *zc)
boolean_t estimate = (zc->zc_guid != 0); boolean_t estimate = (zc->zc_guid != 0);
boolean_t embedok = (zc->zc_flags & 0x1); boolean_t embedok = (zc->zc_flags & 0x1);
boolean_t large_block_ok = (zc->zc_flags & 0x2); boolean_t large_block_ok = (zc->zc_flags & 0x2);
boolean_t compressok = (zc->zc_flags & 0x4);
if (zc->zc_obj != 0) { if (zc->zc_obj != 0) {
dsl_pool_t *dp; dsl_pool_t *dp;
@ -4508,7 +4509,7 @@ zfs_ioc_send(zfs_cmd_t *zc)
} }
} }
error = dmu_send_estimate(tosnap, fromsnap, error = dmu_send_estimate(tosnap, fromsnap, compressok,
&zc->zc_objset_type); &zc->zc_objset_type);
if (fromsnap != NULL) if (fromsnap != NULL)
@ -4522,7 +4523,7 @@ zfs_ioc_send(zfs_cmd_t *zc)
off = fp->f_offset; off = fp->f_offset;
error = dmu_send_obj(zc->zc_name, zc->zc_sendobj, error = dmu_send_obj(zc->zc_name, zc->zc_sendobj,
zc->zc_fromobj, embedok, large_block_ok, zc->zc_fromobj, embedok, large_block_ok, compressok,
zc->zc_cookie, fp->f_vnode, &off); zc->zc_cookie, fp->f_vnode, &off);
if (VOP_SEEK(fp->f_vnode, fp->f_offset, &off, NULL) == 0) if (VOP_SEEK(fp->f_vnode, fp->f_offset, &off, NULL) == 0)
@ -5415,6 +5416,8 @@ zfs_ioc_space_snaps(const char *lastsnap, nvlist_t *innvl, nvlist_t *outnvl)
* indicates that blocks > 128KB are permitted * indicates that blocks > 128KB are permitted
* (optional) "embedok" -> (value ignored) * (optional) "embedok" -> (value ignored)
* presence indicates DRR_WRITE_EMBEDDED records are permitted * presence indicates DRR_WRITE_EMBEDDED records are permitted
* (optional) "compressok" -> (value ignored)
* presence indicates compressed DRR_WRITE records are permitted
* (optional) "resume_object" and "resume_offset" -> (uint64) * (optional) "resume_object" and "resume_offset" -> (uint64)
* if present, resume send stream from specified object and offset. * if present, resume send stream from specified object and offset.
* } * }
@ -5432,6 +5435,7 @@ zfs_ioc_send_new(const char *snapname, nvlist_t *innvl, nvlist_t *outnvl)
file_t *fp; file_t *fp;
boolean_t largeblockok; boolean_t largeblockok;
boolean_t embedok; boolean_t embedok;
boolean_t compressok;
uint64_t resumeobj = 0; uint64_t resumeobj = 0;
uint64_t resumeoff = 0; uint64_t resumeoff = 0;
@ -5443,6 +5447,7 @@ zfs_ioc_send_new(const char *snapname, nvlist_t *innvl, nvlist_t *outnvl)
largeblockok = nvlist_exists(innvl, "largeblockok"); largeblockok = nvlist_exists(innvl, "largeblockok");
embedok = nvlist_exists(innvl, "embedok"); embedok = nvlist_exists(innvl, "embedok");
compressok = nvlist_exists(innvl, "compressok");
(void) nvlist_lookup_uint64(innvl, "resume_object", &resumeobj); (void) nvlist_lookup_uint64(innvl, "resume_object", &resumeobj);
(void) nvlist_lookup_uint64(innvl, "resume_offset", &resumeoff); (void) nvlist_lookup_uint64(innvl, "resume_offset", &resumeoff);
@ -5451,8 +5456,8 @@ zfs_ioc_send_new(const char *snapname, nvlist_t *innvl, nvlist_t *outnvl)
return (SET_ERROR(EBADF)); return (SET_ERROR(EBADF));
off = fp->f_offset; off = fp->f_offset;
error = dmu_send(snapname, fromname, embedok, largeblockok, fd, error = dmu_send(snapname, fromname, embedok, largeblockok, compressok,
resumeobj, resumeoff, fp->f_vnode, &off); fd, resumeobj, resumeoff, fp->f_vnode, &off);
if (VOP_SEEK(fp->f_vnode, fp->f_offset, &off, NULL) == 0) if (VOP_SEEK(fp->f_vnode, fp->f_offset, &off, NULL) == 0)
fp->f_offset = off; fp->f_offset = off;
@ -5468,6 +5473,12 @@ zfs_ioc_send_new(const char *snapname, nvlist_t *innvl, nvlist_t *outnvl)
* innvl: { * innvl: {
* (optional) "from" -> full snap or bookmark name to send an incremental * (optional) "from" -> full snap or bookmark name to send an incremental
* from * from
* (optional) "largeblockok" -> (value ignored)
* indicates that blocks > 128KB are permitted
* (optional) "embedok" -> (value ignored)
* presence indicates DRR_WRITE_EMBEDDED records are permitted
* (optional) "compressok" -> (value ignored)
* presence indicates compressed DRR_WRITE records are permitted
* } * }
* *
* outnvl: { * outnvl: {
@ -5481,6 +5492,11 @@ zfs_ioc_send_space(const char *snapname, nvlist_t *innvl, nvlist_t *outnvl)
dsl_dataset_t *tosnap; dsl_dataset_t *tosnap;
int error; int error;
char *fromname; char *fromname;
/* LINTED E_FUNC_SET_NOT_USED */
boolean_t largeblockok;
/* LINTED E_FUNC_SET_NOT_USED */
boolean_t embedok;
boolean_t compressok;
uint64_t space; uint64_t space;
error = dsl_pool_hold(snapname, FTAG, &dp); error = dsl_pool_hold(snapname, FTAG, &dp);
@ -5493,6 +5509,10 @@ zfs_ioc_send_space(const char *snapname, nvlist_t *innvl, nvlist_t *outnvl)
return (error); return (error);
} }
largeblockok = nvlist_exists(innvl, "largeblockok");
embedok = nvlist_exists(innvl, "embedok");
compressok = nvlist_exists(innvl, "compressok");
error = nvlist_lookup_string(innvl, "from", &fromname); error = nvlist_lookup_string(innvl, "from", &fromname);
if (error == 0) { if (error == 0) {
if (strchr(fromname, '@') != NULL) { if (strchr(fromname, '@') != NULL) {
@ -5505,7 +5525,8 @@ zfs_ioc_send_space(const char *snapname, nvlist_t *innvl, nvlist_t *outnvl)
error = dsl_dataset_hold(dp, fromname, FTAG, &fromsnap); error = dsl_dataset_hold(dp, fromname, FTAG, &fromsnap);
if (error != 0) if (error != 0)
goto out; goto out;
error = dmu_send_estimate(tosnap, fromsnap, &space); error = dmu_send_estimate(tosnap, fromsnap, compressok,
&space);
dsl_dataset_rele(fromsnap, FTAG); dsl_dataset_rele(fromsnap, FTAG);
} else if (strchr(fromname, '#') != NULL) { } else if (strchr(fromname, '#') != NULL) {
/* /*
@ -5520,7 +5541,7 @@ zfs_ioc_send_space(const char *snapname, nvlist_t *innvl, nvlist_t *outnvl)
if (error != 0) if (error != 0)
goto out; goto out;
error = dmu_send_estimate_from_txg(tosnap, error = dmu_send_estimate_from_txg(tosnap,
frombm.zbm_creation_txg, &space); frombm.zbm_creation_txg, compressok, &space);
} else { } else {
/* /*
* from is not properly formatted as a snapshot or * from is not properly formatted as a snapshot or
@ -5531,7 +5552,7 @@ zfs_ioc_send_space(const char *snapname, nvlist_t *innvl, nvlist_t *outnvl)
} }
} else { } else {
// If estimating the size of a full send, use dmu_send_estimate // If estimating the size of a full send, use dmu_send_estimate
error = dmu_send_estimate(tosnap, NULL, &space); error = dmu_send_estimate(tosnap, NULL, compressok, &space);
} }
fnvlist_add_uint64(outnvl, "space", space); fnvlist_add_uint64(outnvl, "space", space);

84
module/zfs/zio.c
View File

@ -529,21 +529,24 @@ zio_inherit_child_errors(zio_t *zio, enum zio_child c)
*/ */
static zio_t * static zio_t *
zio_create(zio_t *pio, spa_t *spa, uint64_t txg, const blkptr_t *bp, zio_create(zio_t *pio, spa_t *spa, uint64_t txg, const blkptr_t *bp,
void *data, uint64_t size, zio_done_func_t *done, void *private, void *data, uint64_t lsize, uint64_t psize, zio_done_func_t *done,
zio_type_t type, zio_priority_t priority, enum zio_flag flags, void *private, zio_type_t type, zio_priority_t priority,
vdev_t *vd, uint64_t offset, const zbookmark_phys_t *zb, enum zio_flag flags, vdev_t *vd, uint64_t offset,
enum zio_stage stage, enum zio_stage pipeline) const zbookmark_phys_t *zb, enum zio_stage stage,
enum zio_stage pipeline)
{ {
zio_t *zio; zio_t *zio;
ASSERT3U(size, <=, SPA_MAXBLOCKSIZE); ASSERT3U(psize, <=, SPA_MAXBLOCKSIZE);
ASSERT(P2PHASE(size, SPA_MINBLOCKSIZE) == 0); ASSERT(P2PHASE(psize, SPA_MINBLOCKSIZE) == 0);
ASSERT(P2PHASE(offset, SPA_MINBLOCKSIZE) == 0); ASSERT(P2PHASE(offset, SPA_MINBLOCKSIZE) == 0);
ASSERT(!vd || spa_config_held(spa, SCL_STATE_ALL, RW_READER)); ASSERT(!vd || spa_config_held(spa, SCL_STATE_ALL, RW_READER));
ASSERT(!bp || !(flags & ZIO_FLAG_CONFIG_WRITER)); ASSERT(!bp || !(flags & ZIO_FLAG_CONFIG_WRITER));
ASSERT(vd || stage == ZIO_STAGE_OPEN); ASSERT(vd || stage == ZIO_STAGE_OPEN);
IMPLY(lsize != psize, (flags & ZIO_FLAG_RAW) != 0);
zio = kmem_cache_alloc(zio_cache, KM_SLEEP); zio = kmem_cache_alloc(zio_cache, KM_SLEEP);
bzero(zio, sizeof (zio_t)); bzero(zio, sizeof (zio_t));
@ -586,7 +589,8 @@ zio_create(zio_t *pio, spa_t *spa, uint64_t txg, const blkptr_t *bp,
zio->io_vd = vd; zio->io_vd = vd;
zio->io_offset = offset; zio->io_offset = offset;
zio->io_orig_data = zio->io_data = data; zio->io_orig_data = zio->io_data = data;
zio->io_orig_size = zio->io_size = size; zio->io_orig_size = zio->io_size = psize;
zio->io_lsize = lsize;
zio->io_orig_flags = zio->io_flags = flags; zio->io_orig_flags = zio->io_flags = flags;
zio->io_orig_stage = zio->io_stage = stage; zio->io_orig_stage = zio->io_stage = stage;
zio->io_orig_pipeline = zio->io_pipeline = pipeline; zio->io_orig_pipeline = zio->io_pipeline = pipeline;
@ -626,7 +630,7 @@ zio_null(zio_t *pio, spa_t *spa, vdev_t *vd, zio_done_func_t *done,
{ {
zio_t *zio; zio_t *zio;
zio = zio_create(pio, spa, 0, NULL, NULL, 0, done, private, zio = zio_create(pio, spa, 0, NULL, NULL, 0, 0, done, private,
ZIO_TYPE_NULL, ZIO_PRIORITY_NOW, flags, vd, 0, NULL, ZIO_TYPE_NULL, ZIO_PRIORITY_NOW, flags, vd, 0, NULL,
ZIO_STAGE_OPEN, ZIO_INTERLOCK_PIPELINE); ZIO_STAGE_OPEN, ZIO_INTERLOCK_PIPELINE);
@ -735,7 +739,7 @@ zio_read(zio_t *pio, spa_t *spa, const blkptr_t *bp,
zfs_blkptr_verify(spa, bp); zfs_blkptr_verify(spa, bp);
zio = zio_create(pio, spa, BP_PHYSICAL_BIRTH(bp), bp, zio = zio_create(pio, spa, BP_PHYSICAL_BIRTH(bp), bp,
data, size, done, private, data, size, size, done, private,
ZIO_TYPE_READ, priority, flags, NULL, 0, zb, ZIO_TYPE_READ, priority, flags, NULL, 0, zb,
ZIO_STAGE_OPEN, (flags & ZIO_FLAG_DDT_CHILD) ? ZIO_STAGE_OPEN, (flags & ZIO_FLAG_DDT_CHILD) ?
ZIO_DDT_CHILD_READ_PIPELINE : ZIO_READ_PIPELINE); ZIO_DDT_CHILD_READ_PIPELINE : ZIO_READ_PIPELINE);
@ -745,7 +749,7 @@ zio_read(zio_t *pio, spa_t *spa, const blkptr_t *bp,
zio_t * zio_t *
zio_write(zio_t *pio, spa_t *spa, uint64_t txg, blkptr_t *bp, zio_write(zio_t *pio, spa_t *spa, uint64_t txg, blkptr_t *bp,
void *data, uint64_t size, const zio_prop_t *zp, void *data, uint64_t lsize, uint64_t psize, const zio_prop_t *zp,
zio_done_func_t *ready, zio_done_func_t *children_ready, zio_done_func_t *ready, zio_done_func_t *children_ready,
zio_done_func_t *physdone, zio_done_func_t *done, zio_done_func_t *physdone, zio_done_func_t *done,
void *private, zio_priority_t priority, enum zio_flag flags, void *private, zio_priority_t priority, enum zio_flag flags,
@ -762,7 +766,7 @@ zio_write(zio_t *pio, spa_t *spa, uint64_t txg, blkptr_t *bp,
zp->zp_copies > 0 && zp->zp_copies > 0 &&
zp->zp_copies <= spa_max_replication(spa)); zp->zp_copies <= spa_max_replication(spa));
zio = zio_create(pio, spa, txg, bp, data, size, done, private, zio = zio_create(pio, spa, txg, bp, data, lsize, psize, done, private,
ZIO_TYPE_WRITE, priority, flags, NULL, 0, zb, ZIO_TYPE_WRITE, priority, flags, NULL, 0, zb,
ZIO_STAGE_OPEN, (flags & ZIO_FLAG_DDT_CHILD) ? ZIO_STAGE_OPEN, (flags & ZIO_FLAG_DDT_CHILD) ?
ZIO_DDT_CHILD_WRITE_PIPELINE : ZIO_WRITE_PIPELINE); ZIO_DDT_CHILD_WRITE_PIPELINE : ZIO_WRITE_PIPELINE);
@ -792,7 +796,7 @@ zio_rewrite(zio_t *pio, spa_t *spa, uint64_t txg, blkptr_t *bp, void *data,
{ {
zio_t *zio; zio_t *zio;
zio = zio_create(pio, spa, txg, bp, data, size, done, private, zio = zio_create(pio, spa, txg, bp, data, size, size, done, private,
ZIO_TYPE_WRITE, priority, flags, NULL, 0, zb, ZIO_TYPE_WRITE, priority, flags, NULL, 0, zb,
ZIO_STAGE_OPEN, ZIO_REWRITE_PIPELINE); ZIO_STAGE_OPEN, ZIO_REWRITE_PIPELINE);
@ -872,8 +876,8 @@ zio_free_sync(zio_t *pio, spa_t *spa, uint64_t txg, const blkptr_t *bp,
stage |= ZIO_STAGE_ISSUE_ASYNC; stage |= ZIO_STAGE_ISSUE_ASYNC;
zio = zio_create(pio, spa, txg, bp, NULL, BP_GET_PSIZE(bp), zio = zio_create(pio, spa, txg, bp, NULL, BP_GET_PSIZE(bp),
NULL, NULL, ZIO_TYPE_FREE, ZIO_PRIORITY_NOW, flags, BP_GET_PSIZE(bp), NULL, NULL, ZIO_TYPE_FREE, ZIO_PRIORITY_NOW,
NULL, 0, NULL, ZIO_STAGE_OPEN, stage); flags, NULL, 0, NULL, ZIO_STAGE_OPEN, stage);
return (zio); return (zio);
} }
@ -906,8 +910,8 @@ zio_claim(zio_t *pio, spa_t *spa, uint64_t txg, const blkptr_t *bp,
ASSERT(!BP_GET_DEDUP(bp) || !spa_writeable(spa)); /* zdb(1M) */ ASSERT(!BP_GET_DEDUP(bp) || !spa_writeable(spa)); /* zdb(1M) */
zio = zio_create(pio, spa, txg, bp, NULL, BP_GET_PSIZE(bp), zio = zio_create(pio, spa, txg, bp, NULL, BP_GET_PSIZE(bp),
done, private, ZIO_TYPE_CLAIM, ZIO_PRIORITY_NOW, flags, BP_GET_PSIZE(bp), done, private, ZIO_TYPE_CLAIM, ZIO_PRIORITY_NOW,
NULL, 0, NULL, ZIO_STAGE_OPEN, ZIO_CLAIM_PIPELINE); flags, NULL, 0, NULL, ZIO_STAGE_OPEN, ZIO_CLAIM_PIPELINE);
return (zio); return (zio);
} }
@ -920,7 +924,7 @@ zio_ioctl(zio_t *pio, spa_t *spa, vdev_t *vd, int cmd,
int c; int c;
if (vd->vdev_children == 0) { if (vd->vdev_children == 0) {
zio = zio_create(pio, spa, 0, NULL, NULL, 0, done, private, zio = zio_create(pio, spa, 0, NULL, NULL, 0, 0, done, private,
ZIO_TYPE_IOCTL, ZIO_PRIORITY_NOW, flags, vd, 0, NULL, ZIO_TYPE_IOCTL, ZIO_PRIORITY_NOW, flags, vd, 0, NULL,
ZIO_STAGE_OPEN, ZIO_IOCTL_PIPELINE); ZIO_STAGE_OPEN, ZIO_IOCTL_PIPELINE);
@ -948,9 +952,9 @@ zio_read_phys(zio_t *pio, vdev_t *vd, uint64_t offset, uint64_t size,
offset >= vd->vdev_psize - VDEV_LABEL_END_SIZE); offset >= vd->vdev_psize - VDEV_LABEL_END_SIZE);
ASSERT3U(offset + size, <=, vd->vdev_psize); ASSERT3U(offset + size, <=, vd->vdev_psize);
zio = zio_create(pio, vd->vdev_spa, 0, NULL, data, size, done, private, zio = zio_create(pio, vd->vdev_spa, 0, NULL, data, size, size, done,
ZIO_TYPE_READ, priority, flags | ZIO_FLAG_PHYSICAL, vd, offset, private, ZIO_TYPE_READ, priority, flags | ZIO_FLAG_PHYSICAL, vd,
NULL, ZIO_STAGE_OPEN, ZIO_READ_PHYS_PIPELINE); offset, NULL, ZIO_STAGE_OPEN, ZIO_READ_PHYS_PIPELINE);
zio->io_prop.zp_checksum = checksum; zio->io_prop.zp_checksum = checksum;
@ -969,9 +973,9 @@ zio_write_phys(zio_t *pio, vdev_t *vd, uint64_t offset, uint64_t size,
offset >= vd->vdev_psize - VDEV_LABEL_END_SIZE); offset >= vd->vdev_psize - VDEV_LABEL_END_SIZE);
ASSERT3U(offset + size, <=, vd->vdev_psize); ASSERT3U(offset + size, <=, vd->vdev_psize);
zio = zio_create(pio, vd->vdev_spa, 0, NULL, data, size, done, private, zio = zio_create(pio, vd->vdev_spa, 0, NULL, data, size, size, done,
ZIO_TYPE_WRITE, priority, flags | ZIO_FLAG_PHYSICAL, vd, offset, private, ZIO_TYPE_WRITE, priority, flags | ZIO_FLAG_PHYSICAL, vd,
NULL, ZIO_STAGE_OPEN, ZIO_WRITE_PHYS_PIPELINE); offset, NULL, ZIO_STAGE_OPEN, ZIO_WRITE_PHYS_PIPELINE);
zio->io_prop.zp_checksum = checksum; zio->io_prop.zp_checksum = checksum;
@ -1027,7 +1031,7 @@ zio_vdev_child_io(zio_t *pio, blkptr_t *bp, vdev_t *vd, uint64_t offset,
if (flags & ZIO_FLAG_IO_REPAIR) if (flags & ZIO_FLAG_IO_REPAIR)
flags &= ~ZIO_FLAG_SPECULATIVE; flags &= ~ZIO_FLAG_SPECULATIVE;
zio = zio_create(pio, pio->io_spa, pio->io_txg, bp, data, size, zio = zio_create(pio, pio->io_spa, pio->io_txg, bp, data, size, size,
done, private, type, priority, flags, vd, offset, &pio->io_bookmark, done, private, type, priority, flags, vd, offset, &pio->io_bookmark,
ZIO_STAGE_VDEV_IO_START >> 1, pipeline); ZIO_STAGE_VDEV_IO_START >> 1, pipeline);
@ -1048,7 +1052,7 @@ zio_vdev_delegated_io(vdev_t *vd, uint64_t offset, void *data, uint64_t size,
ASSERT(vd->vdev_ops->vdev_op_leaf); ASSERT(vd->vdev_ops->vdev_op_leaf);
zio = zio_create(NULL, vd->vdev_spa, 0, NULL, zio = zio_create(NULL, vd->vdev_spa, 0, NULL,
data, size, done, private, type, priority, data, size, size, done, private, type, priority,
flags | ZIO_FLAG_CANFAIL | ZIO_FLAG_DONT_RETRY | ZIO_FLAG_DELEGATED, flags | ZIO_FLAG_CANFAIL | ZIO_FLAG_DONT_RETRY | ZIO_FLAG_DELEGATED,
vd, offset, NULL, vd, offset, NULL,
ZIO_STAGE_VDEV_IO_START >> 1, ZIO_VDEV_CHILD_PIPELINE); ZIO_STAGE_VDEV_IO_START >> 1, ZIO_VDEV_CHILD_PIPELINE);
@ -1077,8 +1081,11 @@ zio_shrink(zio_t *zio, uint64_t size)
* Note, BP_IS_RAIDZ() assumes no compression. * Note, BP_IS_RAIDZ() assumes no compression.
*/ */
ASSERT(BP_GET_COMPRESS(zio->io_bp) == ZIO_COMPRESS_OFF); ASSERT(BP_GET_COMPRESS(zio->io_bp) == ZIO_COMPRESS_OFF);
if (!BP_IS_RAIDZ(zio->io_bp)) if (!BP_IS_RAIDZ(zio->io_bp)) {
zio->io_orig_size = zio->io_size = size; /* we are not doing a raw write */
ASSERT3U(zio->io_size, ==, zio->io_lsize);
zio->io_orig_size = zio->io_size = zio->io_lsize = size;
}
} }
/* /*
@ -1128,10 +1135,12 @@ zio_write_bp_init(zio_t *zio)
zio_prop_t *zp = &zio->io_prop; zio_prop_t *zp = &zio->io_prop;
enum zio_compress compress = zp->zp_compress; enum zio_compress compress = zp->zp_compress;
blkptr_t *bp = zio->io_bp; blkptr_t *bp = zio->io_bp;
uint64_t lsize = zio->io_size; uint64_t lsize = zio->io_lsize;
uint64_t psize = lsize; uint64_t psize = zio->io_size;
int pass = 1; int pass = 1;
EQUIV(lsize != psize, (zio->io_flags & ZIO_FLAG_RAW) != 0);
/* /*
* If our children haven't all reached the ready stage, * If our children haven't all reached the ready stage,
* wait for them and then repeat this pipeline stage. * wait for them and then repeat this pipeline stage.
@ -1217,7 +1226,8 @@ zio_write_bp_init(zio_t *zio)
spa_max_replication(spa)) == BP_GET_NDVAS(bp)); spa_max_replication(spa)) == BP_GET_NDVAS(bp));
} }
if (compress != ZIO_COMPRESS_OFF) { /* If it's a compressed write that is not raw, compress the buffer. */
if (compress != ZIO_COMPRESS_OFF && psize == lsize) {
void *cbuf = zio_buf_alloc(lsize); void *cbuf = zio_buf_alloc(lsize);
psize = zio_compress_data(compress, zio->io_data, cbuf, lsize); psize = zio_compress_data(compress, zio->io_data, cbuf, lsize);
if (psize == 0 || psize == lsize) { if (psize == 0 || psize == lsize) {
@ -1263,6 +1273,9 @@ zio_write_bp_init(zio_t *zio)
psize, lsize, NULL); psize, lsize, NULL);
} }
} }
} else {
ASSERT3U(psize, !=, 0);
} }
/* /*
@ -2163,8 +2176,8 @@ zio_write_gang_block(zio_t *pio)
zp.zp_nopwrite = B_FALSE; zp.zp_nopwrite = B_FALSE;
zio_nowait(zio_write(zio, spa, txg, &gbh->zg_blkptr[g], zio_nowait(zio_write(zio, spa, txg, &gbh->zg_blkptr[g],
(char *)pio->io_data + (pio->io_size - resid), lsize, &zp, (char *)pio->io_data + (pio->io_size - resid), lsize,
zio_write_gang_member_ready, NULL, NULL, NULL, lsize, &zp, zio_write_gang_member_ready, NULL, NULL, NULL,
&gn->gn_child[g], pio->io_priority, &gn->gn_child[g], pio->io_priority,
ZIO_GANG_CHILD_FLAGS(pio), &pio->io_bookmark)); ZIO_GANG_CHILD_FLAGS(pio), &pio->io_bookmark));
} }
@ -2351,6 +2364,8 @@ zio_ddt_collision(zio_t *zio, ddt_t *ddt, ddt_entry_t *dde)
spa_t *spa = zio->io_spa; spa_t *spa = zio->io_spa;
int p; int p;
ASSERT0(zio->io_flags & ZIO_FLAG_RAW);
/* /*
* Note: we compare the original data, not the transformed data, * Note: we compare the original data, not the transformed data,
* because when zio->io_bp is an override bp, we will not have * because when zio->io_bp is an override bp, we will not have
@ -2496,6 +2511,7 @@ zio_ddt_write(zio_t *zio)
ASSERT(BP_GET_DEDUP(bp)); ASSERT(BP_GET_DEDUP(bp));
ASSERT(BP_GET_CHECKSUM(bp) == zp->zp_checksum); ASSERT(BP_GET_CHECKSUM(bp) == zp->zp_checksum);
ASSERT(BP_IS_HOLE(bp) || zio->io_bp_override); ASSERT(BP_IS_HOLE(bp) || zio->io_bp_override);
ASSERT0(zio->io_flags & ZIO_FLAG_RAW);
ddt_enter(ddt); ddt_enter(ddt);
dde = ddt_lookup(ddt, bp, B_TRUE); dde = ddt_lookup(ddt, bp, B_TRUE);
@ -2548,7 +2564,7 @@ zio_ddt_write(zio_t *zio)
} }
dio = zio_write(zio, spa, txg, bp, zio->io_orig_data, dio = zio_write(zio, spa, txg, bp, zio->io_orig_data,
zio->io_orig_size, &czp, NULL, NULL, zio->io_orig_size, zio->io_orig_size, &czp, NULL, NULL,
NULL, zio_ddt_ditto_write_done, dde, zio->io_priority, NULL, zio_ddt_ditto_write_done, dde, zio->io_priority,
ZIO_DDT_CHILD_FLAGS(zio), &zio->io_bookmark); ZIO_DDT_CHILD_FLAGS(zio), &zio->io_bookmark);
@ -2570,7 +2586,7 @@ zio_ddt_write(zio_t *zio)
ddt_phys_addref(ddp); ddt_phys_addref(ddp);
} else { } else {
cio = zio_write(zio, spa, txg, bp, zio->io_orig_data, cio = zio_write(zio, spa, txg, bp, zio->io_orig_data,
zio->io_orig_size, zp, zio->io_orig_size, zio->io_orig_size, zp,
zio_ddt_child_write_ready, NULL, NULL, zio_ddt_child_write_ready, NULL, NULL,
zio_ddt_child_write_done, dde, zio->io_priority, zio_ddt_child_write_done, dde, zio->io_priority,
ZIO_DDT_CHILD_FLAGS(zio), &zio->io_bookmark); ZIO_DDT_CHILD_FLAGS(zio), &zio->io_bookmark);