Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Add module parameter to block 0 byte writes 

Some hardware has issues when issues a write of 0 bytes
Add a new module paramter, zio_suppress_zero_writes
That when enabled (default) will just complete these I/Os
without sending them to the hardware.

Signed-off-by: Allan Jude <allan@klarasystems.com>
This commit is contained in:
Allan Jude 2023-05-25 16:35:04 +00:00 committed by Geoff Amey
parent f882884358
commit 2284c4d200
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
module/os/linux/zfs/vdev_disk.c
View File

@ -46,6 +46,7 @@ typedef struct vdev_disk {
krwlock_t vd_lock; krwlock_t vd_lock;
} vdev_disk_t; } vdev_disk_t;
int zio_suppress_zero_writes = B_TRUE;
/* /*
* Unique identifier for the exclusive vdev holder. * Unique identifier for the exclusive vdev holder.
*/ */
@ -793,6 +794,19 @@ vdev_disk_io_start(zio_t *zio)
return; return;
} }
if (zio->io_size == 0) {
cmn_err(CE_WARN, "KLARA: vdev_disk_io_start() "
"io_type=%d io_size=%d!", zio->io_type, zio->io_size);
if (zio->io_type == ZIO_TYPE_WRITE &&
zio_suppress_zero_writes == B_TRUE) {
cmn_err(CE_WARN, "KLARA: vdev_disk_io_start() "
"cancelling write of 0 bytes");
zio->io_error = 0;
zio_interrupt(zio);
return;
}
}
rw_enter(&vd->vd_lock, RW_READER); rw_enter(&vd->vd_lock, RW_READER);
/* /*
@ -1010,3 +1024,6 @@ param_set_max_auto_ashift(const char *buf, zfs_kernel_param_t *kp)
return (0); return (0);
} }
ZFS_MODULE_PARAM(zfs_zio, zio_, suppress_zero_writes, INT, ZMOD_RW,
"Do not send zero byte writes to hardware");