Use the correct spelling of 'jailed' in tests

FreeBSD has jails, not zones.

Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes #9899
This commit is contained in:
Ryan Moeller 2020-01-31 11:52:29 -05:00 committed by GitHub
parent a3bddd49f8
commit 12430796d6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
14 changed files with 72 additions and 19 deletions

View File

@ -57,7 +57,7 @@ set -A args "" "create" "create -s" "create -V" "create -s -V" \
"set compressratio=" "set mounted=" "set origin=" "set quota=" \ "set compressratio=" "set mounted=" "set origin=" "set quota=" \
"set reservation=" "set volsize=" " set volblocksize=" "set recordsize=" \ "set reservation=" "set volsize=" " set volblocksize=" "set recordsize=" \
"set mountpoint=" "set devices=" "set exec=" "set setuid=" "set readonly=" \ "set mountpoint=" "set devices=" "set exec=" "set setuid=" "set readonly=" \
"set zoned=" "set snapdir=" "set aclmode=" "set aclinherit=" \ "set snapdir=" "set aclmode=" "set aclinherit=" \
"set quota=blah" "set reservation=blah" "set atime=blah" "set checksum=blah" \ "set quota=blah" "set reservation=blah" "set atime=blah" "set checksum=blah" \
"set compression=blah" \ "set compression=blah" \
"upgrade blah" "mount blah" "mount -o" \ "upgrade blah" "mount blah" "mount -o" \
@ -65,6 +65,11 @@ set -A args "" "create" "create -s" "create -V" "create -s -V" \
"share" "unshare" "send" "send -i" "receive" "receive -d" "receive -vnF" \ "share" "unshare" "send" "send -i" "receive" "receive -d" "receive -vnF" \
"recv" "recv -d" "recv -vnF" "allow" "unallow" \ "recv" "recv -d" "recv -vnF" "allow" "unallow" \
"blah blah" "-%" "--" "--?" "-*" "-=" "blah blah" "-%" "--" "--?" "-*" "-="
if is_freebsd; then
args+=("set jailed=")
else
args+=("set zoned=")
fi
log_assert "Badly-formed zfs sub-command should return an error." log_assert "Badly-formed zfs sub-command should return an error."

View File

@ -61,9 +61,13 @@ set -A FS_ONLY_PROP "quota=536870912" \
"devices=off" \ "devices=off" \
"exec=off" \ "exec=off" \
"setuid=off" \ "setuid=off" \
"zoned=on" \
"snapdir=visible" \ "snapdir=visible" \
"canmount=off" \ "canmount=off" \
"version=1" "version=1"
if is_freebsd; then
FS_ONLY_PROP+=("jailed=on")
else
FS_ONLY_PROP+=("zoned=on")
fi
set -A VOL_ONLY_PROP "volblocksize=16384" "volsize=536870912" set -A VOL_ONLY_PROP "volblocksize=16384" "volsize=536870912"

View File

@ -74,7 +74,6 @@ set -A args "ab" "-?" "-cV" "-Vc" "-c -V" "c" "V" "--c" "-e" "-s" \
"-o readonly=ON" "-o reADOnly=off" "-o rdonly=OFF" "-o rdonly=aaa" \ "-o readonly=ON" "-o reADOnly=off" "-o rdonly=OFF" "-o rdonly=aaa" \
"-o readonly=ON -V $VOLSIZE" "-o reADOnly=off -V $VOLSIZE" \ "-o readonly=ON -V $VOLSIZE" "-o reADOnly=off -V $VOLSIZE" \
"-o rdonly=OFF -V $VOLSIZE" "-o rdonly=aaa -V $VOLSIZE" \ "-o rdonly=OFF -V $VOLSIZE" "-o rdonly=aaa -V $VOLSIZE" \
"-o zoned=ON" "-o ZoNed=off" "-o zoned=aaa" \
"-o snapdIR=hidden" "-o snapdir=VISible" "-o snapdir=aaa" \ "-o snapdIR=hidden" "-o snapdir=VISible" "-o snapdir=aaa" \
"-o aclmode=DIScard" "-o aclmODE=groupmask" "-o aclmode=aaa" \ "-o aclmode=DIScard" "-o aclmODE=groupmask" "-o aclmode=aaa" \
"-o aclinherit=deny" "-o aclinHerit=secure" "-o aclinherit=aaa" \ "-o aclinherit=deny" "-o aclinHerit=secure" "-o aclinherit=aaa" \
@ -88,6 +87,11 @@ set -A args "ab" "-?" "-cV" "-Vc" "-c -V" "c" "V" "--c" "-e" "-s" \
"-o compressratio=1.00x" "-o compressratio=1.00x -V $VOLSIZE" \ "-o compressratio=1.00x" "-o compressratio=1.00x -V $VOLSIZE" \
"-o version=0" "-o version=1.234" "-o version=10K" "-o version=-1" \ "-o version=0" "-o version=1.234" "-o version=10K" "-o version=-1" \
"-o version=aaa" "-o version=999" "-o version=aaa" "-o version=999"
if is_freebsd; then
args+=("-o jailed=ON" "-o JaiLed=off" "-o jailed=aaa")
else
args+=("-o zoned=ON" "-o ZoNed=off" "-o zoned=aaa")
fi
log_assert "'zfs create' should return an error with badly-formed parameters." log_assert "'zfs create' should return an error with badly-formed parameters."

View File

@ -56,8 +56,13 @@ log_onexit cleanup
set -A badopts "r" "R" "-R" "-rR" "-a" "-" "-?" "-1" "-2" "-v" "-n" set -A badopts "r" "R" "-R" "-rR" "-a" "-" "-?" "-1" "-2" "-v" "-n"
set -A props "recordsize" "mountpoint" "sharenfs" "checksum" "compression" \ set -A props "recordsize" "mountpoint" "sharenfs" "checksum" "compression" \
"atime" "devices" "exec" "setuid" "readonly" "zoned" "snapdir" "aclmode" \ "atime" "devices" "exec" "setuid" "readonly" "snapdir" "aclmode" \
"aclinherit" "xattr" "copies" "aclinherit" "xattr" "copies"
if is_freebsd; then
props+=("jailed")
else
props+=("zoned")
fi
set -A illprops "recordsiz" "mountpont" "sharen" "compres" "atme" "blah" set -A illprops "recordsiz" "mountpont" "sharen" "compres" "atme" "blah"
log_must zfs snapshot $TESTPOOL/$TESTFS@$TESTSNAP log_must zfs snapshot $TESTPOOL/$TESTFS@$TESTSNAP

View File

@ -55,7 +55,12 @@ typeset ro_props="type used creation referenced refer compressratio \
mounted origin" mounted origin"
typeset snap_ro_props="volsize recordsize recsize quota reservation reserv mountpoint \ typeset snap_ro_props="volsize recordsize recsize quota reservation reserv mountpoint \
sharenfs checksum compression compress atime devices exec readonly rdonly \ sharenfs checksum compression compress atime devices exec readonly rdonly \
setuid zoned" setuid"
if is_freebsd; then
snap_ro_props+=" jailed"
else
snap_ro_props+=" zoned"
fi
zfs upgrade -v > /dev/null 2>&1 zfs upgrade -v > /dev/null 2>&1
if [[ $? -eq 0 ]]; then if [[ $? -eq 0 ]]; then

View File

@ -45,7 +45,12 @@
verify_runnable "both" verify_runnable "both"
set -A props "" "mountpoint" "checksum" "compression" "atime" "readonly" \ set -A props "" "mountpoint" "checksum" "compression" "atime" "readonly" \
"setuid" "zoned" "canmount" "setuid" "canmount"
if is_freebsd; then
props+=("jailed")
else
props+=("zoned")
fi
set -A values "" "mountpoint" "checksum" "compression" "atime" "readonly" \ set -A values "" "mountpoint" "checksum" "compression" "atime" "readonly" \
"setuid" "zoned" "0" "-?" "-on" "--on" "*" "?" "Legacy" "NONE" "oN" \ "setuid" "zoned" "0" "-?" "-on" "--on" "*" "?" "Legacy" "NONE" "oN" \

View File

@ -47,8 +47,13 @@ log_assert "'zfs set' fails with invalid arguments"
set -A editable_props "quota" "reservation" "reserv" "volsize" "recordsize" "recsize" \ set -A editable_props "quota" "reservation" "reserv" "volsize" "recordsize" "recsize" \
"mountpoint" "checksum" "compression" "compress" "atime" \ "mountpoint" "checksum" "compression" "compress" "atime" \
"devices" "exec" "setuid" "readonly" "zoned" "snapdir" "aclmode" \ "devices" "exec" "setuid" "readonly" "snapdir" "aclmode" \
"aclinherit" "canmount" "xattr" "copies" "version" "aclinherit" "canmount" "xattr" "copies" "version"
if is_freebsd; then
editable_props+=("jailed")
else
editable_props+=("zoned")
fi
for ds in $TESTPOOL $TESTPOOL/$TESTFS $TESTPOOL/$TESTVOL \ for ds in $TESTPOOL $TESTPOOL/$TESTFS $TESTPOOL/$TESTVOL \
$TESTPOOL/$TESTFS@$TESTSNAP; do $TESTPOOL/$TESTFS@$TESTSNAP; do

View File

@ -74,7 +74,12 @@ typeset ro_props="type used available avail creation referenced refer compressra
mounted origin" mounted origin"
typeset snap_ro_props="volsize recordsize recsize quota reservation reserv mountpoint \ typeset snap_ro_props="volsize recordsize recsize quota reservation reserv mountpoint \
sharenfs checksum compression compress atime devices exec readonly rdonly \ sharenfs checksum compression compress atime devices exec readonly rdonly \
setuid zoned" setuid"
if is_freebsd; then
snap_ro_props+=" jailed"
else
snap_ro_props+=" zoned"
fi
zfs upgrade -v > /dev/null 2>&1 zfs upgrade -v > /dev/null 2>&1
if [[ $? -eq 0 ]]; then if [[ $? -eq 0 ]]; then

View File

@ -70,8 +70,12 @@ set -A RW_FS_PROP "quota=536870912" \
"snapdir=visible" \ "snapdir=visible" \
"acltype=posixacl" \ "acltype=posixacl" \
"aclinherit=discard" \ "aclinherit=discard" \
"canmount=off" \ "canmount=off"
"zoned=on" if is_freebsd; then
RW_FS_PROP+=("jailed=on")
else
RW_FS_PROP+=("zoned=on")
fi
typeset -i i=0 typeset -i i=0
while (( $i < ${#RW_FS_PROP[*]} )); do while (( $i < ${#RW_FS_PROP[*]} )); do

View File

@ -63,7 +63,6 @@ set -A args "QuOta=none" "quota=non" "quota=abcd" "quota=0" "quota=" \
"deviCes=on" "devices=OFF" "devices=aaa" \ "deviCes=on" "devices=OFF" "devices=aaa" \
"exec=ON" "EXec=off" "exec=aaa" \ "exec=ON" "EXec=off" "exec=aaa" \
"readonly=ON" "reADOnly=off" "rdonly=OFF" "rdonly=aaa" \ "readonly=ON" "reADOnly=off" "rdonly=OFF" "rdonly=aaa" \
"zoned=ON" "ZoNed=off" "zoned=aaa" \
"snapdIR=hidden" "snapdir=VISible" "snapdir=aaa" \ "snapdIR=hidden" "snapdir=VISible" "snapdir=aaa" \
"acltype=DIScard" "acltYPE=groupmask" "acltype=aaa" \ "acltype=DIScard" "acltYPE=groupmask" "acltype=aaa" \
"aclinherit=deny" "aclinHerit=secure" "aclinherit=aaa" \ "aclinherit=deny" "aclinHerit=secure" "aclinherit=aaa" \
@ -72,6 +71,11 @@ set -A args "QuOta=none" "quota=non" "quota=abcd" "quota=0" "quota=" \
"referenced=10K" "compressratio=1.00x" \ "referenced=10K" "compressratio=1.00x" \
"version=0" "version=1.234" "version=10K" "version=-1" \ "version=0" "version=1.234" "version=10K" "version=-1" \
"version=aaa" "version=999" "version=aaa" "version=999"
if is_freebsd; then
args+=("jailed=ON" "JaiLed=off" "jailed=aaa")
else
args+=("zoned=ON" "ZoNed=off" "zoned=aaa")
fi
log_assert "'zpool create -O' should return an error with badly formed parameters." log_assert "'zpool create -O' should return an error with badly formed parameters."

View File

@ -93,7 +93,7 @@ elif is_freebsd; then
# Permission Filesystem Volume # Permission Filesystem Volume
# #
# Removed for FreeBSD # Removed for FreeBSD
# - zoned - zones are not supported # - zoned - spelled "jailed"
# - sharenfs - sharing requires superuser privileges # - sharenfs - sharing requires superuser privileges
# - share - sharing requires superuser privileges # - share - sharing requires superuser privileges
# - xattr - Not supported on FreeBSD # - xattr - Not supported on FreeBSD
@ -125,6 +125,7 @@ set -A perms create true false \
clone true true \ clone true true \
rename true true \ rename true true \
promote true true \ promote true true \
jailed true false \
receive true false \ receive true false \
destroy true true destroy true true

View File

@ -66,7 +66,7 @@ set -A perms create snapshot mount send allow quota reservation \
recordsize mountpoint checksum compression canmount atime \ recordsize mountpoint checksum compression canmount atime \
devices exec volsize setuid readonly snapdir userprop \ devices exec volsize setuid readonly snapdir userprop \
aclmode aclinherit rollback clone rename promote dnodesize \ aclmode aclinherit rollback clone rename promote dnodesize \
zoned receive destroy jailed receive destroy
else else
set -A perms create snapshot mount send allow quota reservation \ set -A perms create snapshot mount send allow quota reservation \
recordsize mountpoint checksum compression canmount atime \ recordsize mountpoint checksum compression canmount atime \

View File

@ -105,7 +105,7 @@ props=(
exec on exec off exec on exec off
setuid on setuid off setuid on setuid off
readonly on readonly off readonly on readonly off
zoned on zoned off jailed on jailed off
snapdir hidden snapdir visible snapdir hidden snapdir visible
aclinherit discard aclinherit noallow aclinherit discard aclinherit noallow
aclinherit secure aclinherit passthrough aclinherit secure aclinherit passthrough

View File

@ -217,15 +217,21 @@ function cmp_ds_prop
{ {
typeset dtst1=$1 typeset dtst1=$1
typeset dtst2=$2 typeset dtst2=$2
typeset -a props=("type" "origin" "volblocksize" "acltype" "dnodesize" \
for item in "type" "origin" "volblocksize" "acltype" "dnodesize" \
"atime" "canmount" "checksum" "compression" "copies" "devices" \ "atime" "canmount" "checksum" "compression" "copies" "devices" \
"exec" "quota" "readonly" "recordsize" "reservation" "setuid" \ "exec" "quota" "readonly" "recordsize" "reservation" "setuid" \
"snapdir" "version" "volsize" "xattr" "zoned" "mountpoint"; "snapdir" "version" "volsize" "xattr" "mountpoint");
if is_freebsd; then
props+=("jailed")
else
props+=("zoned")
fi
for prop in $props;
do do
zfs get -H -o property,value,source $item $dtst1 >> \ zfs get -H -o property,value,source $prop $dtst1 >> \
$BACKDIR/dtst1 $BACKDIR/dtst1
zfs get -H -o property,value,source $item $dtst2 >> \ zfs get -H -o property,value,source $prop $dtst2 >> \
$BACKDIR/dtst2 $BACKDIR/dtst2
done done