Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

libzfs: Prevent overridding of error code 

zfs_send_cb_impl fails to report error for some flags.

Use second error variable for send_conclusion_record.

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
Closes #13558
This commit is contained in:
ixhamza 2022-06-16 02:26:12 +05:00 committed by GitHub
parent dd8671459f
commit 10891b37fa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/libzfs/libzfs_sendrecv.c
View File

@ -2366,9 +2366,9 @@ zfs_send_cb_impl(zfs_handle_t *zhp, const char *fromsnap, const char *tosnap,
* there was some error, because it might not be totally * there was some error, because it might not be totally
* failed. * failed.
*/ */
err = send_conclusion_record(outfd, NULL); int err2 = send_conclusion_record(outfd, NULL);
if (err != 0) if (err2 != 0)
return (zfs_standard_error(zhp->zfs_hdl, err, errbuf)); return (zfs_standard_error(zhp->zfs_hdl, err2, errbuf));
} }
return (err || sdd.err); return (err || sdd.err);