From 0e2bb1a3ee395887a8e75f0273aca2b328a3f3cd Mon Sep 17 00:00:00 2001 From: Alexander Motin Date: Fri, 17 Sep 2021 13:17:18 -0400 Subject: [PATCH] Really zero the zero page While switching abd_zero_buf allocation KPI I've missed the fact that kmem_zalloc() zeroed the allocation, while kmem_cache_alloc() does not. Add explicit bzero() after it. I don't think it should have caused real problems, but leaking one memory page content all over the pool is not good. Reviewed-by: Brian Behlendorf Reviewed-by: Brian Atkinson Reviewed-by: Ryan Moeller Signed-off-by: Alexander Motin Closes #12569 --- module/os/freebsd/zfs/abd_os.c | 1 + 1 file changed, 1 insertion(+) diff --git a/module/os/freebsd/zfs/abd_os.c b/module/os/freebsd/zfs/abd_os.c index 95a83542fa..41ceed1dc5 100644 --- a/module/os/freebsd/zfs/abd_os.c +++ b/module/os/freebsd/zfs/abd_os.c @@ -250,6 +250,7 @@ abd_alloc_zero_scatter(void) n = abd_chunkcnt_for_bytes(SPA_MAXBLOCKSIZE); abd_zero_buf = kmem_cache_alloc(abd_chunk_cache, KM_PUSHPAGE); + bzero(abd_zero_buf, PAGE_SIZE); abd_zero_scatter = abd_alloc_struct(SPA_MAXBLOCKSIZE); abd_zero_scatter->abd_flags |= ABD_FLAG_OWNER | ABD_FLAG_ZEROS;