From 710c21f2e9a4cfd8210d558dd34525fdaf7e501f Mon Sep 17 00:00:00 2001 From: Brian Behlendorf Date: Fri, 24 Jul 2009 10:25:01 -0700 Subject: [PATCH] Use LOSETUP variable for all calls to /sbin/losetup --- scripts/common.sh | 6 ++++-- scripts/zpool-config/lo-raid0.sh | 6 +++--- scripts/zpool-config/lo-raid10.sh | 8 ++++---- scripts/zpool-config/lo-raidz.sh | 6 +++--- scripts/zpool-config/lo-raidz2.sh | 6 +++--- 5 files changed, 17 insertions(+), 15 deletions(-) diff --git a/scripts/common.sh b/scripts/common.sh index 6e19bbf83d..f7944fe31e 100755 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -18,6 +18,8 @@ DUMP_LOG= ERROR= MODULES=() +LOSETUP=/sbin/losetup + die() { echo -e "${PROG}: $1" >&2 exit 1 @@ -146,9 +148,9 @@ unload_modules() { unused_loop_device() { for DEVICE in `ls -1 /dev/loop*`; do - losetup $DEVICE &>/dev/null + ${LOSETUP} ${DEVICE} &>/dev/null if [ $? -ne 0 ]; then - echo $DEVICE + echo ${DEVICE} return fi done diff --git a/scripts/zpool-config/lo-raid0.sh b/scripts/zpool-config/lo-raid0.sh index 36b3c4d62f..b514499bc7 100644 --- a/scripts/zpool-config/lo-raid0.sh +++ b/scripts/zpool-config/lo-raid0.sh @@ -16,7 +16,7 @@ zpool_create() { rm -f ${FILE} || exit 1 dd if=/dev/zero of=${FILE} bs=1024k count=256 &>/dev/null || die "Error $? creating ${FILE}" - losetup ${DEVICE} ${FILE} || + ${LOSETUP} ${DEVICE} ${FILE} || die "Error $? creating ${FILE} -> ${DEVICE} loopback" DEVICES="${DEVICES} ${DEVICE}" done @@ -30,9 +30,9 @@ zpool_destroy() { ${CMDDIR}/zpool/zpool destroy ${ZPOOL_NAME} for FILE in ${FILES}; do - DEVICE=`/sbin/losetup -a | grep ${FILE} | head -n1|cut -f1 -d:` + DEVICE=`${LOSETUP} -a | grep ${FILE} | head -n1|cut -f1 -d:` msg "Removing ${FILE} using loopback device ${DEVICE}" - losetup -d ${DEVICE} || + ${LOSETUP} -d ${DEVICE} || die "Error $? destroying ${FILE} -> ${DEVICE} loopback" rm -f ${FILE} || exit 1 done diff --git a/scripts/zpool-config/lo-raid10.sh b/scripts/zpool-config/lo-raid10.sh index 64602aec38..2376669495 100644 --- a/scripts/zpool-config/lo-raid10.sh +++ b/scripts/zpool-config/lo-raid10.sh @@ -18,7 +18,7 @@ zpool_create() { rm -f ${FILE} || exit 1 dd if=/dev/zero of=${FILE} bs=1024k count=256 &>/dev/null || die "Error $? creating ${FILE}" - losetup ${DEVICE} ${FILE} || + ${LOSETUP} ${DEVICE} ${FILE} || die "Error $? creating ${FILE} -> ${DEVICE} loopback" DEVICES_M1="${DEVICES_M1} ${DEVICE}" done @@ -29,7 +29,7 @@ zpool_create() { rm -f ${FILE} || exit 1 dd if=/dev/zero of=${FILE} bs=1024k count=256 &>/dev/null || die "Error $? creating ${FILE}" - losetup ${DEVICE} ${FILE} || + ${LOSETUP} ${DEVICE} ${FILE} || die "Error $? creating ${FILE} -> ${DEVICE} loopback" DEVICES_M2="${DEVICES_M2} ${DEVICE}" done @@ -45,9 +45,9 @@ zpool_destroy() { ${CMDDIR}/zpool/zpool destroy ${ZPOOL_NAME} for FILE in ${FILES}; do - DEVICE=`/sbin/losetup -a | grep ${FILE} | head -n1|cut -f1 -d:` + DEVICE=`${LOSETUP} -a | grep ${FILE} | head -n1|cut -f1 -d:` msg "Removing ${FILE} using loopback device ${DEVICE}" - losetup -d ${DEVICE} || + ${LOSETUP} -d ${DEVICE} || die "Error $? destroying ${FILE} -> ${DEVICE} loopback" rm -f ${FILE} || exit 1 done diff --git a/scripts/zpool-config/lo-raidz.sh b/scripts/zpool-config/lo-raidz.sh index 616c364bed..9ec90e2bcc 100644 --- a/scripts/zpool-config/lo-raidz.sh +++ b/scripts/zpool-config/lo-raidz.sh @@ -16,7 +16,7 @@ zpool_create() { rm -f ${FILE} || exit 1 dd if=/dev/zero of=${FILE} bs=1024k count=256 &>/dev/null || die "Error $? creating ${FILE}" - losetup ${DEVICE} ${FILE} || + ${LOSETUP} ${DEVICE} ${FILE} || die "Error $? creating ${FILE} -> ${DEVICE} loopback" DEVICES="${DEVICES} ${DEVICE}" done @@ -30,9 +30,9 @@ zpool_destroy() { ${CMDDIR}/zpool/zpool destroy ${ZPOOL_NAME} for FILE in ${FILES}; do - DEVICE=`/sbin/losetup -a | grep ${FILE} | head -n1|cut -f1 -d:` + DEVICE=`${LOSETUP} -a | grep ${FILE} | head -n1|cut -f1 -d:` msg "Removing ${FILE} using loopback device ${DEVICE}" - losetup -d ${DEVICE} || + ${LOSETUP} -d ${DEVICE} || die "Error $? destroying ${FILE} -> ${DEVICE} loopback" rm -f ${FILE} || exit 1 done diff --git a/scripts/zpool-config/lo-raidz2.sh b/scripts/zpool-config/lo-raidz2.sh index dbd7d815eb..2883d7f9f5 100644 --- a/scripts/zpool-config/lo-raidz2.sh +++ b/scripts/zpool-config/lo-raidz2.sh @@ -16,7 +16,7 @@ zpool_create() { rm -f ${FILE} || exit 1 dd if=/dev/zero of=${FILE} bs=1024k count=256 &>/dev/null || die "Error $? creating ${FILE}" - losetup ${DEVICE} ${FILE} || + ${LOSETUP} ${DEVICE} ${FILE} || die "Error $? creating ${FILE} -> ${DEVICE} loopback" DEVICES="${DEVICES} ${DEVICE}" done @@ -30,9 +30,9 @@ zpool_destroy() { ${CMDDIR}/zpool/zpool destroy ${ZPOOL_NAME} for FILE in ${FILES}; do - DEVICE=`/sbin/losetup -a | grep ${FILE} | head -n1|cut -f1 -d:` + DEVICE=`${LOSETUP} -a | grep ${FILE} | head -n1|cut -f1 -d:` msg "Removing ${FILE} using loopback device ${DEVICE}" - losetup -d ${DEVICE} || + ${LOSETUP} -d ${DEVICE} || die "Error $? destroying ${FILE} -> ${DEVICE} loopback" rm -f ${FILE} || exit 1 done