From 07237a7bc1eab62d8bb2bb7b4abafe7a2fd3a482 Mon Sep 17 00:00:00 2001 From: John Wren Kennedy Date: Fri, 15 Feb 2019 13:45:46 -0700 Subject: [PATCH] ZTS: clone_001_pos fails in cleanup on busy dataset The "cleanup_all" function in this test calls "zfs destroy" which fails approximately 30% of the time in our environment due to the dataset being busy. Since the failure happens during cleanup, the error is propagated to subsequent tests. Tested by running the snapshot test group in a loop without seeing any failures. Reviewed-by: George Melikov Reviewed-by: Igor Kozhukhov Reviewed-by: Brian Behlendorf Signed-off-by: John Kennedy Closes #8409 --- tests/zfs-tests/tests/functional/snapshot/clone_001_pos.ksh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/zfs-tests/tests/functional/snapshot/clone_001_pos.ksh b/tests/zfs-tests/tests/functional/snapshot/clone_001_pos.ksh index 4ba853162c..5268971932 100755 --- a/tests/zfs-tests/tests/functional/snapshot/clone_001_pos.ksh +++ b/tests/zfs-tests/tests/functional/snapshot/clone_001_pos.ksh @@ -75,7 +75,7 @@ function cleanup_all i=0 while (( i < ${#args[*]} )); do snapexists ${args[i]} && \ - log_must zfs destroy -Rf ${args[i]} + destroy_dataset "${args[i]}" "-Rf" [[ -d ${args[i+3]} ]] && \ log_must rm -rf ${args[i+3]}