Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Added Linux-specific hole fallback tunable 

Per #15933, there's currently an inconsistency in behavior
in our special-case SEEK_HOLE behavior.

So let's not use it for now.

Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
This commit is contained in:
Rich Ercolani 2024-03-17 14:03:12 -04:00
parent 8f2f6cd2ac
commit 02e4699d91
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
module/os/linux/zfs/zpl_file.c
View File

@ -51,6 +51,8 @@
*/ */
static unsigned int zfs_fallocate_reserve_percent = 110; static unsigned int zfs_fallocate_reserve_percent = 110;
static unsigned int zfs_disable_holey = 1;
static int static int
zpl_open(struct inode *ip, struct file *filp) zpl_open(struct inode *ip, struct file *filp)
{ {
@ -550,6 +552,7 @@ zpl_direct_IO(int rw, struct kiocb *kiocb, struct iov_iter *iter, loff_t pos)
static loff_t static loff_t
zpl_llseek(struct file *filp, loff_t offset, int whence) zpl_llseek(struct file *filp, loff_t offset, int whence)
{ {
if (!(zfs_disable_holey)) {
#if defined(SEEK_HOLE) && defined(SEEK_DATA) #if defined(SEEK_HOLE) && defined(SEEK_DATA)
fstrans_cookie_t cookie; fstrans_cookie_t cookie;
@ -569,7 +572,7 @@ zpl_llseek(struct file *filp, loff_t offset, int whence)
return (error); return (error);
} }
#endif /* SEEK_HOLE && SEEK_DATA */ #endif /* SEEK_HOLE && SEEK_DATA */
}
return (generic_file_llseek(filp, offset, whence)); return (generic_file_llseek(filp, offset, whence));
} }
@ -1389,3 +1392,8 @@ const struct file_operations zpl_dir_file_operations = {
module_param(zfs_fallocate_reserve_percent, uint, 0644); module_param(zfs_fallocate_reserve_percent, uint, 0644);
MODULE_PARM_DESC(zfs_fallocate_reserve_percent, MODULE_PARM_DESC(zfs_fallocate_reserve_percent,
"Percentage of length to use for the available capacity check"); "Percentage of length to use for the available capacity check");
/* CSTYLED */
module_param(zfs_disable_holey, uint, 0644);
MODULE_PARM_DESC(zfs_disable_holey,
"Disable ZFS-specific implementation of hole detection");