From 029a1b0c207f204b1b78086b009c6de8fc383cb3 Mon Sep 17 00:00:00 2001 From: Giuseppe Di Natale Date: Mon, 23 Oct 2017 14:18:12 -0700 Subject: [PATCH] Ensure arc_size_break is filled in arc_summary.py Use mfu_size and mru_size pulled from the arcstats kstat file to calculate the mfu and mru percentages for arc size breakdown. Reviewed-by: George Melikov Reviewed-by: Brian Behlendorf Reviewed-by: Richard Elling Reviewed-by: AndCycle Signed-off-by: Giuseppe Di Natale Closes #5526 Closes #6770 --- cmd/arc_summary/arc_summary.py | 32 ++++++++++---------------------- 1 file changed, 10 insertions(+), 22 deletions(-) diff --git a/cmd/arc_summary/arc_summary.py b/cmd/arc_summary/arc_summary.py index f5aac737b3..93918a08f3 100755 --- a/cmd/arc_summary/arc_summary.py +++ b/cmd/arc_summary/arc_summary.py @@ -185,7 +185,8 @@ def get_arc_summary(Kstat): # ARC Sizing arc_size = Kstat["kstat.zfs.misc.arcstats.size"] - mru_size = Kstat["kstat.zfs.misc.arcstats.p"] + mru_size = Kstat["kstat.zfs.misc.arcstats.mru_size"] + mfu_size = Kstat["kstat.zfs.misc.arcstats.mfu_size"] target_max_size = Kstat["kstat.zfs.misc.arcstats.c_max"] target_min_size = Kstat["kstat.zfs.misc.arcstats.c_min"] target_size = Kstat["kstat.zfs.misc.arcstats.c"] @@ -230,27 +231,14 @@ def get_arc_summary(Kstat): ] output['arc_size_break'] = {} - if arc_size > target_size: - mfu_size = (arc_size - mru_size) - output['arc_size_break']['recently_used_cache_size'] = { - 'per': fPerc(mru_size, arc_size), - 'num': fBytes(mru_size), - } - output['arc_size_break']['frequently_used_cache_size'] = { - 'per': fPerc(mfu_size, arc_size), - 'num': fBytes(mfu_size), - } - - elif arc_size < target_size: - mfu_size = (target_size - mru_size) - output['arc_size_break']['recently_used_cache_size'] = { - 'per': fPerc(mru_size, target_size), - 'num': fBytes(mru_size), - } - output['arc_size_break']['frequently_used_cache_size'] = { - 'per': fPerc(mfu_size, target_size), - 'num': fBytes(mfu_size), - } + output['arc_size_break']['recently_used_cache_size'] = { + 'per': fPerc(mru_size, mru_size + mfu_size), + 'num': fBytes(mru_size), + } + output['arc_size_break']['frequently_used_cache_size'] = { + 'per': fPerc(mfu_size, mru_size + mfu_size), + 'num': fBytes(mfu_size), + } # ARC Hash Breakdown hash_chain_max = Kstat["kstat.zfs.misc.arcstats.hash_chain_max"]