2014-01-21 21:30:03 +00:00
|
|
|
/*
|
2020-10-09 03:10:13 +00:00
|
|
|
* This file is part of the ZFS Event Daemon (ZED).
|
|
|
|
|
*
|
2014-01-21 21:30:03 +00:00
|
|
|
* Developed at Lawrence Livermore National Laboratory (LLNL-CODE-403049).
|
|
|
|
|
* Copyright (C) 2013-2014 Lawrence Livermore National Security, LLC.
|
2021-05-03 19:21:21 +00:00
|
|
|
* Refer to the OpenZFS git commit log for authoritative copyright attribution.
|
2015-05-06 22:56:03 +00:00
|
|
|
*
|
|
|
|
|
* The contents of this file are subject to the terms of the
|
|
|
|
|
* Common Development and Distribution License Version 1.0 (CDDL-1.0).
|
|
|
|
|
* You can obtain a copy of the license from the top-level file
|
|
|
|
|
* "OPENSOLARIS.LICENSE" or at <http://opensource.org/licenses/CDDL-1.0>.
|
|
|
|
|
* You may not use this file except in compliance with the license.
|
2014-01-21 21:30:03 +00:00
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#ifndef ZED_LOG_H
|
|
|
|
|
#define ZED_LOG_H
|
|
|
|
|
|
|
|
|
|
#include <syslog.h>
|
|
|
|
|
|
|
|
|
|
void zed_log_init(const char *identity);
|
|
|
|
|
|
|
|
|
|
void zed_log_fini(void);
|
|
|
|
|
|
2014-08-27 20:18:01 +00:00
|
|
|
void zed_log_pipe_open(void);
|
|
|
|
|
|
|
|
|
|
void zed_log_pipe_close_reads(void);
|
|
|
|
|
|
|
|
|
|
void zed_log_pipe_close_writes(void);
|
|
|
|
|
|
|
|
|
|
void zed_log_pipe_wait(void);
|
|
|
|
|
|
2014-08-28 21:39:48 +00:00
|
|
|
void zed_log_stderr_open(int priority);
|
2014-01-21 21:30:03 +00:00
|
|
|
|
|
|
|
|
void zed_log_stderr_close(void);
|
|
|
|
|
|
|
|
|
|
void zed_log_syslog_open(int facility);
|
|
|
|
|
|
|
|
|
|
void zed_log_syslog_close(void);
|
|
|
|
|
|
|
|
|
|
void zed_log_msg(int priority, const char *fmt, ...);
|
|
|
|
|
|
Reduce false positives from Static Analyzers
Both Clang's Static Analyzer and Synopsys' Coverity would ignore
assertions. Following Clang's advice, we annotate our assertions:
https://clang-analyzer.llvm.org/annotations.html#custom_assertions
This makes both Clang's Static Analyzer and Coverity properly identify
assertions. This change reduced Clang's reported defects from 246 to
180. It also reduced the false positives reported by Coverityi by 10,
while enabling Coverity to find 9 more defects that previously were
false negatives.
A couple examples of this would be CID-1524417 and CID-1524423. After
submitting a build to coverity with the modified assertions, CID-1524417
disappeared while the report for CID-1524423 no longer claimed that the
assertion tripped.
Coincidentally, it turns out that it is possible to more accurately
annotate our headers than the Coverity modelling file permits in the
case of format strings. Since we can do that and this patch annotates
headers whenever `__coverity_panic__()` would have been used in the
model file, we drop all models that use `__coverity_panic__()` from the
model file.
Upon seeing the success in eliminating false positives involving
assertions, it occurred to me that we could also modify our headers to
eliminate coverity's false positives involving byte swaps. We now have
coverity specific byteswap macros, that do nothing, to disable
Coverity's false positives when we do byte swaps. This allowed us to
also drop the byteswap definitions from the model file.
Lastly, a model file update has been done beyond the mentioned
deletions:
* The definitions of `umem_alloc_aligned()`, `umem_alloc()` andi
`umem_zalloc()` were originally implemented in a way that was
intended to inform coverity that when KM_SLEEP has been passed these
functions, they do not return NULL. A small error in how this was
done was found, so we correct it.
* Definitions for umem_cache_alloc() and umem_cache_free() have been
added.
In practice, no false positives were avoided by making these changes,
but in the interest of correctness from future coverity builds, we make
them anyway.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13902
2022-09-30 22:30:12 +00:00
|
|
|
__attribute__((format(printf, 1, 2), __noreturn__))
|
2014-01-21 21:30:03 +00:00
|
|
|
void zed_log_die(const char *fmt, ...);
|
|
|
|
|
|
|
|
|
|
#endif /* !ZED_LOG_H */
|
