2012-12-13 23:24:15 +00:00
|
|
|
/*
|
|
|
|
* CDDL HEADER START
|
|
|
|
*
|
|
|
|
* The contents of this file are subject to the terms of the
|
|
|
|
* Common Development and Distribution License (the "License").
|
|
|
|
* You may not use this file except in compliance with the License.
|
|
|
|
*
|
|
|
|
* You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
|
|
|
|
* or http://www.opensolaris.org/os/licensing.
|
|
|
|
* See the License for the specific language governing permissions
|
|
|
|
* and limitations under the License.
|
|
|
|
*
|
|
|
|
* When distributing Covered Code, include this CDDL HEADER in each
|
|
|
|
* file and include the License file at usr/src/OPENSOLARIS.LICENSE.
|
|
|
|
* If applicable, add the following below this CDDL HEADER, with the
|
|
|
|
* fields enclosed by brackets "[]" replaced with your own identifying
|
|
|
|
* information: Portions Copyright [yyyy] [name of copyright owner]
|
|
|
|
*
|
|
|
|
* CDDL HEADER END
|
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
2018-09-06 01:33:36 +00:00
|
|
|
* Copyright (c) 2011, 2018 by Delphix. All rights reserved.
|
2013-01-23 09:54:30 +00:00
|
|
|
* Copyright (c) 2013 by Saso Kiselkov. All rights reserved.
|
2017-04-06 15:25:47 +00:00
|
|
|
* Copyright (c) 2013, Joyent, Inc. All rights reserved.
|
2014-10-18 15:58:11 +00:00
|
|
|
* Copyright (c) 2014, Nexenta Systems, Inc. All rights reserved.
|
2018-09-06 01:33:36 +00:00
|
|
|
* Copyright (c) 2017, Intel Corporation.
|
2012-12-13 23:24:15 +00:00
|
|
|
*/
|
|
|
|
|
2018-02-16 01:53:18 +00:00
|
|
|
#ifndef _KERNEL
|
2012-12-13 23:24:15 +00:00
|
|
|
#include <errno.h>
|
|
|
|
#include <string.h>
|
2018-09-02 19:09:53 +00:00
|
|
|
#include <sys/stat.h>
|
2012-12-13 23:24:15 +00:00
|
|
|
#endif
|
|
|
|
#include <sys/debug.h>
|
|
|
|
#include <sys/fs/zfs.h>
|
|
|
|
#include <sys/inttypes.h>
|
|
|
|
#include <sys/types.h>
|
2018-09-02 19:09:53 +00:00
|
|
|
#include <sys/zfs_sysfs.h>
|
2012-12-13 23:24:15 +00:00
|
|
|
#include "zfeature_common.h"
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Set to disable all feature checks while opening pools, allowing pools with
|
|
|
|
* unsupported features to be opened. Set for testing only.
|
|
|
|
*/
|
|
|
|
boolean_t zfeature_checks_disable = B_FALSE;
|
|
|
|
|
|
|
|
zfeature_info_t spa_feature_table[SPA_FEATURES];
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Valid characters for feature guids. This list is mainly for aesthetic
|
|
|
|
* purposes and could be expanded in the future. There are different allowed
|
|
|
|
* characters in the guids reverse dns portion (before the colon) and its
|
|
|
|
* short name (after the colon).
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
valid_char(char c, boolean_t after_colon)
|
|
|
|
{
|
|
|
|
return ((c >= 'a' && c <= 'z') ||
|
|
|
|
(c >= '0' && c <= '9') ||
|
2014-11-03 20:15:08 +00:00
|
|
|
(after_colon && c == '_') ||
|
|
|
|
(!after_colon && (c == '.' || c == '-')));
|
2012-12-13 23:24:15 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Every feature guid must contain exactly one colon which separates a reverse
|
|
|
|
* dns organization name from the feature's "short" name (e.g.
|
|
|
|
* "com.company:feature_name").
|
|
|
|
*/
|
|
|
|
boolean_t
|
|
|
|
zfeature_is_valid_guid(const char *name)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
boolean_t has_colon = B_FALSE;
|
|
|
|
|
|
|
|
i = 0;
|
|
|
|
while (name[i] != '\0') {
|
|
|
|
char c = name[i++];
|
|
|
|
if (c == ':') {
|
|
|
|
if (has_colon)
|
|
|
|
return (B_FALSE);
|
|
|
|
has_colon = B_TRUE;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if (!valid_char(c, has_colon))
|
|
|
|
return (B_FALSE);
|
|
|
|
}
|
|
|
|
|
|
|
|
return (has_colon);
|
|
|
|
}
|
|
|
|
|
|
|
|
boolean_t
|
|
|
|
zfeature_is_supported(const char *guid)
|
|
|
|
{
|
|
|
|
if (zfeature_checks_disable)
|
|
|
|
return (B_TRUE);
|
|
|
|
|
2017-11-04 20:25:13 +00:00
|
|
|
for (spa_feature_t i = 0; i < SPA_FEATURES; i++) {
|
2012-12-13 23:24:15 +00:00
|
|
|
zfeature_info_t *feature = &spa_feature_table[i];
|
2013-10-08 17:13:05 +00:00
|
|
|
if (strcmp(guid, feature->fi_guid) == 0)
|
|
|
|
return (B_TRUE);
|
2012-12-13 23:24:15 +00:00
|
|
|
}
|
2013-10-08 17:13:05 +00:00
|
|
|
return (B_FALSE);
|
2012-12-13 23:24:15 +00:00
|
|
|
}
|
|
|
|
|
2018-09-02 19:09:53 +00:00
|
|
|
int
|
|
|
|
zfeature_lookup_guid(const char *guid, spa_feature_t *res)
|
|
|
|
{
|
|
|
|
for (spa_feature_t i = 0; i < SPA_FEATURES; i++) {
|
|
|
|
zfeature_info_t *feature = &spa_feature_table[i];
|
|
|
|
if (!feature->fi_zfs_mod_supported)
|
|
|
|
continue;
|
|
|
|
if (strcmp(guid, feature->fi_guid) == 0) {
|
|
|
|
if (res != NULL)
|
|
|
|
*res = i;
|
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return (ENOENT);
|
|
|
|
}
|
|
|
|
|
2012-12-13 23:24:15 +00:00
|
|
|
int
|
2013-10-08 17:13:05 +00:00
|
|
|
zfeature_lookup_name(const char *name, spa_feature_t *res)
|
2012-12-13 23:24:15 +00:00
|
|
|
{
|
2017-11-04 20:25:13 +00:00
|
|
|
for (spa_feature_t i = 0; i < SPA_FEATURES; i++) {
|
2012-12-13 23:24:15 +00:00
|
|
|
zfeature_info_t *feature = &spa_feature_table[i];
|
2018-09-02 19:09:53 +00:00
|
|
|
if (!feature->fi_zfs_mod_supported)
|
|
|
|
continue;
|
2012-12-13 23:24:15 +00:00
|
|
|
if (strcmp(name, feature->fi_uname) == 0) {
|
|
|
|
if (res != NULL)
|
2013-10-08 17:13:05 +00:00
|
|
|
*res = i;
|
2012-12-13 23:24:15 +00:00
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return (ENOENT);
|
|
|
|
}
|
|
|
|
|
2013-12-09 18:37:51 +00:00
|
|
|
boolean_t
|
2017-01-12 17:42:11 +00:00
|
|
|
zfeature_depends_on(spa_feature_t fid, spa_feature_t check)
|
|
|
|
{
|
2013-12-09 18:37:51 +00:00
|
|
|
zfeature_info_t *feature = &spa_feature_table[fid];
|
|
|
|
|
2017-11-04 20:25:13 +00:00
|
|
|
for (int i = 0; feature->fi_depends[i] != SPA_FEATURE_NONE; i++) {
|
2013-12-09 18:37:51 +00:00
|
|
|
if (feature->fi_depends[i] == check)
|
|
|
|
return (B_TRUE);
|
|
|
|
}
|
|
|
|
return (B_FALSE);
|
|
|
|
}
|
|
|
|
|
2017-01-12 19:58:04 +00:00
|
|
|
static boolean_t
|
|
|
|
deps_contains_feature(const spa_feature_t *deps, const spa_feature_t feature)
|
|
|
|
{
|
2017-11-04 20:25:13 +00:00
|
|
|
for (int i = 0; deps[i] != SPA_FEATURE_NONE; i++)
|
2017-01-12 19:58:04 +00:00
|
|
|
if (deps[i] == feature)
|
|
|
|
return (B_TRUE);
|
|
|
|
|
|
|
|
return (B_FALSE);
|
|
|
|
}
|
|
|
|
|
2018-09-07 04:44:52 +00:00
|
|
|
#if !defined(_KERNEL) && !defined(LIB_ZPOOL_BUILD)
|
2018-09-02 19:09:53 +00:00
|
|
|
static boolean_t
|
2018-09-07 04:44:52 +00:00
|
|
|
zfs_mod_supported_impl(const char *scope, const char *name, const char *sysfs)
|
2018-09-02 19:09:53 +00:00
|
|
|
{
|
|
|
|
struct stat64 statbuf;
|
|
|
|
char *path;
|
|
|
|
boolean_t supported = B_FALSE;
|
|
|
|
int len;
|
|
|
|
|
2018-09-07 04:44:52 +00:00
|
|
|
len = asprintf(&path, "%s/%s/%s", sysfs, scope, name);
|
2018-09-02 19:09:53 +00:00
|
|
|
|
|
|
|
if (len > 0) {
|
|
|
|
supported = !!(stat64(path, &statbuf) == 0);
|
|
|
|
free(path);
|
|
|
|
}
|
|
|
|
return (supported);
|
2018-09-07 04:44:52 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
boolean_t
|
|
|
|
zfs_mod_supported(const char *scope, const char *name)
|
|
|
|
{
|
|
|
|
return (zfs_mod_supported_impl(scope, name, ZFS_SYSFS_DIR) ||
|
|
|
|
zfs_mod_supported_impl(scope, name, ZFS_SYSFS_ALT_DIR));
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
static boolean_t
|
|
|
|
zfs_mod_supported_feature(const char *name)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* The zfs module spa_feature_table[], whether in-kernel or in
|
|
|
|
* libzpool, always supports all the features. libzfs needs to
|
|
|
|
* query the running module, via sysfs, to determine which
|
|
|
|
* features are supported.
|
|
|
|
*/
|
|
|
|
#if defined(_KERNEL) || defined(LIB_ZPOOL_BUILD)
|
|
|
|
return (B_TRUE);
|
|
|
|
#else
|
|
|
|
return (zfs_mod_supported(ZFS_SYSFS_POOL_FEATURES, name));
|
2018-09-02 19:09:53 +00:00
|
|
|
#endif
|
|
|
|
}
|
|
|
|
|
2012-12-13 23:24:15 +00:00
|
|
|
static void
|
2013-10-08 17:13:05 +00:00
|
|
|
zfeature_register(spa_feature_t fid, const char *guid, const char *name,
|
2018-10-16 18:15:04 +00:00
|
|
|
const char *desc, zfeature_flags_t flags, zfeature_type_t type,
|
|
|
|
const spa_feature_t *deps)
|
2012-12-13 23:24:15 +00:00
|
|
|
{
|
|
|
|
zfeature_info_t *feature = &spa_feature_table[fid];
|
2013-10-08 17:13:05 +00:00
|
|
|
static spa_feature_t nodeps[] = { SPA_FEATURE_NONE };
|
2012-12-13 23:24:15 +00:00
|
|
|
|
|
|
|
ASSERT(name != NULL);
|
|
|
|
ASSERT(desc != NULL);
|
2015-07-24 16:53:55 +00:00
|
|
|
ASSERT((flags & ZFEATURE_FLAG_READONLY_COMPAT) == 0 ||
|
|
|
|
(flags & ZFEATURE_FLAG_MOS) == 0);
|
2012-12-13 23:24:15 +00:00
|
|
|
ASSERT3U(fid, <, SPA_FEATURES);
|
|
|
|
ASSERT(zfeature_is_valid_guid(guid));
|
|
|
|
|
|
|
|
if (deps == NULL)
|
|
|
|
deps = nodeps;
|
|
|
|
|
2017-01-12 19:58:04 +00:00
|
|
|
VERIFY(((flags & ZFEATURE_FLAG_PER_DATASET) == 0) ||
|
|
|
|
(deps_contains_feature(deps, SPA_FEATURE_EXTENSIBLE_DATASET)));
|
|
|
|
|
2013-10-08 17:13:05 +00:00
|
|
|
feature->fi_feature = fid;
|
2012-12-13 23:24:15 +00:00
|
|
|
feature->fi_guid = guid;
|
|
|
|
feature->fi_uname = name;
|
|
|
|
feature->fi_desc = desc;
|
2015-07-24 16:53:55 +00:00
|
|
|
feature->fi_flags = flags;
|
2018-10-16 18:15:04 +00:00
|
|
|
feature->fi_type = type;
|
2012-12-13 23:24:15 +00:00
|
|
|
feature->fi_depends = deps;
|
2018-09-02 19:09:53 +00:00
|
|
|
feature->fi_zfs_mod_supported = zfs_mod_supported_feature(guid);
|
2012-12-13 23:24:15 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
zpool_feature_init(void)
|
|
|
|
{
|
|
|
|
zfeature_register(SPA_FEATURE_ASYNC_DESTROY,
|
|
|
|
"com.delphix:async_destroy", "async_destroy",
|
2015-07-24 16:53:55 +00:00
|
|
|
"Destroy filesystems asynchronously.",
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_FLAG_READONLY_COMPAT, ZFEATURE_TYPE_BOOLEAN, NULL);
|
2013-12-09 18:37:51 +00:00
|
|
|
|
2012-12-23 23:57:14 +00:00
|
|
|
zfeature_register(SPA_FEATURE_EMPTY_BPOBJ,
|
|
|
|
"com.delphix:empty_bpobj", "empty_bpobj",
|
2015-07-24 16:53:55 +00:00
|
|
|
"Snapshots use less space.",
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_FLAG_READONLY_COMPAT, ZFEATURE_TYPE_BOOLEAN, NULL);
|
2013-12-09 18:37:51 +00:00
|
|
|
|
2013-01-23 09:54:30 +00:00
|
|
|
zfeature_register(SPA_FEATURE_LZ4_COMPRESS,
|
|
|
|
"org.illumos:lz4_compress", "lz4_compress",
|
2015-07-24 16:53:55 +00:00
|
|
|
"LZ4 compression algorithm support.",
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_FLAG_ACTIVATE_ON_ENABLE, ZFEATURE_TYPE_BOOLEAN, NULL);
|
2013-12-09 18:37:51 +00:00
|
|
|
|
2017-04-06 15:25:47 +00:00
|
|
|
zfeature_register(SPA_FEATURE_MULTI_VDEV_CRASH_DUMP,
|
|
|
|
"com.joyent:multi_vdev_crash_dump", "multi_vdev_crash_dump",
|
|
|
|
"Crash dumps to multiple vdev pools.",
|
2018-10-16 18:15:04 +00:00
|
|
|
0, ZFEATURE_TYPE_BOOLEAN, NULL);
|
2017-04-06 15:25:47 +00:00
|
|
|
|
Illumos #4101, #4102, #4103, #4105, #4106
4101 metaslab_debug should allow for fine-grained control
4102 space_maps should store more information about themselves
4103 space map object blocksize should be increased
4105 removing a mirrored log device results in a leaked object
4106 asynchronously load metaslab
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Adam Leventhal <ahl@delphix.com>
Reviewed by: Sebastien Roy <seb@delphix.com>
Approved by: Garrett D'Amore <garrett@damore.org>
Prior to this patch, space_maps were preferred solely based on the
amount of free space left in each. Unfortunately, this heuristic didn't
contain any information about the make-up of that free space, which
meant we could keep preferring and loading a highly fragmented space map
that wouldn't actually have enough contiguous space to satisfy the
allocation; then unloading that space_map and repeating the process.
This change modifies the space_map's to store additional information
about the contiguous space in the space_map, so that we can use this
information to make a better decision about which space_map to load.
This requires reallocating all space_map objects to increase their
bonus buffer size sizes enough to fit the new metadata.
The above feature can be enabled via a new feature flag introduced by
this change: com.delphix:spacemap_histogram
In addition to the above, this patch allows the space_map block size to
be increase. Currently the block size is set to be 4K in size, which has
certain implications including the following:
* 4K sector devices will not see any compression benefit
* large space_maps require more metadata on-disk
* large space_maps require more time to load (typically random reads)
Now the space_map block size can adjust as needed up to the maximum size
set via the space_map_max_blksz variable.
A bug was fixed which resulted in potentially leaking an object when
removing a mirrored log device. The previous logic for vdev_remove() did
not deal with removing top-level vdevs that are interior vdevs (i.e.
mirror) correctly. The problem would occur when removing a mirrored log
device, and result in the DTL space map object being leaked; because
top-level vdevs don't have DTL space map objects associated with them.
References:
https://www.illumos.org/issues/4101
https://www.illumos.org/issues/4102
https://www.illumos.org/issues/4103
https://www.illumos.org/issues/4105
https://www.illumos.org/issues/4106
https://github.com/illumos/illumos-gate/commit/0713e23
Porting notes:
A handful of kmem_alloc() calls were converted to kmem_zalloc(). Also,
the KM_PUSHPAGE and TQ_PUSHPAGE flags were used as necessary.
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Prakash Surya <surya1@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #2488
2013-10-01 21:25:53 +00:00
|
|
|
zfeature_register(SPA_FEATURE_SPACEMAP_HISTOGRAM,
|
|
|
|
"com.delphix:spacemap_histogram", "spacemap_histogram",
|
2015-07-24 16:53:55 +00:00
|
|
|
"Spacemaps maintain space histograms.",
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_FLAG_READONLY_COMPAT, ZFEATURE_TYPE_BOOLEAN, NULL);
|
2013-12-09 18:37:51 +00:00
|
|
|
|
|
|
|
zfeature_register(SPA_FEATURE_ENABLED_TXG,
|
|
|
|
"com.delphix:enabled_txg", "enabled_txg",
|
2015-07-24 16:53:55 +00:00
|
|
|
"Record txg at which a feature is enabled",
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_FLAG_READONLY_COMPAT, ZFEATURE_TYPE_BOOLEAN, NULL);
|
2013-12-09 18:37:51 +00:00
|
|
|
|
|
|
|
{
|
2013-12-11 22:33:41 +00:00
|
|
|
static const spa_feature_t hole_birth_deps[] = {
|
|
|
|
SPA_FEATURE_ENABLED_TXG,
|
|
|
|
SPA_FEATURE_NONE
|
|
|
|
};
|
2013-12-09 18:37:51 +00:00
|
|
|
zfeature_register(SPA_FEATURE_HOLE_BIRTH,
|
|
|
|
"com.delphix:hole_birth", "hole_birth",
|
|
|
|
"Retain hole birth txg for more precise zfs send",
|
2015-07-24 16:53:55 +00:00
|
|
|
ZFEATURE_FLAG_MOS | ZFEATURE_FLAG_ACTIVATE_ON_ENABLE,
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_TYPE_BOOLEAN, hole_birth_deps);
|
2013-12-09 18:37:51 +00:00
|
|
|
}
|
|
|
|
|
2016-12-16 22:11:29 +00:00
|
|
|
zfeature_register(SPA_FEATURE_POOL_CHECKPOINT,
|
|
|
|
"com.delphix:zpool_checkpoint", "zpool_checkpoint",
|
|
|
|
"Pool state can be checkpointed, allowing rewind later.",
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_FLAG_READONLY_COMPAT, ZFEATURE_TYPE_BOOLEAN, NULL);
|
2016-12-16 22:11:29 +00:00
|
|
|
|
2017-08-04 16:30:49 +00:00
|
|
|
zfeature_register(SPA_FEATURE_SPACEMAP_V2,
|
|
|
|
"com.delphix:spacemap_v2", "spacemap_v2",
|
|
|
|
"Space maps representing large segments are more efficient.",
|
|
|
|
ZFEATURE_FLAG_READONLY_COMPAT | ZFEATURE_FLAG_ACTIVATE_ON_ENABLE,
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_TYPE_BOOLEAN, NULL);
|
2017-08-04 16:30:49 +00:00
|
|
|
|
2013-10-08 17:13:05 +00:00
|
|
|
zfeature_register(SPA_FEATURE_EXTENSIBLE_DATASET,
|
|
|
|
"com.delphix:extensible_dataset", "extensible_dataset",
|
|
|
|
"Enhanced dataset functionality, used by other features.",
|
2018-10-16 18:15:04 +00:00
|
|
|
0, ZFEATURE_TYPE_BOOLEAN, NULL);
|
2013-12-11 22:33:41 +00:00
|
|
|
|
|
|
|
{
|
|
|
|
static const spa_feature_t bookmarks_deps[] = {
|
|
|
|
SPA_FEATURE_EXTENSIBLE_DATASET,
|
|
|
|
SPA_FEATURE_NONE
|
|
|
|
};
|
|
|
|
|
|
|
|
zfeature_register(SPA_FEATURE_BOOKMARKS,
|
|
|
|
"com.delphix:bookmarks", "bookmarks",
|
|
|
|
"\"zfs bookmark\" command",
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_FLAG_READONLY_COMPAT, ZFEATURE_TYPE_BOOLEAN,
|
|
|
|
bookmarks_deps);
|
2013-12-11 22:33:41 +00:00
|
|
|
}
|
2014-06-05 21:19:08 +00:00
|
|
|
|
2015-04-01 13:07:48 +00:00
|
|
|
{
|
|
|
|
static const spa_feature_t filesystem_limits_deps[] = {
|
2017-01-17 22:46:28 +00:00
|
|
|
SPA_FEATURE_EXTENSIBLE_DATASET,
|
|
|
|
SPA_FEATURE_NONE
|
2015-04-01 13:07:48 +00:00
|
|
|
};
|
|
|
|
zfeature_register(SPA_FEATURE_FS_SS_LIMIT,
|
|
|
|
"com.joyent:filesystem_limits", "filesystem_limits",
|
2015-07-24 16:53:55 +00:00
|
|
|
"Filesystem and snapshot limits.",
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_FLAG_READONLY_COMPAT, ZFEATURE_TYPE_BOOLEAN,
|
|
|
|
filesystem_limits_deps);
|
2015-04-01 13:07:48 +00:00
|
|
|
}
|
|
|
|
|
2014-06-05 21:19:08 +00:00
|
|
|
zfeature_register(SPA_FEATURE_EMBEDDED_DATA,
|
|
|
|
"com.delphix:embedded_data", "embedded_data",
|
|
|
|
"Blocks which compress very well use even less space.",
|
2015-07-24 16:53:55 +00:00
|
|
|
ZFEATURE_FLAG_MOS | ZFEATURE_FLAG_ACTIVATE_ON_ENABLE,
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_TYPE_BOOLEAN, NULL);
|
2014-11-03 20:15:08 +00:00
|
|
|
|
|
|
|
{
|
|
|
|
static const spa_feature_t large_blocks_deps[] = {
|
|
|
|
SPA_FEATURE_EXTENSIBLE_DATASET,
|
|
|
|
SPA_FEATURE_NONE
|
|
|
|
};
|
|
|
|
zfeature_register(SPA_FEATURE_LARGE_BLOCKS,
|
|
|
|
"org.open-zfs:large_blocks", "large_blocks",
|
2015-07-24 16:53:55 +00:00
|
|
|
"Support for blocks larger than 128KB.",
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_FLAG_PER_DATASET, ZFEATURE_TYPE_BOOLEAN,
|
|
|
|
large_blocks_deps);
|
2014-11-03 20:15:08 +00:00
|
|
|
}
|
Implement large_dnode pool feature
Justification
-------------
This feature adds support for variable length dnodes. Our motivation is
to eliminate the overhead associated with using spill blocks. Spill
blocks are used to store system attribute data (i.e. file metadata) that
does not fit in the dnode's bonus buffer. By allowing a larger bonus
buffer area the use of a spill block can be avoided. Spill blocks
potentially incur an additional read I/O for every dnode in a dnode
block. As a worst case example, reading 32 dnodes from a 16k dnode block
and all of the spill blocks could issue 33 separate reads. Now suppose
those dnodes have size 1024 and therefore don't need spill blocks. Then
the worst case number of blocks read is reduced to from 33 to two--one
per dnode block. In practice spill blocks may tend to be co-located on
disk with the dnode blocks so the reduction in I/O would not be this
drastic. In a badly fragmented pool, however, the improvement could be
significant.
ZFS-on-Linux systems that make heavy use of extended attributes would
benefit from this feature. In particular, ZFS-on-Linux supports the
xattr=sa dataset property which allows file extended attribute data
to be stored in the dnode bonus buffer as an alternative to the
traditional directory-based format. Workloads such as SELinux and the
Lustre distributed filesystem often store enough xattr data to force
spill bocks when xattr=sa is in effect. Large dnodes may therefore
provide a performance benefit to such systems.
Other use cases that may benefit from this feature include files with
large ACLs and symbolic links with long target names. Furthermore,
this feature may be desirable on other platforms in case future
applications or features are developed that could make use of a
larger bonus buffer area.
Implementation
--------------
The size of a dnode may be a multiple of 512 bytes up to the size of
a dnode block (currently 16384 bytes). A dn_extra_slots field was
added to the current on-disk dnode_phys_t structure to describe the
size of the physical dnode on disk. The 8 bits for this field were
taken from the zero filled dn_pad2 field. The field represents how
many "extra" dnode_phys_t slots a dnode consumes in its dnode block.
This convention results in a value of 0 for 512 byte dnodes which
preserves on-disk format compatibility with older software.
Similarly, the in-memory dnode_t structure has a new dn_num_slots field
to represent the total number of dnode_phys_t slots consumed on disk.
Thus dn->dn_num_slots is 1 greater than the corresponding
dnp->dn_extra_slots. This difference in convention was adopted
because, unlike on-disk structures, backward compatibility is not a
concern for in-memory objects, so we used a more natural way to
represent size for a dnode_t.
The default size for newly created dnodes is determined by the value of
a new "dnodesize" dataset property. By default the property is set to
"legacy" which is compatible with older software. Setting the property
to "auto" will allow the filesystem to choose the most suitable dnode
size. Currently this just sets the default dnode size to 1k, but future
code improvements could dynamically choose a size based on observed
workload patterns. Dnodes of varying sizes can coexist within the same
dataset and even within the same dnode block. For example, to enable
automatically-sized dnodes, run
# zfs set dnodesize=auto tank/fish
The user can also specify literal values for the dnodesize property.
These are currently limited to powers of two from 1k to 16k. The
power-of-2 limitation is only for simplicity of the user interface.
Internally the implementation can handle any multiple of 512 up to 16k,
and consumers of the DMU API can specify any legal dnode value.
The size of a new dnode is determined at object allocation time and
stored as a new field in the znode in-memory structure. New DMU
interfaces are added to allow the consumer to specify the dnode size
that a newly allocated object should use. Existing interfaces are
unchanged to avoid having to update every call site and to preserve
compatibility with external consumers such as Lustre. The new
interfaces names are given below. The versions of these functions that
don't take a dnodesize parameter now just call the _dnsize() versions
with a dnodesize of 0, which means use the legacy dnode size.
New DMU interfaces:
dmu_object_alloc_dnsize()
dmu_object_claim_dnsize()
dmu_object_reclaim_dnsize()
New ZAP interfaces:
zap_create_dnsize()
zap_create_norm_dnsize()
zap_create_flags_dnsize()
zap_create_claim_norm_dnsize()
zap_create_link_dnsize()
The constant DN_MAX_BONUSLEN is renamed to DN_OLD_MAX_BONUSLEN. The
spa_maxdnodesize() function should be used to determine the maximum
bonus length for a pool.
These are a few noteworthy changes to key functions:
* The prototype for dnode_hold_impl() now takes a "slots" parameter.
When the DNODE_MUST_BE_FREE flag is set, this parameter is used to
ensure the hole at the specified object offset is large enough to
hold the dnode being created. The slots parameter is also used
to ensure a dnode does not span multiple dnode blocks. In both of
these cases, if a failure occurs, ENOSPC is returned. Keep in mind,
these failure cases are only possible when using DNODE_MUST_BE_FREE.
If the DNODE_MUST_BE_ALLOCATED flag is set, "slots" must be 0.
dnode_hold_impl() will check if the requested dnode is already
consumed as an extra dnode slot by an large dnode, in which case
it returns ENOENT.
* The function dmu_object_alloc() advances to the next dnode block
if dnode_hold_impl() returns an error for a requested object.
This is because the beginning of the next dnode block is the only
location it can safely assume to either be a hole or a valid
starting point for a dnode.
* dnode_next_offset_level() and other functions that iterate
through dnode blocks may no longer use a simple array indexing
scheme. These now use the current dnode's dn_num_slots field to
advance to the next dnode in the block. This is to ensure we
properly skip the current dnode's bonus area and don't interpret it
as a valid dnode.
zdb
---
The zdb command was updated to display a dnode's size under the
"dnsize" column when the object is dumped.
For ZIL create log records, zdb will now display the slot count for
the object.
ztest
-----
Ztest chooses a random dnodesize for every newly created object. The
random distribution is more heavily weighted toward small dnodes to
better simulate real-world datasets.
Unused bonus buffer space is filled with non-zero values computed from
the object number, dataset id, offset, and generation number. This
helps ensure that the dnode traversal code properly skips the interior
regions of large dnodes, and that these interior regions are not
overwritten by data belonging to other dnodes. A new test visits each
object in a dataset. It verifies that the actual dnode size matches what
was stored in the ztest block tag when it was created. It also verifies
that the unused bonus buffer space is filled with the expected data
patterns.
ZFS Test Suite
--------------
Added six new large dnode-specific tests, and integrated the dnodesize
property into existing tests for zfs allow and send/recv.
Send/Receive
------------
ZFS send streams for datasets containing large dnodes cannot be received
on pools that don't support the large_dnode feature. A send stream with
large dnodes sets a DMU_BACKUP_FEATURE_LARGE_DNODE flag which will be
unrecognized by an incompatible receiving pool so that the zfs receive
will fail gracefully.
While not implemented here, it may be possible to generate a
backward-compatible send stream from a dataset containing large
dnodes. The implementation may be tricky, however, because the send
object record for a large dnode would need to be resized to a 512
byte dnode, possibly kicking in a spill block in the process. This
means we would need to construct a new SA layout and possibly
register it in the SA layout object. The SA layout is normally just
sent as an ordinary object record. But if we are constructing new
layouts while generating the send stream we'd have to build the SA
layout object dynamically and send it at the end of the stream.
For sending and receiving between pools that do support large dnodes,
the drr_object send record type is extended with a new field to store
the dnode slot count. This field was repurposed from unused padding
in the structure.
ZIL Replay
----------
The dnode slot count is stored in the uppermost 8 bits of the lr_foid
field. The bits were unused as the object id is currently capped at
48 bits.
Resizing Dnodes
---------------
It should be possible to resize a dnode when it is dirtied if the
current dnodesize dataset property differs from the dnode's size, but
this functionality is not currently implemented. Clearly a dnode can
only grow if there are sufficient contiguous unused slots in the
dnode block, but it should always be possible to shrink a dnode.
Growing dnodes may be useful to reduce fragmentation in a pool with
many spill blocks in use. Shrinking dnodes may be useful to allow
sending a dataset to a pool that doesn't support the large_dnode
feature.
Feature Reference Counting
--------------------------
The reference count for the large_dnode pool feature tracks the
number of datasets that have ever contained a dnode of size larger
than 512 bytes. The first time a large dnode is created in a dataset
the dataset is converted to an extensible dataset. This is a one-way
operation and the only way to decrement the feature count is to
destroy the dataset, even if the dataset no longer contains any large
dnodes. The complexity of reference counting on a per-dnode basis was
too high, so we chose to track it on a per-dataset basis similarly to
the large_block feature.
Signed-off-by: Ned Bass <bass6@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #3542
2016-03-17 01:25:34 +00:00
|
|
|
|
|
|
|
{
|
|
|
|
static const spa_feature_t large_dnode_deps[] = {
|
|
|
|
SPA_FEATURE_EXTENSIBLE_DATASET,
|
|
|
|
SPA_FEATURE_NONE
|
|
|
|
};
|
|
|
|
zfeature_register(SPA_FEATURE_LARGE_DNODE,
|
|
|
|
"org.zfsonlinux:large_dnode", "large_dnode",
|
|
|
|
"Variable on-disk size of dnodes.",
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_FLAG_PER_DATASET, ZFEATURE_TYPE_BOOLEAN,
|
|
|
|
large_dnode_deps);
|
Implement large_dnode pool feature
Justification
-------------
This feature adds support for variable length dnodes. Our motivation is
to eliminate the overhead associated with using spill blocks. Spill
blocks are used to store system attribute data (i.e. file metadata) that
does not fit in the dnode's bonus buffer. By allowing a larger bonus
buffer area the use of a spill block can be avoided. Spill blocks
potentially incur an additional read I/O for every dnode in a dnode
block. As a worst case example, reading 32 dnodes from a 16k dnode block
and all of the spill blocks could issue 33 separate reads. Now suppose
those dnodes have size 1024 and therefore don't need spill blocks. Then
the worst case number of blocks read is reduced to from 33 to two--one
per dnode block. In practice spill blocks may tend to be co-located on
disk with the dnode blocks so the reduction in I/O would not be this
drastic. In a badly fragmented pool, however, the improvement could be
significant.
ZFS-on-Linux systems that make heavy use of extended attributes would
benefit from this feature. In particular, ZFS-on-Linux supports the
xattr=sa dataset property which allows file extended attribute data
to be stored in the dnode bonus buffer as an alternative to the
traditional directory-based format. Workloads such as SELinux and the
Lustre distributed filesystem often store enough xattr data to force
spill bocks when xattr=sa is in effect. Large dnodes may therefore
provide a performance benefit to such systems.
Other use cases that may benefit from this feature include files with
large ACLs and symbolic links with long target names. Furthermore,
this feature may be desirable on other platforms in case future
applications or features are developed that could make use of a
larger bonus buffer area.
Implementation
--------------
The size of a dnode may be a multiple of 512 bytes up to the size of
a dnode block (currently 16384 bytes). A dn_extra_slots field was
added to the current on-disk dnode_phys_t structure to describe the
size of the physical dnode on disk. The 8 bits for this field were
taken from the zero filled dn_pad2 field. The field represents how
many "extra" dnode_phys_t slots a dnode consumes in its dnode block.
This convention results in a value of 0 for 512 byte dnodes which
preserves on-disk format compatibility with older software.
Similarly, the in-memory dnode_t structure has a new dn_num_slots field
to represent the total number of dnode_phys_t slots consumed on disk.
Thus dn->dn_num_slots is 1 greater than the corresponding
dnp->dn_extra_slots. This difference in convention was adopted
because, unlike on-disk structures, backward compatibility is not a
concern for in-memory objects, so we used a more natural way to
represent size for a dnode_t.
The default size for newly created dnodes is determined by the value of
a new "dnodesize" dataset property. By default the property is set to
"legacy" which is compatible with older software. Setting the property
to "auto" will allow the filesystem to choose the most suitable dnode
size. Currently this just sets the default dnode size to 1k, but future
code improvements could dynamically choose a size based on observed
workload patterns. Dnodes of varying sizes can coexist within the same
dataset and even within the same dnode block. For example, to enable
automatically-sized dnodes, run
# zfs set dnodesize=auto tank/fish
The user can also specify literal values for the dnodesize property.
These are currently limited to powers of two from 1k to 16k. The
power-of-2 limitation is only for simplicity of the user interface.
Internally the implementation can handle any multiple of 512 up to 16k,
and consumers of the DMU API can specify any legal dnode value.
The size of a new dnode is determined at object allocation time and
stored as a new field in the znode in-memory structure. New DMU
interfaces are added to allow the consumer to specify the dnode size
that a newly allocated object should use. Existing interfaces are
unchanged to avoid having to update every call site and to preserve
compatibility with external consumers such as Lustre. The new
interfaces names are given below. The versions of these functions that
don't take a dnodesize parameter now just call the _dnsize() versions
with a dnodesize of 0, which means use the legacy dnode size.
New DMU interfaces:
dmu_object_alloc_dnsize()
dmu_object_claim_dnsize()
dmu_object_reclaim_dnsize()
New ZAP interfaces:
zap_create_dnsize()
zap_create_norm_dnsize()
zap_create_flags_dnsize()
zap_create_claim_norm_dnsize()
zap_create_link_dnsize()
The constant DN_MAX_BONUSLEN is renamed to DN_OLD_MAX_BONUSLEN. The
spa_maxdnodesize() function should be used to determine the maximum
bonus length for a pool.
These are a few noteworthy changes to key functions:
* The prototype for dnode_hold_impl() now takes a "slots" parameter.
When the DNODE_MUST_BE_FREE flag is set, this parameter is used to
ensure the hole at the specified object offset is large enough to
hold the dnode being created. The slots parameter is also used
to ensure a dnode does not span multiple dnode blocks. In both of
these cases, if a failure occurs, ENOSPC is returned. Keep in mind,
these failure cases are only possible when using DNODE_MUST_BE_FREE.
If the DNODE_MUST_BE_ALLOCATED flag is set, "slots" must be 0.
dnode_hold_impl() will check if the requested dnode is already
consumed as an extra dnode slot by an large dnode, in which case
it returns ENOENT.
* The function dmu_object_alloc() advances to the next dnode block
if dnode_hold_impl() returns an error for a requested object.
This is because the beginning of the next dnode block is the only
location it can safely assume to either be a hole or a valid
starting point for a dnode.
* dnode_next_offset_level() and other functions that iterate
through dnode blocks may no longer use a simple array indexing
scheme. These now use the current dnode's dn_num_slots field to
advance to the next dnode in the block. This is to ensure we
properly skip the current dnode's bonus area and don't interpret it
as a valid dnode.
zdb
---
The zdb command was updated to display a dnode's size under the
"dnsize" column when the object is dumped.
For ZIL create log records, zdb will now display the slot count for
the object.
ztest
-----
Ztest chooses a random dnodesize for every newly created object. The
random distribution is more heavily weighted toward small dnodes to
better simulate real-world datasets.
Unused bonus buffer space is filled with non-zero values computed from
the object number, dataset id, offset, and generation number. This
helps ensure that the dnode traversal code properly skips the interior
regions of large dnodes, and that these interior regions are not
overwritten by data belonging to other dnodes. A new test visits each
object in a dataset. It verifies that the actual dnode size matches what
was stored in the ztest block tag when it was created. It also verifies
that the unused bonus buffer space is filled with the expected data
patterns.
ZFS Test Suite
--------------
Added six new large dnode-specific tests, and integrated the dnodesize
property into existing tests for zfs allow and send/recv.
Send/Receive
------------
ZFS send streams for datasets containing large dnodes cannot be received
on pools that don't support the large_dnode feature. A send stream with
large dnodes sets a DMU_BACKUP_FEATURE_LARGE_DNODE flag which will be
unrecognized by an incompatible receiving pool so that the zfs receive
will fail gracefully.
While not implemented here, it may be possible to generate a
backward-compatible send stream from a dataset containing large
dnodes. The implementation may be tricky, however, because the send
object record for a large dnode would need to be resized to a 512
byte dnode, possibly kicking in a spill block in the process. This
means we would need to construct a new SA layout and possibly
register it in the SA layout object. The SA layout is normally just
sent as an ordinary object record. But if we are constructing new
layouts while generating the send stream we'd have to build the SA
layout object dynamically and send it at the end of the stream.
For sending and receiving between pools that do support large dnodes,
the drr_object send record type is extended with a new field to store
the dnode slot count. This field was repurposed from unused padding
in the structure.
ZIL Replay
----------
The dnode slot count is stored in the uppermost 8 bits of the lr_foid
field. The bits were unused as the object id is currently capped at
48 bits.
Resizing Dnodes
---------------
It should be possible to resize a dnode when it is dirtied if the
current dnodesize dataset property differs from the dnode's size, but
this functionality is not currently implemented. Clearly a dnode can
only grow if there are sufficient contiguous unused slots in the
dnode block, but it should always be possible to shrink a dnode.
Growing dnodes may be useful to reduce fragmentation in a pool with
many spill blocks in use. Shrinking dnodes may be useful to allow
sending a dataset to a pool that doesn't support the large_dnode
feature.
Feature Reference Counting
--------------------------
The reference count for the large_dnode pool feature tracks the
number of datasets that have ever contained a dnode of size larger
than 512 bytes. The first time a large dnode is created in a dataset
the dataset is converted to an extensible dataset. This is a one-way
operation and the only way to decrement the feature count is to
destroy the dataset, even if the dataset no longer contains any large
dnodes. The complexity of reference counting on a per-dnode basis was
too high, so we chose to track it on a per-dataset basis similarly to
the large_block feature.
Signed-off-by: Ned Bass <bass6@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #3542
2016-03-17 01:25:34 +00:00
|
|
|
}
|
OpenZFS 6585 - sha512, skein, and edonr have an unenforced dependency on extensible dataset
Authored by: ilovezfs <ilovezfs@icloud.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Approved by: Robert Mustacchi <rm@joyent.com>
Ported by: Tony Hutter <hutter2@llnl.gov>
In any pool without the extensible dataset feature flag already enabled,
creating a dataset with dedup set to use one of the new checksums would
result in the following panic as soon as any data was added:
panic[cpu0]/thread=ffffff0006761c40: feature_get_refcount(spa, feature,
&refcount) != 48 (0x30 != 0x30), file: ../../common/fs/zfs/zfeature.c
line 390
Inpsection showed that feature->fi_feature was 7, which is the value of
SPA_FEATURE_EXTENSIBLE_DATASET in the spa_feature enum. This commit
adds extensible dataset as a dependency for the sha512, edonr, and skein
feature flags, which prevents the panic.
OpenZFS-issue: https://www.illumos.org/issues/6585
OpenZFS-commit: https://github.com/illumos/illumos-gate/commit/892586e8a147c02d7f4053cc405229a13e796928
Porting Notes:
This code was originally from Illumos, but I actually ported it from:
openzfsonosx/zfs@b62a652
2016-01-28 12:51:19 +00:00
|
|
|
|
|
|
|
{
|
|
|
|
static const spa_feature_t sha512_deps[] = {
|
|
|
|
SPA_FEATURE_EXTENSIBLE_DATASET,
|
|
|
|
SPA_FEATURE_NONE
|
|
|
|
};
|
2016-06-15 22:47:05 +00:00
|
|
|
zfeature_register(SPA_FEATURE_SHA512,
|
|
|
|
"org.illumos:sha512", "sha512",
|
|
|
|
"SHA-512/256 hash algorithm.",
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_FLAG_PER_DATASET, ZFEATURE_TYPE_BOOLEAN,
|
|
|
|
sha512_deps);
|
OpenZFS 6585 - sha512, skein, and edonr have an unenforced dependency on extensible dataset
Authored by: ilovezfs <ilovezfs@icloud.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Approved by: Robert Mustacchi <rm@joyent.com>
Ported by: Tony Hutter <hutter2@llnl.gov>
In any pool without the extensible dataset feature flag already enabled,
creating a dataset with dedup set to use one of the new checksums would
result in the following panic as soon as any data was added:
panic[cpu0]/thread=ffffff0006761c40: feature_get_refcount(spa, feature,
&refcount) != 48 (0x30 != 0x30), file: ../../common/fs/zfs/zfeature.c
line 390
Inpsection showed that feature->fi_feature was 7, which is the value of
SPA_FEATURE_EXTENSIBLE_DATASET in the spa_feature enum. This commit
adds extensible dataset as a dependency for the sha512, edonr, and skein
feature flags, which prevents the panic.
OpenZFS-issue: https://www.illumos.org/issues/6585
OpenZFS-commit: https://github.com/illumos/illumos-gate/commit/892586e8a147c02d7f4053cc405229a13e796928
Porting Notes:
This code was originally from Illumos, but I actually ported it from:
openzfsonosx/zfs@b62a652
2016-01-28 12:51:19 +00:00
|
|
|
}
|
2018-10-16 18:15:04 +00:00
|
|
|
|
OpenZFS 6585 - sha512, skein, and edonr have an unenforced dependency on extensible dataset
Authored by: ilovezfs <ilovezfs@icloud.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Approved by: Robert Mustacchi <rm@joyent.com>
Ported by: Tony Hutter <hutter2@llnl.gov>
In any pool without the extensible dataset feature flag already enabled,
creating a dataset with dedup set to use one of the new checksums would
result in the following panic as soon as any data was added:
panic[cpu0]/thread=ffffff0006761c40: feature_get_refcount(spa, feature,
&refcount) != 48 (0x30 != 0x30), file: ../../common/fs/zfs/zfeature.c
line 390
Inpsection showed that feature->fi_feature was 7, which is the value of
SPA_FEATURE_EXTENSIBLE_DATASET in the spa_feature enum. This commit
adds extensible dataset as a dependency for the sha512, edonr, and skein
feature flags, which prevents the panic.
OpenZFS-issue: https://www.illumos.org/issues/6585
OpenZFS-commit: https://github.com/illumos/illumos-gate/commit/892586e8a147c02d7f4053cc405229a13e796928
Porting Notes:
This code was originally from Illumos, but I actually ported it from:
openzfsonosx/zfs@b62a652
2016-01-28 12:51:19 +00:00
|
|
|
{
|
|
|
|
static const spa_feature_t skein_deps[] = {
|
|
|
|
SPA_FEATURE_EXTENSIBLE_DATASET,
|
|
|
|
SPA_FEATURE_NONE
|
|
|
|
};
|
2016-06-15 22:47:05 +00:00
|
|
|
zfeature_register(SPA_FEATURE_SKEIN,
|
|
|
|
"org.illumos:skein", "skein",
|
|
|
|
"Skein hash algorithm.",
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_FLAG_PER_DATASET, ZFEATURE_TYPE_BOOLEAN,
|
|
|
|
skein_deps);
|
OpenZFS 6585 - sha512, skein, and edonr have an unenforced dependency on extensible dataset
Authored by: ilovezfs <ilovezfs@icloud.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Approved by: Robert Mustacchi <rm@joyent.com>
Ported by: Tony Hutter <hutter2@llnl.gov>
In any pool without the extensible dataset feature flag already enabled,
creating a dataset with dedup set to use one of the new checksums would
result in the following panic as soon as any data was added:
panic[cpu0]/thread=ffffff0006761c40: feature_get_refcount(spa, feature,
&refcount) != 48 (0x30 != 0x30), file: ../../common/fs/zfs/zfeature.c
line 390
Inpsection showed that feature->fi_feature was 7, which is the value of
SPA_FEATURE_EXTENSIBLE_DATASET in the spa_feature enum. This commit
adds extensible dataset as a dependency for the sha512, edonr, and skein
feature flags, which prevents the panic.
OpenZFS-issue: https://www.illumos.org/issues/6585
OpenZFS-commit: https://github.com/illumos/illumos-gate/commit/892586e8a147c02d7f4053cc405229a13e796928
Porting Notes:
This code was originally from Illumos, but I actually ported it from:
openzfsonosx/zfs@b62a652
2016-01-28 12:51:19 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
{
|
|
|
|
static const spa_feature_t edonr_deps[] = {
|
|
|
|
SPA_FEATURE_EXTENSIBLE_DATASET,
|
|
|
|
SPA_FEATURE_NONE
|
|
|
|
};
|
2016-06-15 22:47:05 +00:00
|
|
|
zfeature_register(SPA_FEATURE_EDONR,
|
|
|
|
"org.illumos:edonr", "edonr",
|
|
|
|
"Edon-R hash algorithm.",
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_FLAG_PER_DATASET, ZFEATURE_TYPE_BOOLEAN,
|
|
|
|
edonr_deps);
|
OpenZFS 6585 - sha512, skein, and edonr have an unenforced dependency on extensible dataset
Authored by: ilovezfs <ilovezfs@icloud.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Approved by: Robert Mustacchi <rm@joyent.com>
Ported by: Tony Hutter <hutter2@llnl.gov>
In any pool without the extensible dataset feature flag already enabled,
creating a dataset with dedup set to use one of the new checksums would
result in the following panic as soon as any data was added:
panic[cpu0]/thread=ffffff0006761c40: feature_get_refcount(spa, feature,
&refcount) != 48 (0x30 != 0x30), file: ../../common/fs/zfs/zfeature.c
line 390
Inpsection showed that feature->fi_feature was 7, which is the value of
SPA_FEATURE_EXTENSIBLE_DATASET in the spa_feature enum. This commit
adds extensible dataset as a dependency for the sha512, edonr, and skein
feature flags, which prevents the panic.
OpenZFS-issue: https://www.illumos.org/issues/6585
OpenZFS-commit: https://github.com/illumos/illumos-gate/commit/892586e8a147c02d7f4053cc405229a13e796928
Porting Notes:
This code was originally from Illumos, but I actually ported it from:
openzfsonosx/zfs@b62a652
2016-01-28 12:51:19 +00:00
|
|
|
}
|
2018-10-16 18:15:04 +00:00
|
|
|
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 16:30:13 +00:00
|
|
|
zfeature_register(SPA_FEATURE_DEVICE_REMOVAL,
|
|
|
|
"com.delphix:device_removal", "device_removal",
|
|
|
|
"Top-level vdevs can be removed, reducing logical pool size.",
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_FLAG_MOS, ZFEATURE_TYPE_BOOLEAN, NULL);
|
|
|
|
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 16:30:13 +00:00
|
|
|
{
|
|
|
|
static const spa_feature_t obsolete_counts_deps[] = {
|
|
|
|
SPA_FEATURE_EXTENSIBLE_DATASET,
|
|
|
|
SPA_FEATURE_DEVICE_REMOVAL,
|
|
|
|
SPA_FEATURE_NONE
|
|
|
|
};
|
|
|
|
zfeature_register(SPA_FEATURE_OBSOLETE_COUNTS,
|
|
|
|
"com.delphix:obsolete_counts", "obsolete_counts",
|
|
|
|
"Reduce memory used by removed devices when their blocks are "
|
|
|
|
"freed or remapped.",
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_FLAG_READONLY_COMPAT, ZFEATURE_TYPE_BOOLEAN,
|
|
|
|
obsolete_counts_deps);
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 16:30:13 +00:00
|
|
|
}
|
2018-10-16 18:15:04 +00:00
|
|
|
|
2016-10-04 18:46:10 +00:00
|
|
|
{
|
|
|
|
static const spa_feature_t userobj_accounting_deps[] = {
|
|
|
|
SPA_FEATURE_EXTENSIBLE_DATASET,
|
|
|
|
SPA_FEATURE_NONE
|
|
|
|
};
|
|
|
|
zfeature_register(SPA_FEATURE_USEROBJ_ACCOUNTING,
|
|
|
|
"org.zfsonlinux:userobj_accounting", "userobj_accounting",
|
|
|
|
"User/Group object accounting.",
|
|
|
|
ZFEATURE_FLAG_READONLY_COMPAT | ZFEATURE_FLAG_PER_DATASET,
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_TYPE_BOOLEAN, userobj_accounting_deps);
|
2016-10-04 18:46:10 +00:00
|
|
|
}
|
Native Encryption for ZFS on Linux
This change incorporates three major pieces:
The first change is a keystore that manages wrapping
and encryption keys for encrypted datasets. These
commands mostly involve manipulating the new
DSL Crypto Key ZAP Objects that live in the MOS. Each
encrypted dataset has its own DSL Crypto Key that is
protected with a user's key. This level of indirection
allows users to change their keys without re-encrypting
their entire datasets. The change implements the new
subcommands "zfs load-key", "zfs unload-key" and
"zfs change-key" which allow the user to manage their
encryption keys and settings. In addition, several new
flags and properties have been added to allow dataset
creation and to make mounting and unmounting more
convenient.
The second piece of this patch provides the ability to
encrypt, decyrpt, and authenticate protected datasets.
Each object set maintains a Merkel tree of Message
Authentication Codes that protect the lower layers,
similarly to how checksums are maintained. This part
impacts the zio layer, which handles the actual
encryption and generation of MACs, as well as the ARC
and DMU, which need to be able to handle encrypted
buffers and protected data.
The last addition is the ability to do raw, encrypted
sends and receives. The idea here is to send raw
encrypted and compressed data and receive it exactly
as is on a backup system. This means that the dataset
on the receiving system is protected using the same
user key that is in use on the sending side. By doing
so, datasets can be efficiently backed up to an
untrusted system without fear of data being
compromised.
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Jorgen Lundman <lundman@lundman.net>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes #494
Closes #5769
2017-08-14 17:36:48 +00:00
|
|
|
|
|
|
|
{
|
|
|
|
static const spa_feature_t encryption_deps[] = {
|
|
|
|
SPA_FEATURE_EXTENSIBLE_DATASET,
|
|
|
|
SPA_FEATURE_NONE
|
|
|
|
};
|
|
|
|
zfeature_register(SPA_FEATURE_ENCRYPTION,
|
|
|
|
"com.datto:encryption", "encryption",
|
|
|
|
"Support for dataset level encryption",
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_FLAG_PER_DATASET, ZFEATURE_TYPE_BOOLEAN,
|
|
|
|
encryption_deps);
|
Native Encryption for ZFS on Linux
This change incorporates three major pieces:
The first change is a keystore that manages wrapping
and encryption keys for encrypted datasets. These
commands mostly involve manipulating the new
DSL Crypto Key ZAP Objects that live in the MOS. Each
encrypted dataset has its own DSL Crypto Key that is
protected with a user's key. This level of indirection
allows users to change their keys without re-encrypting
their entire datasets. The change implements the new
subcommands "zfs load-key", "zfs unload-key" and
"zfs change-key" which allow the user to manage their
encryption keys and settings. In addition, several new
flags and properties have been added to allow dataset
creation and to make mounting and unmounting more
convenient.
The second piece of this patch provides the ability to
encrypt, decyrpt, and authenticate protected datasets.
Each object set maintains a Merkel tree of Message
Authentication Codes that protect the lower layers,
similarly to how checksums are maintained. This part
impacts the zio layer, which handles the actual
encryption and generation of MACs, as well as the ARC
and DMU, which need to be able to handle encrypted
buffers and protected data.
The last addition is the ability to do raw, encrypted
sends and receives. The idea here is to send raw
encrypted and compressed data and receive it exactly
as is on a backup system. This means that the dataset
on the receiving system is protected using the same
user key that is in use on the sending side. By doing
so, datasets can be efficiently backed up to an
untrusted system without fear of data being
compromised.
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Jorgen Lundman <lundman@lundman.net>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes #494
Closes #5769
2017-08-14 17:36:48 +00:00
|
|
|
}
|
2018-02-13 22:54:54 +00:00
|
|
|
|
|
|
|
{
|
|
|
|
static const spa_feature_t project_quota_deps[] = {
|
|
|
|
SPA_FEATURE_EXTENSIBLE_DATASET,
|
|
|
|
SPA_FEATURE_NONE
|
|
|
|
};
|
|
|
|
zfeature_register(SPA_FEATURE_PROJECT_QUOTA,
|
|
|
|
"org.zfsonlinux:project_quota", "project_quota",
|
|
|
|
"space/object accounting based on project ID.",
|
|
|
|
ZFEATURE_FLAG_READONLY_COMPAT | ZFEATURE_FLAG_PER_DATASET,
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_TYPE_BOOLEAN, project_quota_deps);
|
2018-02-13 22:54:54 +00:00
|
|
|
}
|
2018-09-06 01:33:36 +00:00
|
|
|
|
|
|
|
{
|
|
|
|
zfeature_register(SPA_FEATURE_ALLOCATION_CLASSES,
|
|
|
|
"org.zfsonlinux:allocation_classes", "allocation_classes",
|
|
|
|
"Support for separate allocation classes.",
|
2018-10-16 18:15:04 +00:00
|
|
|
ZFEATURE_FLAG_READONLY_COMPAT, ZFEATURE_TYPE_BOOLEAN, NULL);
|
2018-09-06 01:33:36 +00:00
|
|
|
}
|
2012-12-13 23:24:15 +00:00
|
|
|
}
|
2017-08-09 22:31:08 +00:00
|
|
|
|
2018-02-16 01:53:18 +00:00
|
|
|
#if defined(_KERNEL)
|
2018-09-02 19:09:53 +00:00
|
|
|
EXPORT_SYMBOL(zfeature_lookup_guid);
|
2017-08-09 22:31:08 +00:00
|
|
|
EXPORT_SYMBOL(zfeature_lookup_name);
|
|
|
|
EXPORT_SYMBOL(zfeature_is_supported);
|
|
|
|
EXPORT_SYMBOL(zfeature_is_valid_guid);
|
|
|
|
EXPORT_SYMBOL(zfeature_depends_on);
|
|
|
|
EXPORT_SYMBOL(zpool_feature_init);
|
|
|
|
EXPORT_SYMBOL(spa_feature_table);
|
|
|
|
#endif
|