2017-10-04 16:33:43 +00:00
|
|
|
/*
|
2010-05-17 22:18:00 +00:00
|
|
|
* Copyright (C) 2007-2010 Lawrence Livermore National Security, LLC.
|
|
|
|
* Copyright (C) 2007 The Regents of the University of California.
|
|
|
|
* Produced at Lawrence Livermore National Laboratory (cf, DISCLAIMER).
|
|
|
|
* Written by Brian Behlendorf <behlendorf1@llnl.gov>.
|
2008-05-26 04:38:26 +00:00
|
|
|
* UCRL-CODE-235197
|
|
|
|
*
|
2010-05-17 22:18:00 +00:00
|
|
|
* This file is part of the SPL, Solaris Porting Layer.
|
2008-05-26 04:38:26 +00:00
|
|
|
*
|
2010-05-17 22:18:00 +00:00
|
|
|
* The SPL is free software; you can redistribute it and/or modify it
|
|
|
|
* under the terms of the GNU General Public License as published by the
|
|
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
|
|
* option) any later version.
|
|
|
|
*
|
|
|
|
* The SPL is distributed in the hope that it will be useful, but WITHOUT
|
2008-05-26 04:38:26 +00:00
|
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
|
|
|
* for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License along
|
2010-05-17 22:18:00 +00:00
|
|
|
* with the SPL. If not, see <http://www.gnu.org/licenses/>.
|
2018-02-07 19:49:38 +00:00
|
|
|
*
|
2010-05-17 22:18:00 +00:00
|
|
|
* Solaris Porting Layer (SPL) Thread Implementation.
|
2017-10-04 16:33:43 +00:00
|
|
|
*/
|
2008-05-26 04:38:26 +00:00
|
|
|
|
2008-03-01 00:45:59 +00:00
|
|
|
#include <sys/thread.h>
|
2008-04-11 17:03:57 +00:00
|
|
|
#include <sys/kmem.h>
|
2010-11-30 17:51:46 +00:00
|
|
|
#include <sys/tsd.h>
|
2024-01-23 05:34:49 +00:00
|
|
|
#include <sys/string.h>
|
2008-04-21 17:29:47 +00:00
|
|
|
|
2008-02-26 20:36:04 +00:00
|
|
|
/*
|
|
|
|
* Thread interfaces
|
|
|
|
*/
|
|
|
|
typedef struct thread_priv_s {
|
|
|
|
unsigned long tp_magic; /* Magic */
|
2018-02-07 19:49:38 +00:00
|
|
|
int tp_name_size; /* Name size */
|
|
|
|
char *tp_name; /* Name (without _thread suffix) */
|
2008-02-26 20:36:04 +00:00
|
|
|
void (*tp_func)(void *); /* Registered function */
|
|
|
|
void *tp_args; /* Args to be passed to function */
|
|
|
|
size_t tp_len; /* Len to be passed to function */
|
|
|
|
int tp_state; /* State to start thread at */
|
|
|
|
pri_t tp_pri; /* Priority to start threat at */
|
|
|
|
} thread_priv_t;
|
|
|
|
|
2008-02-27 19:09:51 +00:00
|
|
|
static int
|
2008-02-26 20:36:04 +00:00
|
|
|
thread_generic_wrapper(void *arg)
|
|
|
|
{
|
|
|
|
thread_priv_t *tp = (thread_priv_t *)arg;
|
|
|
|
void (*func)(void *);
|
|
|
|
void *args;
|
|
|
|
|
2008-04-21 17:29:47 +00:00
|
|
|
ASSERT(tp->tp_magic == TP_MAGIC);
|
2008-02-26 20:36:04 +00:00
|
|
|
func = tp->tp_func;
|
|
|
|
args = tp->tp_args;
|
|
|
|
set_current_state(tp->tp_state);
|
2012-06-29 18:54:52 +00:00
|
|
|
set_user_nice((kthread_t *)current, PRIO_TO_NICE(tp->tp_pri));
|
2008-05-12 18:54:08 +00:00
|
|
|
kmem_free(tp->tp_name, tp->tp_name_size);
|
2018-02-07 19:49:38 +00:00
|
|
|
kmem_free(tp, sizeof (thread_priv_t));
|
2008-02-26 20:36:04 +00:00
|
|
|
|
|
|
|
if (func)
|
|
|
|
func(args);
|
|
|
|
|
2018-02-07 19:49:38 +00:00
|
|
|
return (0);
|
2008-02-26 20:36:04 +00:00
|
|
|
}
|
|
|
|
|
2018-02-07 19:49:38 +00:00
|
|
|
/*
|
|
|
|
* thread_create() may block forever if it cannot create a thread or
|
2008-02-26 20:36:04 +00:00
|
|
|
* allocate memory. This is preferable to returning a NULL which Solaris
|
2018-02-07 19:49:38 +00:00
|
|
|
* style callers likely never check for... since it can't fail.
|
|
|
|
*/
|
2008-02-26 20:36:04 +00:00
|
|
|
kthread_t *
|
2008-03-10 19:25:20 +00:00
|
|
|
__thread_create(caddr_t stk, size_t stksize, thread_func_t func,
|
2018-02-24 18:05:37 +00:00
|
|
|
const char *name, void *args, size_t len, proc_t *pp, int state, pri_t pri)
|
2008-02-26 20:36:04 +00:00
|
|
|
{
|
2008-04-11 17:03:57 +00:00
|
|
|
thread_priv_t *tp;
|
2008-04-04 04:44:16 +00:00
|
|
|
struct task_struct *tsk;
|
2008-05-12 18:54:08 +00:00
|
|
|
char *p;
|
2008-02-26 20:36:04 +00:00
|
|
|
|
|
|
|
/* Option pp is simply ignored */
|
|
|
|
/* Variable stack size unsupported */
|
2008-04-21 17:29:47 +00:00
|
|
|
ASSERT(stk == NULL);
|
2008-02-26 20:36:04 +00:00
|
|
|
|
2018-02-07 19:49:38 +00:00
|
|
|
tp = kmem_alloc(sizeof (thread_priv_t), KM_PUSHPAGE);
|
2008-04-11 17:03:57 +00:00
|
|
|
if (tp == NULL)
|
2014-11-05 22:30:35 +00:00
|
|
|
return (NULL);
|
2008-02-26 20:36:04 +00:00
|
|
|
|
2008-04-11 17:03:57 +00:00
|
|
|
tp->tp_magic = TP_MAGIC;
|
2008-05-12 18:54:08 +00:00
|
|
|
tp->tp_name_size = strlen(name) + 1;
|
|
|
|
|
2012-09-12 19:24:41 +00:00
|
|
|
tp->tp_name = kmem_alloc(tp->tp_name_size, KM_PUSHPAGE);
|
2018-02-07 19:49:38 +00:00
|
|
|
if (tp->tp_name == NULL) {
|
|
|
|
kmem_free(tp, sizeof (thread_priv_t));
|
2014-11-05 22:30:35 +00:00
|
|
|
return (NULL);
|
2008-05-12 18:54:08 +00:00
|
|
|
}
|
|
|
|
|
Cleanup: Switch to strlcpy from strncpy
Coverity found a bug in `zfs_secpolicy_create_clone()` where it is
possible for us to pass an unterminated string when `zfs_get_parent()`
returns an error. Upon inspection, it is clear that using `strlcpy()`
would have avoided this issue.
Looking at the codebase, there are a number of other uses of `strncpy()`
that are unsafe and even when it is used safely, switching to
`strlcpy()` would make the code more readable. Therefore, we switch all
instances where we use `strncpy()` to use `strlcpy()`.
Unfortunately, we do not portably have access to `strlcpy()` in
tests/zfs-tests/cmd/zfs_diff-socket.c because it does not link to
libspl. Modifying the appropriate Makefile.am to try to link to it
resulted in an error from the naming choice used in the file. Trying to
disable the check on the file did not work on FreeBSD because Clang
ignores `#undef` when a definition is provided by `-Dstrncpy(...)=...`.
We workaround that by explictly including the C file from libspl into
the test. This makes things build correctly everywhere.
We add a deprecation warning to `config/Rules.am` and suppress it on the
remaining `strncpy()` usage. `strlcpy()` is not portably avaliable in
tests/zfs-tests/cmd/zfs_diff-socket.c, so we use `snprintf()` there as a
substitute.
This patch does not tackle the related problem of `strcpy()`, which is
even less safe. Thankfully, a quick inspection found that it is used far
more correctly than strncpy() was used. A quick inspection did not find
any problems with `strcpy()` usage outside of zhack, but it should be
said that I only checked around 90% of them.
Lastly, some of the fields in kstat_t varied in size by 1 depending on
whether they were in userspace or in the kernel. The origin of this
discrepancy appears to be 04a479f7066ccdaa23a6546955303b172f4a6909 where
it was made for no apparent reason. It conflicts with the comment on
KSTAT_STRLEN, so we shrink the kernel field sizes to match the userspace
field sizes.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13876
2022-09-27 23:35:29 +00:00
|
|
|
strlcpy(tp->tp_name, name, tp->tp_name_size);
|
2008-05-12 18:54:08 +00:00
|
|
|
|
2018-02-07 19:49:38 +00:00
|
|
|
/*
|
|
|
|
* Strip trailing "_thread" from passed name which will be the func
|
2008-05-12 18:54:08 +00:00
|
|
|
* name since the exposed API has no parameter for passing a name.
|
|
|
|
*/
|
|
|
|
p = strstr(tp->tp_name, "_thread");
|
|
|
|
if (p)
|
|
|
|
p[0] = '\0';
|
|
|
|
|
2008-04-11 17:03:57 +00:00
|
|
|
tp->tp_func = func;
|
|
|
|
tp->tp_args = args;
|
|
|
|
tp->tp_len = len;
|
|
|
|
tp->tp_state = state;
|
|
|
|
tp->tp_pri = pri;
|
2008-02-26 20:36:04 +00:00
|
|
|
|
2014-03-26 13:29:24 +00:00
|
|
|
tsk = spl_kthread_create(thread_generic_wrapper, (void *)tp,
|
2018-02-07 19:49:38 +00:00
|
|
|
"%s", tp->tp_name);
|
2014-11-05 22:30:35 +00:00
|
|
|
if (IS_ERR(tsk))
|
|
|
|
return (NULL);
|
2008-04-04 04:44:16 +00:00
|
|
|
|
|
|
|
wake_up_process(tsk);
|
2014-11-05 22:30:35 +00:00
|
|
|
return ((kthread_t *)tsk);
|
2008-02-26 20:36:04 +00:00
|
|
|
}
|
2008-02-27 19:09:51 +00:00
|
|
|
EXPORT_SYMBOL(__thread_create);
|
2014-04-09 18:40:12 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* spl_kthread_create - Wrapper providing pre-3.13 semantics for
|
|
|
|
* kthread_create() in which it is not killable and less likely
|
|
|
|
* to return -ENOMEM.
|
|
|
|
*/
|
|
|
|
struct task_struct *
|
|
|
|
spl_kthread_create(int (*func)(void *), void *data, const char namefmt[], ...)
|
|
|
|
{
|
|
|
|
struct task_struct *tsk;
|
|
|
|
va_list args;
|
2014-04-11 13:55:10 +00:00
|
|
|
char name[TASK_COMM_LEN];
|
2014-04-09 18:40:12 +00:00
|
|
|
|
|
|
|
va_start(args, namefmt);
|
2018-02-07 19:49:38 +00:00
|
|
|
vsnprintf(name, sizeof (name), namefmt, args);
|
2014-04-11 13:55:10 +00:00
|
|
|
va_end(args);
|
2014-04-09 18:40:12 +00:00
|
|
|
do {
|
2014-04-11 13:55:10 +00:00
|
|
|
tsk = kthread_create(func, data, "%s", name);
|
2014-04-09 18:40:12 +00:00
|
|
|
if (IS_ERR(tsk)) {
|
|
|
|
if (signal_pending(current)) {
|
|
|
|
clear_thread_flag(TIF_SIGPENDING);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if (PTR_ERR(tsk) == -ENOMEM)
|
|
|
|
continue;
|
|
|
|
return (NULL);
|
2019-07-17 00:22:31 +00:00
|
|
|
} else {
|
2014-04-09 18:40:12 +00:00
|
|
|
return (tsk);
|
2019-07-17 00:22:31 +00:00
|
|
|
}
|
2014-04-09 18:40:12 +00:00
|
|
|
} while (1);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(spl_kthread_create);
|
2021-04-15 20:34:35 +00:00
|
|
|
|
|
|
|
/*
|
2024-05-29 17:49:11 +00:00
|
|
|
* Extract the next pending signal from p_sig into p_cursig; stop the process
|
|
|
|
* if a stop has been requested or if a traced signal is pending.
|
2021-04-15 20:34:35 +00:00
|
|
|
*/
|
|
|
|
int
|
2024-05-29 17:49:11 +00:00
|
|
|
issig(void)
|
2021-04-15 20:34:35 +00:00
|
|
|
{
|
|
|
|
|
|
|
|
if (!signal_pending(current))
|
|
|
|
return (0);
|
|
|
|
|
|
|
|
struct task_struct *task = current;
|
|
|
|
spl_kernel_siginfo_t __info;
|
|
|
|
sigset_t set;
|
|
|
|
siginitsetinv(&set, 1ULL << (SIGSTOP - 1) | 1ULL << (SIGTSTP - 1));
|
|
|
|
sigorsets(&set, &task->blocked, &set);
|
|
|
|
|
|
|
|
spin_lock_irq(&task->sighand->siglock);
|
2022-01-19 20:33:50 +00:00
|
|
|
#ifdef HAVE_DEQUEUE_SIGNAL_4ARG
|
|
|
|
enum pid_type __type;
|
Cleanup of dead code suggested by Clang Static Analyzer (#14380)
I recently gained the ability to run Clang's static analyzer on the
linux kernel modules via a few hacks. This extended coverage to code
that was previously missed since Clang's static analyzer only looked at
code that we built in userspace. Running it against the Linux kernel
modules built from my local branch produced a total of 72 reports
against my local branch. Of those, 50 were reports of logic errors and
22 were reports of dead code. Since we already had cleaned up all of
the previous dead code reports, I felt it would be a good next step to
clean up these dead code reports. Clang did a further breakdown of the
dead code reports into:
Dead assignment 15
Dead increment 2
Dead nested assignment 5
The benefit of cleaning these up, especially in the case of dead nested
assignment, is that they can expose places where our error handling is
incorrect. A number of them were fairly straight forward. However
several were not:
In vdev_disk_physio_completion(), not only were we not using the return
value from the static function vdev_disk_dio_put(), but nothing used it,
so I changed it to return void and removed the existing (void) cast in
the other area where we call it in addition to no longer storing it to a
stack value.
In FSE_createDTable(), the function is dead code. Its helper function
FSE_freeDTable() is also dead code, as are the CPP definitions in
`module/zstd/include/zstd_compat_wrapper.h`. We just delete it all.
In zfs_zevent_wait(), we have an optimization opportunity. cv_wait_sig()
returns 0 if there are waiting signals and 1 if there are none. The
Linux SPL version literally returns `signal_pending(current) ? 0 : 1)`
and FreeBSD implements the same semantics, we can just do
`!cv_wait_sig()` in place of `signal_pending(current)` to avoid
unnecessarily calling it again.
zfs_setattr() on FreeBSD version did not have error handling issue
because the code was removed entirely from FreeBSD version. The error is
from updating the attribute directory's files. After some thought, I
decided to propapage errors on it to userspace.
In zfs_secpolicy_tmp_snapshot(), we ignore a lack of permission from the
first check in favor of checking three other permissions. I assume this
is intentional.
In zfs_create_fs(), the return value of zap_update() was not checked
despite setting an important version number. I see no backward
compatibility reason to permit failures, so we add an assertion to catch
failures. Interestingly, Linux is still using ASSERT(error == 0) from
OpenSolaris while FreeBSD has switched to the improved ASSERT0(error)
from illumos, although illumos has yet to adopt it here. ASSERT(error ==
0) was used on Linux while ASSERT0(error) was used on FreeBSD since the
entire file needs conversion and that should be the subject of
another patch.
dnode_move()'s issue was caused by us not having implemented
POINTER_IS_VALID() on Linux. We have a stub in
`include/os/linux/spl/sys/kmem_cache.h` for it, when it really should be
in `include/os/linux/spl/sys/kmem.h` to be consistent with
Illumos/OpenSolaris. FreeBSD put both `POINTER_IS_VALID()` and
`POINTER_INVALIDATE()` in `include/os/freebsd/spl/sys/kmem.h`, so we
copy what it did.
Whenever a report was in platform-specific code, I checked the FreeBSD
version to see if it also applied to FreeBSD, but it was only relevant a
few times.
Lastly, the patch that enabled Clang's static analyzer to be run on the
Linux kernel modules needs more work before it can be put into a PR. I
plan to do that in the future as part of the on-going static analysis
work that I am doing.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #14380
2023-01-17 17:57:12 +00:00
|
|
|
if (dequeue_signal(task, &set, &__info, &__type) != 0) {
|
2022-01-19 20:33:50 +00:00
|
|
|
#else
|
Cleanup of dead code suggested by Clang Static Analyzer (#14380)
I recently gained the ability to run Clang's static analyzer on the
linux kernel modules via a few hacks. This extended coverage to code
that was previously missed since Clang's static analyzer only looked at
code that we built in userspace. Running it against the Linux kernel
modules built from my local branch produced a total of 72 reports
against my local branch. Of those, 50 were reports of logic errors and
22 were reports of dead code. Since we already had cleaned up all of
the previous dead code reports, I felt it would be a good next step to
clean up these dead code reports. Clang did a further breakdown of the
dead code reports into:
Dead assignment 15
Dead increment 2
Dead nested assignment 5
The benefit of cleaning these up, especially in the case of dead nested
assignment, is that they can expose places where our error handling is
incorrect. A number of them were fairly straight forward. However
several were not:
In vdev_disk_physio_completion(), not only were we not using the return
value from the static function vdev_disk_dio_put(), but nothing used it,
so I changed it to return void and removed the existing (void) cast in
the other area where we call it in addition to no longer storing it to a
stack value.
In FSE_createDTable(), the function is dead code. Its helper function
FSE_freeDTable() is also dead code, as are the CPP definitions in
`module/zstd/include/zstd_compat_wrapper.h`. We just delete it all.
In zfs_zevent_wait(), we have an optimization opportunity. cv_wait_sig()
returns 0 if there are waiting signals and 1 if there are none. The
Linux SPL version literally returns `signal_pending(current) ? 0 : 1)`
and FreeBSD implements the same semantics, we can just do
`!cv_wait_sig()` in place of `signal_pending(current)` to avoid
unnecessarily calling it again.
zfs_setattr() on FreeBSD version did not have error handling issue
because the code was removed entirely from FreeBSD version. The error is
from updating the attribute directory's files. After some thought, I
decided to propapage errors on it to userspace.
In zfs_secpolicy_tmp_snapshot(), we ignore a lack of permission from the
first check in favor of checking three other permissions. I assume this
is intentional.
In zfs_create_fs(), the return value of zap_update() was not checked
despite setting an important version number. I see no backward
compatibility reason to permit failures, so we add an assertion to catch
failures. Interestingly, Linux is still using ASSERT(error == 0) from
OpenSolaris while FreeBSD has switched to the improved ASSERT0(error)
from illumos, although illumos has yet to adopt it here. ASSERT(error ==
0) was used on Linux while ASSERT0(error) was used on FreeBSD since the
entire file needs conversion and that should be the subject of
another patch.
dnode_move()'s issue was caused by us not having implemented
POINTER_IS_VALID() on Linux. We have a stub in
`include/os/linux/spl/sys/kmem_cache.h` for it, when it really should be
in `include/os/linux/spl/sys/kmem.h` to be consistent with
Illumos/OpenSolaris. FreeBSD put both `POINTER_IS_VALID()` and
`POINTER_INVALIDATE()` in `include/os/freebsd/spl/sys/kmem.h`, so we
copy what it did.
Whenever a report was in platform-specific code, I checked the FreeBSD
version to see if it also applied to FreeBSD, but it was only relevant a
few times.
Lastly, the patch that enabled Clang's static analyzer to be run on the
Linux kernel modules needs more work before it can be put into a PR. I
plan to do that in the future as part of the on-going static analysis
work that I am doing.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #14380
2023-01-17 17:57:12 +00:00
|
|
|
if (dequeue_signal(task, &set, &__info) != 0) {
|
2022-01-19 20:33:50 +00:00
|
|
|
#endif
|
2021-04-15 20:34:35 +00:00
|
|
|
#ifdef HAVE_SIGNAL_STOP
|
|
|
|
spin_unlock_irq(&task->sighand->siglock);
|
|
|
|
kernel_signal_stop();
|
|
|
|
#else
|
|
|
|
if (current->jobctl & JOBCTL_STOP_DEQUEUED)
|
|
|
|
spl_set_special_state(TASK_STOPPED);
|
|
|
|
|
|
|
|
spin_unlock_irq(¤t->sighand->siglock);
|
|
|
|
|
|
|
|
schedule();
|
|
|
|
#endif
|
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
|
|
|
spin_unlock_irq(&task->sighand->siglock);
|
|
|
|
|
|
|
|
return (1);
|
|
|
|
}
|
|
|
|
|
|
|
|
EXPORT_SYMBOL(issig);
|