dracut: use /bin/sh instead of bash as the intepreter
Despite that dracut has a hard dependency on bash,
its modules doesn't, dracut only has a hard dependency on bash for
module-setup (on a fully usable machine). Inside initramfs, dracut
allows users choose from a list of handful other shells, e.g. bash,
busybox, dash, mkfsh.
In fact, my local machine's initramfs is being built with dash,
and it's functional for a very long time.
Before 64025fa3a (Silence 'make checkbashisms', 2020-08-20), we also
allows our users to have that right, too.
Let's fix the problem 'make checkbashisms' reported and allows our users
to have that right, again.
For 'plymouth' case, let's simply run the command inside the if instead
of checking for the existence of command before running it, because the
status is also failture if plymouth is unavailable.
While we're at it, let's remove an unnecessary fork for grep in
zfs-generator.sh.in and its following complicated 'if elif fi' with
a simple 'case ... esac'.
To support this change, also exclude 90zfs from "make checkbashisms"
because the current CI infrastructure ships an old version of
"checkbashisms", which complains about "command -v", while the current
latest "checkbashisms" thinks it's fine. In the near future, we can
revert that change to "Makefile.am" when CI infrastructure is updated.
Reviewed-by: Gabriel A. Devenyi <gdevenyi@gmail.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
Closes #11244
2020-11-28 19:02:08 +00:00
|
|
|
#!/bin/sh
|
2011-03-17 22:18:13 +00:00
|
|
|
|
2015-02-15 19:28:42 +00:00
|
|
|
. /lib/dracut-zfs-lib.sh
|
2011-03-17 22:18:13 +00:00
|
|
|
|
2015-02-15 19:28:42 +00:00
|
|
|
ZFS_DATASET=""
|
|
|
|
|
ZFS_POOL=""
|
2011-07-24 20:53:15 +00:00
|
|
|
|
2015-02-15 19:28:42 +00:00
|
|
|
case "${root}" in
|
|
|
|
|
zfs:*) ;;
|
|
|
|
|
*) return ;;
|
|
|
|
|
esac
|
2011-07-04 17:25:31 +00:00
|
|
|
|
Use a different technique to detect whether to mount-zfs
The behavior of the Dracut module was very wrong before.
The correct behavior: initramfs should not run `zfs-mount` to completion
if the two generator files exist. If, however, one of them is missing,
it indicates one of three cases:
* The kernel command line did not specify a root ZFS file system, and
another Dracut module is already handling root mount (via systemd).
`mount-zfs` can run, but it will do nothing.
* There is no systemd to run `sysroot.mount` to begin with.
`mount-zfs` must run.
* The root parameter is zfs:AUTO, which cannot be run in sysroot.mount.
`mount-zfs` must run.
In any of these three cases, it is safe to run `zfs-mount` to completion.
`zfs-mount` must also delete itself if it determines it should not run,
or else Dracut will do the insane thing of running it over and over again.
Literally, the definition of insanity, doing the same thing that did not
work before, expecting different results. Doing that may have had a great
result before, when we had a race between devices appearing and pools
being mounted, and `mount-zfs` was tasked with the full responsibility
of importing the needed pool, but nowadays it is wrong behavior and
should be suppressed.
I deduced that self-deletion was the correct thing to do by looking at
other Dracut code, because (as we all are very fully aware of) Dracut
is entirely, ahem, "implementation-defined".
Tested-by: @wphilips
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Manuel Amador (Rudd-O) <rudd-o@rudd-o.com>
Closes #5157
Closes #5204
2016-10-06 17:26:47 +00:00
|
|
|
GENERATOR_FILE=/run/systemd/generator/sysroot.mount
|
|
|
|
|
GENERATOR_EXTENSION=/run/systemd/generator/sysroot.mount.d/zfs-enhancement.conf
|
|
|
|
|
|
2018-02-22 01:54:54 +00:00
|
|
|
if [ -e "$GENERATOR_FILE" ] && [ -e "$GENERATOR_EXTENSION" ] ; then
|
Use a different technique to detect whether to mount-zfs
The behavior of the Dracut module was very wrong before.
The correct behavior: initramfs should not run `zfs-mount` to completion
if the two generator files exist. If, however, one of them is missing,
it indicates one of three cases:
* The kernel command line did not specify a root ZFS file system, and
another Dracut module is already handling root mount (via systemd).
`mount-zfs` can run, but it will do nothing.
* There is no systemd to run `sysroot.mount` to begin with.
`mount-zfs` must run.
* The root parameter is zfs:AUTO, which cannot be run in sysroot.mount.
`mount-zfs` must run.
In any of these three cases, it is safe to run `zfs-mount` to completion.
`zfs-mount` must also delete itself if it determines it should not run,
or else Dracut will do the insane thing of running it over and over again.
Literally, the definition of insanity, doing the same thing that did not
work before, expecting different results. Doing that may have had a great
result before, when we had a race between devices appearing and pools
being mounted, and `mount-zfs` was tasked with the full responsibility
of importing the needed pool, but nowadays it is wrong behavior and
should be suppressed.
I deduced that self-deletion was the correct thing to do by looking at
other Dracut code, because (as we all are very fully aware of) Dracut
is entirely, ahem, "implementation-defined".
Tested-by: @wphilips
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Manuel Amador (Rudd-O) <rudd-o@rudd-o.com>
Closes #5157
Closes #5204
2016-10-06 17:26:47 +00:00
|
|
|
# If the ZFS sysroot.mount flag exists, the initial RAM disk configured
|
|
|
|
|
# it to mount ZFS on root. In that case, we bail early. This flag
|
|
|
|
|
# file gets created by the zfs-generator program upon successful run.
|
|
|
|
|
info "ZFS: There is a sysroot.mount and zfs-generator has extended it."
|
|
|
|
|
info "ZFS: Delegating root mount to sysroot.mount."
|
|
|
|
|
# Let us tell the initrd to run on shutdown.
|
|
|
|
|
# We have a shutdown hook to run
|
|
|
|
|
# because we imported the pool.
|
|
|
|
|
# We now prevent Dracut from running this thing again.
|
|
|
|
|
for zfsmounthook in "$hookdir"/mount/*zfs* ; do
|
|
|
|
|
if [ -f "$zfsmounthook" ] ; then
|
|
|
|
|
rm -f "$zfsmounthook"
|
|
|
|
|
fi
|
|
|
|
|
done
|
|
|
|
|
return
|
2016-04-24 11:35:44 +00:00
|
|
|
fi
|
Use a different technique to detect whether to mount-zfs
The behavior of the Dracut module was very wrong before.
The correct behavior: initramfs should not run `zfs-mount` to completion
if the two generator files exist. If, however, one of them is missing,
it indicates one of three cases:
* The kernel command line did not specify a root ZFS file system, and
another Dracut module is already handling root mount (via systemd).
`mount-zfs` can run, but it will do nothing.
* There is no systemd to run `sysroot.mount` to begin with.
`mount-zfs` must run.
* The root parameter is zfs:AUTO, which cannot be run in sysroot.mount.
`mount-zfs` must run.
In any of these three cases, it is safe to run `zfs-mount` to completion.
`zfs-mount` must also delete itself if it determines it should not run,
or else Dracut will do the insane thing of running it over and over again.
Literally, the definition of insanity, doing the same thing that did not
work before, expecting different results. Doing that may have had a great
result before, when we had a race between devices appearing and pools
being mounted, and `mount-zfs` was tasked with the full responsibility
of importing the needed pool, but nowadays it is wrong behavior and
should be suppressed.
I deduced that self-deletion was the correct thing to do by looking at
other Dracut code, because (as we all are very fully aware of) Dracut
is entirely, ahem, "implementation-defined".
Tested-by: @wphilips
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Manuel Amador (Rudd-O) <rudd-o@rudd-o.com>
Closes #5157
Closes #5204
2016-10-06 17:26:47 +00:00
|
|
|
info "ZFS: No sysroot.mount exists or zfs-generator did not extend it."
|
|
|
|
|
info "ZFS: Mounting root with the traditional mount-zfs.sh instead."
|
2016-04-24 11:35:44 +00:00
|
|
|
|
2015-03-23 16:17:56 +00:00
|
|
|
# Delay until all required block devices are present.
|
2018-03-22 17:14:29 +00:00
|
|
|
modprobe zfs 2>/dev/null
|
2015-03-23 16:17:56 +00:00
|
|
|
udevadm settle
|
|
|
|
|
|
2015-02-15 19:28:42 +00:00
|
|
|
if [ "${root}" = "zfs:AUTO" ] ; then
|
|
|
|
|
ZFS_DATASET="$(find_bootfs)"
|
|
|
|
|
if [ $? -ne 0 ] ; then
|
|
|
|
|
zpool import -N -a ${ZPOOL_IMPORT_OPTS}
|
|
|
|
|
ZFS_DATASET="$(find_bootfs)"
|
|
|
|
|
if [ $? -ne 0 ] ; then
|
|
|
|
|
warn "ZFS: No bootfs attribute found in importable pools."
|
2016-10-16 03:30:53 +00:00
|
|
|
export_all -F
|
2015-02-15 19:28:42 +00:00
|
|
|
|
|
|
|
|
rootok=0
|
|
|
|
|
return 1
|
2011-07-24 20:46:16 +00:00
|
|
|
fi
|
2015-02-15 19:28:42 +00:00
|
|
|
fi
|
|
|
|
|
info "ZFS: Using ${ZFS_DATASET} as root."
|
|
|
|
|
fi
|
2011-07-04 17:25:31 +00:00
|
|
|
|
2015-02-15 19:28:42 +00:00
|
|
|
ZFS_DATASET="${ZFS_DATASET:-${root#zfs:}}"
|
|
|
|
|
ZFS_POOL="${ZFS_DATASET%%/*}"
|
2014-10-06 11:08:33 +00:00
|
|
|
|
2015-02-15 19:28:42 +00:00
|
|
|
if import_pool "${ZFS_POOL}" ; then
|
2018-01-18 18:20:34 +00:00
|
|
|
# Load keys if we can or if we need to
|
2020-11-12 22:16:50 +00:00
|
|
|
if [ "$(zpool list -H -o feature@encryption "$(echo "${ZFS_POOL}" | awk -F/ '{print $1}')")" = 'active' ]; then
|
2018-01-18 18:20:34 +00:00
|
|
|
# if the root dataset has encryption enabled
|
2018-02-22 01:54:54 +00:00
|
|
|
ENCRYPTIONROOT="$(zfs get -H -o value encryptionroot "${ZFS_DATASET}")"
|
2018-02-20 18:13:20 +00:00
|
|
|
if ! [ "${ENCRYPTIONROOT}" = "-" ]; then
|
2019-11-08 22:34:07 +00:00
|
|
|
KEYSTATUS="$(zfs get -H -o value keystatus "${ENCRYPTIONROOT}")"
|
|
|
|
|
# if the key needs to be loaded
|
|
|
|
|
if [ "$KEYSTATUS" = "unavailable" ]; then
|
|
|
|
|
# decrypt them
|
|
|
|
|
ask_for_password \
|
|
|
|
|
--tries 5 \
|
|
|
|
|
--prompt "Encrypted ZFS password for ${ENCRYPTIONROOT}: " \
|
|
|
|
|
--cmd "zfs load-key '${ENCRYPTIONROOT}'"
|
|
|
|
|
fi
|
2018-01-18 18:20:34 +00:00
|
|
|
fi
|
|
|
|
|
fi
|
Use a different technique to detect whether to mount-zfs
The behavior of the Dracut module was very wrong before.
The correct behavior: initramfs should not run `zfs-mount` to completion
if the two generator files exist. If, however, one of them is missing,
it indicates one of three cases:
* The kernel command line did not specify a root ZFS file system, and
another Dracut module is already handling root mount (via systemd).
`mount-zfs` can run, but it will do nothing.
* There is no systemd to run `sysroot.mount` to begin with.
`mount-zfs` must run.
* The root parameter is zfs:AUTO, which cannot be run in sysroot.mount.
`mount-zfs` must run.
In any of these three cases, it is safe to run `zfs-mount` to completion.
`zfs-mount` must also delete itself if it determines it should not run,
or else Dracut will do the insane thing of running it over and over again.
Literally, the definition of insanity, doing the same thing that did not
work before, expecting different results. Doing that may have had a great
result before, when we had a race between devices appearing and pools
being mounted, and `mount-zfs` was tasked with the full responsibility
of importing the needed pool, but nowadays it is wrong behavior and
should be suppressed.
I deduced that self-deletion was the correct thing to do by looking at
other Dracut code, because (as we all are very fully aware of) Dracut
is entirely, ahem, "implementation-defined".
Tested-by: @wphilips
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Manuel Amador (Rudd-O) <rudd-o@rudd-o.com>
Closes #5157
Closes #5204
2016-10-06 17:26:47 +00:00
|
|
|
# Let us tell the initrd to run on shutdown.
|
|
|
|
|
# We have a shutdown hook to run
|
|
|
|
|
# because we imported the pool.
|
2015-02-15 19:28:42 +00:00
|
|
|
info "ZFS: Mounting dataset ${ZFS_DATASET}..."
|
|
|
|
|
if mount_dataset "${ZFS_DATASET}" ; then
|
|
|
|
|
ROOTFS_MOUNTED=yes
|
|
|
|
|
return 0
|
|
|
|
|
fi
|
|
|
|
|
fi
|
|
|
|
|
|
|
|
|
|
rootok=0
|
