From fc0b1e89417443108eef3c9d0332ad5248d6714f Mon Sep 17 00:00:00 2001
From: Mark McDowall <mark@mcdowall.ca>
Date: Fri, 3 May 2019 17:52:23 -0700
Subject: [PATCH] Extra warning for Windows Service issues when prompted to
 restart after changing host settings

Closes #3094
---
 .../src/Settings/General/GeneralSettings.js   | 34 +++++++++++--------
 .../General/GeneralSettingsConnector.js       |  1 +
 2 files changed, 20 insertions(+), 15 deletions(-)

diff --git a/frontend/src/Settings/General/GeneralSettings.js b/frontend/src/Settings/General/GeneralSettings.js
index dc969c136..ea30e826c 100644
--- a/frontend/src/Settings/General/GeneralSettings.js
+++ b/frontend/src/Settings/General/GeneralSettings.js
@@ -16,6 +16,19 @@ import ProxySettings from './ProxySettings';
 import SecuritySettings from './SecuritySettings';
 import UpdateSettings from './UpdateSettings';
 
+const requiresRestartKeys = [
+  'bindAddress',
+  'port',
+  'urlBase',
+  'enableSsl',
+  'sslPort',
+  'sslCertHash',
+  'authenticationMethod',
+  'username',
+  'password',
+  'apiKey'
+];
+
 class GeneralSettings extends Component {
 
   //
@@ -42,20 +55,7 @@ class GeneralSettings extends Component {
 
     const prevSettings = prevProps.settings;
 
-    const keys = [
-      'bindAddress',
-      'port',
-      'urlBase',
-      'enableSsl',
-      'sslPort',
-      'sslCertHash',
-      'authenticationMethod',
-      'username',
-      'password',
-      'apiKey'
-    ];
-
-    const pendingRestart = _.some(keys, (key) => {
+    const pendingRestart = _.some(requiresRestartKeys, (key) => {
       const setting = settings[key];
       const prevSetting = prevSettings[key];
 
@@ -98,6 +98,7 @@ class GeneralSettings extends Component {
       isResettingApiKey,
       isMono,
       isWindows,
+      isWindowsService,
       mode,
       packageUpdateMechanism,
       onInputChange,
@@ -179,7 +180,9 @@ class GeneralSettings extends Component {
           isOpen={this.state.isRestartRequiredModalOpen}
           kind={kinds.DANGER}
           title="Restart Sonarr"
-          message="Sonarr requires a restart to apply changes, do you want to restart now?"
+          message={
+            `Sonarr requires a restart to apply changes, do you want to restart now? ${isWindowsService ? 'Depending which user is running the Sonarr service you may need to restart Sonarr as admin once before the service will start automatically.' : ''}`
+          }
           cancelLabel="I'll restart later"
           confirmLabel="Restart Now"
           onConfirm={this.onConfirmRestart}
@@ -203,6 +206,7 @@ GeneralSettings.propTypes = {
   hasSettings: PropTypes.bool.isRequired,
   isMono: PropTypes.bool.isRequired,
   isWindows: PropTypes.bool.isRequired,
+  isWindowsService: PropTypes.bool.isRequired,
   mode: PropTypes.string.isRequired,
   packageUpdateMechanism: PropTypes.string.isRequired,
   onInputChange: PropTypes.func.isRequired,
diff --git a/frontend/src/Settings/General/GeneralSettingsConnector.js b/frontend/src/Settings/General/GeneralSettingsConnector.js
index 82c9d442e..70a7a28ea 100644
--- a/frontend/src/Settings/General/GeneralSettingsConnector.js
+++ b/frontend/src/Settings/General/GeneralSettingsConnector.js
@@ -26,6 +26,7 @@ function createMapStateToProps() {
         isResettingApiKey,
         isMono: systemStatus.isMono,
         isWindows: systemStatus.isWindows,
+        isWindowsService: systemStatus.isWindows && systemStatus.mode === 'service',
         mode: systemStatus.mode,
         packageUpdateMechanism: systemStatus.packageUpdateMechanism,
         ...sectionSettings