Fixed: Series toolbar button collapsing

This commit is contained in:
Mark McDowall 2020-04-09 22:58:08 -07:00
parent 9b99ad27cd
commit e1639d35a2
4 changed files with 8 additions and 12 deletions

View File

@ -1,6 +1,6 @@
.sectionContainer { .sectionContainer {
display: flex; display: flex;
flex: 1 1 10%; flex: 1 1 auto;
overflow: hidden; overflow: hidden;
} }

View File

@ -15,7 +15,6 @@ import styles from './PageToolbarSection.css';
const BUTTON_WIDTH = parseInt(dimensions.toolbarButtonWidth); const BUTTON_WIDTH = parseInt(dimensions.toolbarButtonWidth);
const SEPARATOR_MARGIN = parseInt(dimensions.toolbarSeparatorMargin); const SEPARATOR_MARGIN = parseInt(dimensions.toolbarSeparatorMargin);
const SEPARATOR_WIDTH = 2 * SEPARATOR_MARGIN + 1; const SEPARATOR_WIDTH = 2 * SEPARATOR_MARGIN + 1;
const SEPARATOR_NAME = 'PageToolbarSeparator';
function calculateOverflowItems(children, isMeasured, width, collapseButtons) { function calculateOverflowItems(children, isMeasured, width, collapseButtons) {
let buttonCount = 0; let buttonCount = 0;
@ -23,9 +22,7 @@ function calculateOverflowItems(children, isMeasured, width, collapseButtons) {
const validChildren = []; const validChildren = [];
forEach(children, (child) => { forEach(children, (child) => {
const name = child.type.name; if (Object.keys(child.props).length === 0) {
if (name === SEPARATOR_NAME) {
separatorCount++; separatorCount++;
} else { } else {
buttonCount++; buttonCount++;
@ -68,12 +65,14 @@ function calculateOverflowItems(children, isMeasured, width, collapseButtons) {
} }
validChildren.forEach((child, index) => { validChildren.forEach((child, index) => {
const isSeparator = Object.keys(child.props).length === 0;
if (actualButtons < maxButtons) { if (actualButtons < maxButtons) {
if (child.type.name !== SEPARATOR_NAME) { if (!isSeparator) {
buttons.push(child); buttons.push(child);
actualButtons++; actualButtons++;
} }
} else if (child.type.name !== SEPARATOR_NAME) { } else if (!isSeparator) {
overflowItems.push(child.props); overflowItems.push(child.props);
} }
}); });

View File

@ -255,10 +255,7 @@ class SeriesIndex extends Component {
null null
} }
{
(view === 'posters' || view === 'overview') &&
<PageToolbarSeparator /> <PageToolbarSeparator />
}
<SeriesIndexViewMenu <SeriesIndexViewMenu
view={view} view={view}

View File

@ -19,7 +19,7 @@ export function getSeriesStatusDetails(status) {
statusDetails = { statusDetails = {
icon: icons.SERIES_ENDED, icon: icons.SERIES_ENDED,
title: 'Ended', title: 'Ended',
message: 'No additional episodes or or another season is expected' message: 'No additional episodes or seasons are expected'
}; };
} else if (status === 'upcoming') { } else if (status === 'upcoming') {
statusDetails = { statusDetails = {