Add minimum length as const in ApiKeyValidationCheck

This commit is contained in:
Bogdan 2023-05-13 15:23:01 +03:00 committed by Mark McDowall
parent bb97fbc23f
commit b06269544c
2 changed files with 6 additions and 4 deletions

View File

@ -10,6 +10,8 @@ namespace NzbDrone.Core.HealthCheck.Checks
[CheckOn(typeof(ConfigSavedEvent))] [CheckOn(typeof(ConfigSavedEvent))]
public class ApiKeyValidationCheck : HealthCheckBase public class ApiKeyValidationCheck : HealthCheckBase
{ {
private const int MinimumLength = 20;
private readonly IConfigFileProvider _configFileProvider; private readonly IConfigFileProvider _configFileProvider;
private readonly Logger _logger; private readonly Logger _logger;
@ -22,11 +24,11 @@ namespace NzbDrone.Core.HealthCheck.Checks
public override HealthCheck Check() public override HealthCheck Check()
{ {
if (_configFileProvider.ApiKey.Length < 20) if (_configFileProvider.ApiKey.Length < MinimumLength)
{ {
_logger.Warn("Please update your API key to be at least 20 characters long. You can do this via settings or the config file"); _logger.Warn("Please update your API key to be at least {0} characters long. You can do this via settings or the config file", MinimumLength);
return new HealthCheck(GetType(), HealthCheckResult.Warning, _localizationService.GetLocalizedString("ApiKeyValidationHealthCheckMessage"), "#invalid-api-key"); return new HealthCheck(GetType(), HealthCheckResult.Warning, string.Format(_localizationService.GetLocalizedString("ApiKeyValidationHealthCheckMessage"), MinimumLength), "#invalid-api-key");
} }
return new HealthCheck(GetType()); return new HealthCheck(GetType());

View File

@ -1,6 +1,6 @@
{ {
"Added": "Added", "Added": "Added",
"ApiKeyValidationHealthCheckMessage": "Please update your API key to be at least 20 characters long. You can do this via settings or the config file", "ApiKeyValidationHealthCheckMessage": "Please update your API key to be at least {0} characters long. You can do this via settings or the config file",
"AppDataLocationHealthCheckMessage": "Updating will not be possible to prevent deleting AppData on Update", "AppDataLocationHealthCheckMessage": "Updating will not be possible to prevent deleting AppData on Update",
"ApplyChanges": "Apply Changes", "ApplyChanges": "Apply Changes",
"AutomaticAdd": "Automatic Add", "AutomaticAdd": "Automatic Add",