From 7241ca4ae97891a200181ccfb97d4668a930c09c Mon Sep 17 00:00:00 2001 From: Taloth Saldono Date: Fri, 6 Jul 2018 19:09:59 +0200 Subject: [PATCH] Run http tests more gracefully. --- .../Http/HttpClientFixture.cs | 44 ++++++++++++++++++- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git a/src/NzbDrone.Common.Test/Http/HttpClientFixture.cs b/src/NzbDrone.Common.Test/Http/HttpClientFixture.cs index 49cdcc6e5..72853e160 100644 --- a/src/NzbDrone.Common.Test/Http/HttpClientFixture.cs +++ b/src/NzbDrone.Common.Test/Http/HttpClientFixture.cs @@ -2,6 +2,7 @@ using System.Collections.Generic; using System.Globalization; using System.IO; +using System.Linq; using System.Net; using System.Threading; using FluentAssertions; @@ -24,13 +25,41 @@ namespace NzbDrone.Common.Test.Http [TestFixture(typeof(CurlHttpDispatcher))] public class HttpClientFixture : TestBase where TDispatcher : IHttpDispatcher { - private static string[] _httpBinHosts = new[] { "eu.httpbin.org", "httpbin.org" }; - private static int _httpBinRandom; + private string[] _httpBinHosts; + private int _httpBinSleep; + private int _httpBinRandom; private string _httpBinHost; + [OneTimeSetUp] + public void FixtureSetUp() + { + var candidates = new[] { "eu.httpbin.org", "httpbin.org" }; + _httpBinHosts = candidates.Where(IsTestSiteAvailable).ToArray(); + + _httpBinSleep = _httpBinHosts.Count() < 2 ? 100 : 50; + } + + private bool IsTestSiteAvailable(string site) + { + try + { + var result = new System.Net.WebClient().DownloadString($"http://{site}/get"); + return result.StartsWith("{"); + } + catch + { + return false; + } + } + [SetUp] public void SetUp() { + if (!_httpBinHosts.Any()) + { + Assert.Inconclusive("No TestSite available"); + } + Mocker.GetMock().Setup(c => c.Version).Returns(new Version("1.0.0")); Mocker.GetMock().Setup(c => c.Name).Returns("TestOS"); Mocker.GetMock().Setup(c => c.Version).Returns("9.0.0"); @@ -52,6 +81,12 @@ namespace NzbDrone.Common.Test.Http _httpBinHost = _httpBinHosts[_httpBinRandom++ % _httpBinHosts.Length]; } + [TearDown] + public void TearDown() + { + Thread.Sleep(_httpBinSleep); + } + [Test] public void should_execute_simple_get() { @@ -245,6 +280,11 @@ namespace NzbDrone.Common.Test.Http public void GivenOldCookie() { + if (!_httpBinHosts.Contains("httpbin.org") || !_httpBinHosts.Contains("eu.httpbin.org")) + { + Assert.Inconclusive("Need both httpbin.org and eu.httpbin.org to run this test."); + } + var oldRequest = new HttpRequest("http://eu.httpbin.org/get"); oldRequest.Cookies["my"] = "cookie";