Archive-Team
/
sonarr-repo-only
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

New: Improve accepted and rejected release logging 

Closes #4965
Closes #4646
This commit is contained in:
Mark McDowall 2023-03-16 20:58:01 -07:00
parent 98308737cf
commit 4ff4d32936
2 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/NzbDrone.Core/DecisionEngine/DownloadDecisionMaker.cs
View File

@ -178,11 +178,11 @@ namespace NzbDrone.Core.DecisionEngine
if (decision.Rejections.Any()) if (decision.Rejections.Any())
{ {
_logger.Debug("Release rejected for the following reasons: {0}", string.Join(", ", decision.Rejections)); _logger.Debug("Release '{0}' from '{1}' rejected for the following reasons: {2}", report.Title, report.Indexer, string.Join(", ", decision.Rejections));
} }
else else
{ {
_logger.Debug("Release accepted"); _logger.Debug("Release '{0}' from '{1}' accepted", report.Title, report.Indexer);
} }
yield return decision; yield return decision;

18
src/NzbDrone.Core/DecisionEngine/Specifications/UpgradableSpecification.cs
View File

@ -36,13 +36,13 @@ namespace NzbDrone.Core.DecisionEngine.Specifications
if (qualityCompare > 0) if (qualityCompare > 0)
{ {
_logger.Debug("New item has a better quality"); _logger.Debug("New item has a better quality. Existing: {0}. New: {1}", currentQuality, newQuality);
return true; return true;
} }
if (qualityCompare < 0) if (qualityCompare < 0)
{ {
_logger.Debug("Existing item has better quality, skipping"); _logger.Debug("Existing item has better quality, skipping. Existing: {0}. New: {1}", currentQuality, newQuality);
return false; return false;
} }
@ -53,7 +53,7 @@ namespace NzbDrone.Core.DecisionEngine.Specifications
if (downloadPropersAndRepacks != ProperDownloadTypes.DoNotPrefer && if (downloadPropersAndRepacks != ProperDownloadTypes.DoNotPrefer &&
qualityRevisionComapre > 0) qualityRevisionComapre > 0)
{ {
_logger.Debug("New item has a better quality revision"); _logger.Debug("New item has a better quality revision", currentQuality, newQuality);
return true; return true;
} }
@ -64,15 +64,17 @@ namespace NzbDrone.Core.DecisionEngine.Specifications
if (downloadPropersAndRepacks != ProperDownloadTypes.DoNotPrefer && if (downloadPropersAndRepacks != ProperDownloadTypes.DoNotPrefer &&
qualityRevisionComapre < 0) qualityRevisionComapre < 0)
{ {
_logger.Debug("Existing item has a better quality revision, skipping"); _logger.Debug("Existing item has a better quality revision, skipping. Existing: {0}. New: {1}", currentQuality, newQuality);
return false; return false;
} }
if (newFormatScore <= currentFormatScore) if (newFormatScore <= currentFormatScore)
{ {
_logger.Debug("New item's custom formats [{0}] do not improve on [{1}], skipping", _logger.Debug("New item's custom formats [{0}] ({1}) do not improve on [{2}] ({3}, skipping",
newCustomFormats.ConcatToString(), newCustomFormats.ConcatToString(),
currentCustomFormats.ConcatToString()); newFormatScore,
currentCustomFormats.ConcatToString(),
currentFormatScore);
return false; return false;
} }
@ -117,7 +119,7 @@ namespace NzbDrone.Core.DecisionEngine.Specifications
return true; return true;
} }
_logger.Debug("Existing item meets cut-off. skipping."); _logger.Debug("Existing item meets cut-off. skipping. Existing: {0}", currentQuality);
return false; return false;
} }
@ -129,7 +131,7 @@ namespace NzbDrone.Core.DecisionEngine.Specifications
// Comparing the quality directly because we don't want to upgrade to a proper for a webrip from a webdl or vice versa // Comparing the quality directly because we don't want to upgrade to a proper for a webrip from a webdl or vice versa
if (currentQuality.Quality == newQuality.Quality && compare > 0) if (currentQuality.Quality == newQuality.Quality && compare > 0)
{ {
_logger.Debug("New quality is a better revision for existing quality"); _logger.Debug("New quality is a better revision for existing quality. Existing: {0}. New: {1}", currentQuality, newQuality);
return true; return true;
} }