Archive-Team
/
sonarr-repo-only
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed: Enforce validation warnings

This commit is contained in:
Bogdan 2023-05-26 18:35:31 +03:00 committed by Mark McDowall
parent 7343616a47
commit 48ee1158ad
3 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
frontend/src/Store/Actions/Creators/createSaveProviderHandler.js
View File

@ -32,9 +32,9 @@ function createSaveProviderHandler(section, url, options = {}) {
const params = { ...queryParams }; const params = { ...queryParams };
// If the user is re-saving the same provider without changes // If the user is re-saving the same provider without changes
// force it to be saved. Only applies to editing existing providers. // force it to be saved.
if (id && _.isEqual(saveData, lastSaveData)) { if (_.isEqual(saveData, lastSaveData)) {
params.forceSave = true; params.forceSave = true;
} }

2
src/NzbDrone.Core/Indexers/SeedCriteriaSettings.cs
View File

@ -48,8 +48,6 @@ namespace NzbDrone.Core.Indexers
public class SeedCriteriaSettings public class SeedCriteriaSettings
{ {
private static readonly SeedCriteriaSettingsValidator Validator = new SeedCriteriaSettingsValidator();
[FieldDefinition(0, Type = FieldType.Textbox, Label = "Seed Ratio", HelpText = "The ratio a torrent should reach before stopping, empty is download client's default. Ratio should be at least 1.0 and follow the indexers rules")] [FieldDefinition(0, Type = FieldType.Textbox, Label = "Seed Ratio", HelpText = "The ratio a torrent should reach before stopping, empty is download client's default. Ratio should be at least 1.0 and follow the indexers rules")]
public double? SeedRatio { get; set; } public double? SeedRatio { get; set; }

8
src/Sonarr.Api.V3/ProviderControllerBase.cs
View File

@ -68,9 +68,9 @@ namespace Sonarr.Api.V3
[RestPostById] [RestPostById]
[Consumes("application/json")] [Consumes("application/json")]
public ActionResult<TProviderResource> CreateProvider(TProviderResource providerResource) public ActionResult<TProviderResource> CreateProvider([FromBody] TProviderResource providerResource, [FromQuery] bool forceSave = false)
{ {
var providerDefinition = GetDefinition(providerResource, true, false, false); var providerDefinition = GetDefinition(providerResource, true, !forceSave, false);
if (providerDefinition.Enable) if (providerDefinition.Enable)
{ {
@ -86,7 +86,7 @@ namespace Sonarr.Api.V3
[Consumes("application/json")] [Consumes("application/json")]
public ActionResult<TProviderResource> UpdateProvider([FromBody] TProviderResource providerResource, [FromQuery] bool forceSave = false) public ActionResult<TProviderResource> UpdateProvider([FromBody] TProviderResource providerResource, [FromQuery] bool forceSave = false)
{ {
var providerDefinition = GetDefinition(providerResource, true, false, false); var providerDefinition = GetDefinition(providerResource, true, !forceSave, false);
// Only test existing definitions if it is enabled and forceSave isn't set. // Only test existing definitions if it is enabled and forceSave isn't set.
if (providerDefinition.Enable && !forceSave) if (providerDefinition.Enable && !forceSave)
@ -252,7 +252,7 @@ namespace Sonarr.Api.V3
protected void VerifyValidationResult(ValidationResult validationResult, bool includeWarnings) protected void VerifyValidationResult(ValidationResult validationResult, bool includeWarnings)
{ {
var result = new NzbDroneValidationResult(validationResult.Errors); var result = validationResult as NzbDroneValidationResult ?? new NzbDroneValidationResult(validationResult.Errors);
if (includeWarnings && (!result.IsValid || result.HasWarnings)) if (includeWarnings && (!result.IsValid || result.HasWarnings))
{ {