New: Improve multi-language negate Custom Format

Closes #6408

src/NzbDrone.Core.Test/CustomFormats/Specifications/LanguageSpecification/MultiLanguageFixture.cs

@@ -0,0 +1,71 @@
+using System.Collections.Generic;
+using FizzWare.NBuilder;
+using FluentAssertions;
+using NUnit.Framework;
+using NzbDrone.Core.CustomFormats;
+using NzbDrone.Core.Languages;
+using NzbDrone.Core.Parser.Model;
+using NzbDrone.Core.Test.Framework;
+using NzbDrone.Core.Tv;
+
+namespace NzbDrone.Core.Test.CustomFormats.Specifications.LanguageSpecification
+{
+    [TestFixture]
+    public class MultiLanguageFixture : CoreTest<Core.CustomFormats.LanguageSpecification>
+    {
+        private CustomFormatInput _input;
+
+        [SetUp]
+        public void Setup()
+        {
+            _input = new CustomFormatInput
+            {
+                EpisodeInfo = Builder<ParsedEpisodeInfo>.CreateNew().Build(),
+                Series = Builder<Series>.CreateNew().With(s => s.OriginalLanguage = Language.English).Build(),
+                Size = 100.Megabytes(),
+                Languages = new List<Language>
+                {
+                    Language.English,
+                    Language.French
+                },
+                Filename = "Series.Title.S01E01"
+            };
+        }
+
+        [Test]
+        public void should_match_one_language()
+        {
+            Subject.Value = Language.French.Id;
+            Subject.Negate = false;
+
+            Subject.IsSatisfiedBy(_input).Should().BeTrue();
+        }
+
+        [Test]
+        public void should_not_match_different_language()
+        {
+            Subject.Value = Language.Spanish.Id;
+            Subject.Negate = false;
+
+            Subject.IsSatisfiedBy(_input).Should().BeFalse();
+        }
+
+        [Test]
+        public void should_not_match_negated_when_one_language_matches()
+        {
+            Subject.Value = Language.French.Id;
+            Subject.Negate = true;
+
+            Subject.IsSatisfiedBy(_input).Should().BeFalse();
+        }
+
+        [Test]
+        public void should_not_match_negated_when_all_languages_do_not_match()
+        {
+            Subject.Value = Language.Spanish.Id;
+            Subject.Negate = true;
+
+            Subject.IsSatisfiedBy(_input).Should().BeTrue();
+        }
+    }
+}

src/NzbDrone.Core.Test/CustomFormats/Specifications/LanguageSpecification/OriginalLanguageFixture.cs

@@ -0,0 +1,80 @@
+using System.Collections.Generic;
+using System.Linq;
+using FizzWare.NBuilder;
+using FluentAssertions;
+using NUnit.Framework;
+using NzbDrone.Core.CustomFormats;
+using NzbDrone.Core.Languages;
+using NzbDrone.Core.Parser.Model;
+using NzbDrone.Core.Test.Framework;
+using NzbDrone.Core.Tv;
+
+namespace NzbDrone.Core.Test.CustomFormats.Specifications.LanguageSpecification
+{
+    [TestFixture]
+    public class OriginalLanguageFixture : CoreTest<Core.CustomFormats.LanguageSpecification>
+    {
+        private CustomFormatInput _input;
+
+        [SetUp]
+        public void Setup()
+        {
+            _input = new CustomFormatInput
+            {
+                EpisodeInfo = Builder<ParsedEpisodeInfo>.CreateNew().Build(),
+                Series = Builder<Series>.CreateNew().With(s => s.OriginalLanguage = Language.English).Build(),
+                Size = 100.Megabytes(),
+                Languages = new List<Language>
+                {
+                    Language.French
+                },
+                Filename = "Series.Title.S01E01"
+            };
+        }
+
+        public void GivenLanguages(params Language[] languages)
+        {
+            _input.Languages = languages.ToList();
+        }
+
+        [Test]
+        public void should_match_same_single_language()
+        {
+            GivenLanguages(Language.English);
+
+            Subject.Value = Language.Original.Id;
+            Subject.Negate = false;
+
+            Subject.IsSatisfiedBy(_input).Should().BeTrue();
+        }
+
+        [Test]
+        public void should_not_match_different_single_language()
+        {
+            Subject.Value = Language.Original.Id;
+            Subject.Negate = false;
+
+            Subject.IsSatisfiedBy(_input).Should().BeFalse();
+        }
+
+        [Test]
+        public void should_not_match_negated_same_single_language()
+        {
+            GivenLanguages(Language.English);
+
+            Subject.Value = Language.Original.Id;
+            Subject.Negate = true;
+
+            Subject.IsSatisfiedBy(_input).Should().BeFalse();
+        }
+
+        [Test]
+        public void should_match_negated_different_single_language()
+        {
+            Subject.Value = Language.Original.Id;
+            Subject.Negate = true;
+
+            Subject.IsSatisfiedBy(_input).Should().BeTrue();
+        }
+    }
+}

src/NzbDrone.Core.Test/CustomFormats/Specifications/LanguageSpecification/SingleLanguageFixture.cs

@@ -0,0 +1,70 @@
+using System.Collections.Generic;
+using FizzWare.NBuilder;
+using FluentAssertions;
+using NUnit.Framework;
+using NzbDrone.Core.CustomFormats;
+using NzbDrone.Core.Languages;
+using NzbDrone.Core.Parser.Model;
+using NzbDrone.Core.Test.Framework;
+using NzbDrone.Core.Tv;
+
+namespace NzbDrone.Core.Test.CustomFormats.Specifications.LanguageSpecification
+{
+    [TestFixture]
+    public class SingleLanguageFixture : CoreTest<Core.CustomFormats.LanguageSpecification>
+    {
+        private CustomFormatInput _input;
+
+        [SetUp]
+        public void Setup()
+        {
+            _input = new CustomFormatInput
+            {
+                EpisodeInfo = Builder<ParsedEpisodeInfo>.CreateNew().Build(),
+                Series = Builder<Series>.CreateNew().With(s => s.OriginalLanguage = Language.English).Build(),
+                Size = 100.Megabytes(),
+                Languages = new List<Language>
+                {
+                    Language.French
+                },
+                Filename = "Series.Title.S01E01"
+            };
+        }
+
+        [Test]
+        public void should_match_same_language()
+        {
+            Subject.Value = Language.French.Id;
+            Subject.Negate = false;
+
+            Subject.IsSatisfiedBy(_input).Should().BeTrue();
+        }
+
+        [Test]
+        public void should_not_match_different_language()
+        {
+            Subject.Value = Language.Spanish.Id;
+            Subject.Negate = false;
+
+            Subject.IsSatisfiedBy(_input).Should().BeFalse();
+        }
+
+        [Test]
+        public void should_not_match_negated_same_language()
+        {
+            Subject.Value = Language.French.Id;
+            Subject.Negate = true;
+
+            Subject.IsSatisfiedBy(_input).Should().BeFalse();
+        }
+
+        [Test]
+        public void should_match_negated_different_language()
+        {
+            Subject.Value = Language.Spanish.Id;
+            Subject.Negate = true;
+
+            Subject.IsSatisfiedBy(_input).Should().BeTrue();
+        }
+    }
+}

src/NzbDrone.Core/CustomFormats/Specifications/CustomFormatSpecificationBase.cs

@@ -20,7 +20,7 @@ namespace NzbDrone.Core.CustomFormats
 
         public abstract NzbDroneValidationResult Validate();
 
-        public bool IsSatisfiedBy(CustomFormatInput input)
+        public virtual bool IsSatisfiedBy(CustomFormatInput input)
         {
             var match = IsSatisfiedByWithoutNegate(input);
 

src/NzbDrone.Core/CustomFormats/Specifications/LanguageSpecification.cs

@@ -30,6 +30,16 @@ namespace NzbDrone.Core.CustomFormats
         [FieldDefinition(1, Label = "CustomFormatsSpecificationLanguage", Type = FieldType.Select, SelectOptions = typeof(LanguageFieldConverter))]
         public int Value { get; set; }
 
+        public override bool IsSatisfiedBy(CustomFormatInput input)
+        {
+            if (Negate)
+            {
+                return IsSatisfiedByWithNegate(input);
+            }
+
+            return IsSatisfiedByWithoutNegate(input);
+        }
+
         protected override bool IsSatisfiedByWithoutNegate(CustomFormatInput input)
         {
             var comparedLanguage = input.EpisodeInfo != null && input.Series != null && Value == Language.Original.Id && input.Series.OriginalLanguage != Language.Unknown
@@ -39,6 +49,15 @@ namespace NzbDrone.Core.CustomFormats
             return input.Languages?.Contains(comparedLanguage) ?? false;
         }
 
+        private bool IsSatisfiedByWithNegate(CustomFormatInput input)
+        {
+            var comparedLanguage = input.EpisodeInfo != null && input.Series != null && Value == Language.Original.Id && input.Series.OriginalLanguage != Language.Unknown
+                ? input.Series.OriginalLanguage
+                : (Language)Value;
+
+            return !input.Languages?.Contains(comparedLanguage) ?? false;
+        }
+
         public override NzbDroneValidationResult Validate()
         {
             return new NzbDroneValidationResult(Validator.Validate(this));