From 37054673b73df0cae7a0693e29ee31907df85dc0 Mon Sep 17 00:00:00 2001 From: Taloth Saldono Date: Tue, 7 Aug 2018 19:08:15 +0200 Subject: [PATCH] Fixed: Too big eta in qbit api still occurring on official builds. --- build.sh | 11 ----------- .../QBittorrentTests/QBittorrentFixture.cs | 13 +++++++++++++ 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/build.sh b/build.sh index e45c949e9..9c2cb76c7 100755 --- a/build.sh +++ b/build.sh @@ -52,15 +52,6 @@ CleanFolder() find $path -depth -empty -type d -exec rm -r "{}" \; } - - -AddJsonNet() -{ - rm $outputFolder/Newtonsoft.Json.* - cp $sourceFolder/packages/Newtonsoft.Json.*/lib/net35/*.dll $outputFolder - cp $sourceFolder/packages/Newtonsoft.Json.*/lib/net35/*.dll $outputFolder/NzbDrone.Update -} - BuildWithMSBuild() { export PATH=$msBuild:$PATH @@ -91,8 +82,6 @@ Build() CleanFolder $outputFolder false - AddJsonNet - echo "Removing Mono.Posix.dll" rm $outputFolder/Mono.Posix.dll diff --git a/src/NzbDrone.Core.Test/Download/DownloadClientTests/QBittorrentTests/QBittorrentFixture.cs b/src/NzbDrone.Core.Test/Download/DownloadClientTests/QBittorrentTests/QBittorrentFixture.cs index 3ae45ac50..ecac74902 100644 --- a/src/NzbDrone.Core.Test/Download/DownloadClientTests/QBittorrentTests/QBittorrentFixture.cs +++ b/src/NzbDrone.Core.Test/Download/DownloadClientTests/QBittorrentTests/QBittorrentFixture.cs @@ -495,5 +495,18 @@ namespace NzbDrone.Core.Test.Download.DownloadClientTests.QBittorrentTests var item = Subject.GetItems().Single(); item.Category.Should().Be(category); } + + [Test] + public void should_handle_eta_biginteger() + { + // Let this stand as a lesson to never write temporary unit tests on your dev machine and claim it works. + // Commit the tests and let it run with the official build on the official build agents. + // (Also don't replace library versions in your build script) + + var json = "{ \"eta\": 18446744073709335000 }"; + var torrent = Newtonsoft.Json.JsonConvert.DeserializeObject(json); + torrent.Eta.ToString().Should().Be("18446744073709335000"); + + } } }