From 06d57e8f32cfce8782eebad0b7808204c6c51575 Mon Sep 17 00:00:00 2001 From: Taloth Saldono Date: Sun, 24 Nov 2019 23:47:22 +0100 Subject: [PATCH] Fixed: Refresh Deleted & Upcoming shows as frequently as Continuing ones --- .../TvTests/ShouldRefreshSeriesFixture.cs | 28 +++++++++++++++++++ src/NzbDrone.Core/Tv/ShouldRefreshSeries.cs | 4 +-- 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/src/NzbDrone.Core.Test/TvTests/ShouldRefreshSeriesFixture.cs b/src/NzbDrone.Core.Test/TvTests/ShouldRefreshSeriesFixture.cs index 503351a0a..8b8fd64d5 100644 --- a/src/NzbDrone.Core.Test/TvTests/ShouldRefreshSeriesFixture.cs +++ b/src/NzbDrone.Core.Test/TvTests/ShouldRefreshSeriesFixture.cs @@ -34,6 +34,16 @@ namespace NzbDrone.Core.Test.TvTests _series.Status = SeriesStatusType.Ended; } + private void GivenSeriesIsDeleted() + { + _series.Status = SeriesStatusType.Deleted; + } + + private void GivenSeriesIsUpcoming() + { + _series.Status = SeriesStatusType.Upcoming; + } + private void GivenSeriesLastRefreshedMonthsAgo() { _series.LastInfoSync = DateTime.UtcNow.AddDays(-90); @@ -131,5 +141,23 @@ namespace NzbDrone.Core.Test.TvTests Subject.ShouldRefresh(_series).Should().BeFalse(); } + + [Test] + public void should_return_true_if_deleted_series_last_refreshed_more_than_6_hours_ago() + { + GivenSeriesLastRefreshedHalfADayAgo(); + GivenSeriesIsDeleted(); + + Subject.ShouldRefresh(_series).Should().BeTrue(); + } + + [Test] + public void should_return_true_if_upcoming_series_last_refreshed_more_than_6_hours_ago() + { + GivenSeriesLastRefreshedHalfADayAgo(); + GivenSeriesIsUpcoming(); + + Subject.ShouldRefresh(_series).Should().BeTrue(); + } } } diff --git a/src/NzbDrone.Core/Tv/ShouldRefreshSeries.cs b/src/NzbDrone.Core/Tv/ShouldRefreshSeries.cs index bbf48cbb8..ebeafc3ef 100644 --- a/src/NzbDrone.Core/Tv/ShouldRefreshSeries.cs +++ b/src/NzbDrone.Core/Tv/ShouldRefreshSeries.cs @@ -34,9 +34,9 @@ namespace NzbDrone.Core.Tv return false; } - if (series.Status == SeriesStatusType.Continuing) + if (series.Status != SeriesStatusType.Ended) { - _logger.Trace("Series {0} is continuing, should refresh.", series.Title); + _logger.Trace("Series {0} is not ended, should refresh.", series.Title); return true; }