fixed newznab validation when URL is null.
This commit is contained in:
parent
44abb6fae8
commit
02c68bd387
|
@ -21,7 +21,25 @@ namespace NzbDrone.Core.Test.IndexerTests.NewznabTests
|
||||||
|
|
||||||
setting.Validate().IsValid.Should().BeFalse();
|
setting.Validate().IsValid.Should().BeFalse();
|
||||||
setting.Validate().Errors.Should().Contain(c => c.PropertyName == "ApiKey");
|
setting.Validate().Errors.Should().Contain(c => c.PropertyName == "ApiKey");
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
[TestCase("")]
|
||||||
|
[TestCase(" ")]
|
||||||
|
[TestCase(null)]
|
||||||
|
public void invalid_url_should_not_apikey(string url)
|
||||||
|
{
|
||||||
|
var setting = new NewznabSettings
|
||||||
|
{
|
||||||
|
ApiKey = "",
|
||||||
|
Url = url
|
||||||
|
};
|
||||||
|
|
||||||
|
|
||||||
|
setting.Validate().IsValid.Should().BeFalse();
|
||||||
|
setting.Validate().Errors.Should().NotContain(c => c.PropertyName == "ApiKey");
|
||||||
|
setting.Validate().Errors.Should().Contain(c => c.PropertyName == "Url");
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
|
|
@ -23,6 +23,11 @@ namespace NzbDrone.Core.Indexers.Newznab
|
||||||
|
|
||||||
private static bool ShouldHaveApiKey(NewznabSettings settings)
|
private static bool ShouldHaveApiKey(NewznabSettings settings)
|
||||||
{
|
{
|
||||||
|
if (settings.Url == null)
|
||||||
|
{
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
return ApiKeyWhiteList.Any(c => settings.Url.ToLowerInvariant().Contains(c));
|
return ApiKeyWhiteList.Any(c => settings.Url.ToLowerInvariant().Contains(c));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue