docker-mailserver/target
Brennan Kinney 47f8d50beb
fix: Ensure configs are sanitized for parsing (#3819)
* chore: Detect missing final newline in configs read

These lines will be not be processed by `read`, emit a warning to raise awareness.

* fix: Ensure parsed config has final newline appended (when possible)

This functionality was handled in `accounts.sh` via a similar sed command (that the linked references also offer).

`printf` is better for this, no shellcheck comment required either.

We additionally don't attempt to modify files that are read-only.

* fix: Ensure parsed configs have CRLF to LF corrected (where possible)

Likewise, this runtime fix was only covering two config files. It now applies to all callers of this method.

* fix: Sanitize `postfix-master.cf` via helper

This feature should have been using the helper to avoid user error from their config updates accidentally introducing subtle breakage implicitly (due to CRLF or missing final newline).

* tests: Add test cases for new helpers

* tests:  `rm` is redundant when using `BATS_TEST_TMPDIR`

This temporary directory is created and removed implicitly. Even after a test failure.

* chore: Remove old `postfix-virtual.cf` migration logic

This was introduced in 2018, there should be no one needing to rely on this anymore?

* tests: Remove comment on sed failure concern

* chore: Add entry to `CHANGELOG.md`

* Apply suggestions from code review

Co-authored-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>

---------

Co-authored-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>
2024-01-26 10:28:26 +13:00
..
amavis ci(fix): Normalize for `.gitattributes` + improve `eclint` coverage (#3566) 2023-10-04 12:53:32 +02:00
bin general: update base image to Debian 12 ("Bookworm") (#3403) 2024-01-24 17:05:55 +01:00
dovecot fix: Correctly support multiple Dovecot PassDBs (#3812) 2024-01-23 19:11:05 +01:00
fail2ban F2B: update F2B after discussion in #3256 (#3288) 2023-05-01 15:00:35 +02:00
fetchmail Implement fetchmail (#260) (#271) 2016-08-21 22:13:13 +02:00
getmail feature: adding `getmail` as an alternative to `fetchmail` (#2803) 2023-05-23 17:25:08 +02:00
logwatch Add logwatch maillog.conf file to support /var/log/mail/ (#2112) 2021-08-11 11:31:00 +02:00
mta-sts-daemon feat: Add MTA-STS support for outbound mail (#3592) 2024-01-13 21:37:20 +13:00
opendkim Fixed KeyTable refile in opendkim.conf https://serverfault.com/a/861701/377751 (#2249) 2021-10-16 19:04:51 +02:00
opendmarc fix: Change the default OpenDMARC policy to reject (#2933) 2022-12-19 08:54:38 +13:00
postfix general: update base image to Debian 12 ("Bookworm") (#3403) 2024-01-24 17:05:55 +01:00
postgrey ci(fix): Normalize for `.gitattributes` + improve `eclint` coverage (#3566) 2023-10-04 12:53:32 +02:00
postsrsd config: remove `chroot` for Dovecot & PostSRSd (#3208) 2023-03-31 12:17:44 +02:00
rspamd Rspamd: add custom symbol scores for SPF, DKIM & DMARC (#3726) 2024-01-05 09:07:31 +01:00
scripts fix: Ensure configs are sanitized for parsing (#3819) 2024-01-26 10:28:26 +13:00
shared init tests cases ffdhe4096 2020-04-26 22:23:51 +02:00
supervisor general: update base image to Debian 12 ("Bookworm") (#3403) 2024-01-24 17:05:55 +01:00