Apply suggestions from code review

This commit is contained in:
Brennan Kinney 2024-01-24 15:14:46 +13:00 committed by GitHub
parent fa1f3b005e
commit a01aa66a90
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 6 deletions

View File

@ -13,7 +13,7 @@ All notable changes to this project will be documented in this file. The format
### Fixes
- **Dovecot:**
**Dovecot:**
- Restrict the auth mechanisms for PassDB configs we manage (oauth2, passwd-file, ldap) ([#3812](https://github.com/docker-mailserver/docker-mailserver/pull/3812))
- Prevents misleading auth failures from attempting to authenticate against a PassDB with incompatible auth mechanisms.
- When the new OAuth2 feature was enabled, it introduced false-positives with logged auth failures which triggered Fail2Ban to ban the IP.

View File

@ -50,7 +50,7 @@ function _service_log_should_contain_string() {
assert_success
}
# Like `_filter_service_log` but asserts that the string was not found.
# Like `_filter_service_log` but asserts that the string was _not_ found.
#
# @param ${1} = service name
# @param ${2} = string to filter by
@ -59,8 +59,8 @@ function _service_log_should_not_contain_string() {
assert_failure
}
# Like `_filter_service_log` but asserts that the string was found. Uses regular expressions
# under the hood for pattern matching.
# Like `_filter_service_log` but asserts that the string was found.
# Uses regular expressions under the hood for pattern matching.
#
# @param ${1} = service name
# @param ${2} = regular expression to filter by
@ -69,8 +69,8 @@ function _service_log_should_contain_string_regexp() {
assert_success
}
# Like `_filter_service_log` but asserts that the string was not found. Uses regular expressions
# under the hood for pattern matching.
# Like `_filter_service_log` but asserts that the string was _not_ found.
# Uses regular expressions under the hood for pattern matching.
#
# @param ${1} = service name
# @param ${2} = regular expression to filter by