From 71b9a602a5417689c9e6dcc3407e9a3282bc60cd Mon Sep 17 00:00:00 2001 From: Brennan Kinney <5098581+polarathene@users.noreply.github.com> Date: Tue, 18 Mar 2025 09:35:53 +1300 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Casper --- target/bin/open-dkim | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/bin/open-dkim b/target/bin/open-dkim index 1cfc7532..c0798527 100755 --- a/target/bin/open-dkim +++ b/target/bin/open-dkim @@ -1,4 +1,4 @@ -#!/usr/bin/env bash +#!/bin/bash # shellcheck source=../scripts/helpers/index.sh source /usr/local/bin/helpers/index.sh @@ -109,7 +109,7 @@ function _parse_arguments() { ( * ) __usage - _exit_with_error "Unknown option(s) '${1}' ${2:+"and '${2}'"}" + _exit_with_error "Unknown option(s) ${*}" ;; esac @@ -164,7 +164,7 @@ function _generate_domains_config() { # Generate the default vhost (equivalent to /etc/postfix/vhost), # unless CLI arg DMS_DOMAINS provided an alternative list to use instead: - if [[ -z ${DMS_DOMAINS} ]]; then + if [[ -z ${DMS_DOMAINS:-} ]]; then _obtain_hostname_and_domainname # uses TMP_VHOST: _vhost_collect_postfix_domains