From 5295e912bbb9ab10fc3dbe9393d219e22d482967 Mon Sep 17 00:00:00 2001
From: Keval Kapdee <keval@kapdee.uk>
Date: Wed, 3 Jan 2024 18:23:54 +0000
Subject: [PATCH] More suggested changes

---
 docs/content/config/environment.md     | 5 +----
 target/dovecot/dovecot-oauth2.conf.ext | 6 +++---
 target/scripts/start-mailserver.sh     | 4 ++++
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/docs/content/config/environment.md b/docs/content/config/environment.md
index f978ef36..08fd8d40 100644
--- a/docs/content/config/environment.md
+++ b/docs/content/config/environment.md
@@ -615,18 +615,15 @@ Enable or disable `getmail`.
 
 ##### OAUTH2_CLIENT_ID
 
-- **empty** => verySecretId
 - => Specify the OAuth2 client ID
 
 ##### OAUTH2_CLIENT_SECRET
 
-- **empty** => verySecretSecret
 - => Specify the OAuth2 client secret
 
 ##### OAUTH2_INTROSPECTION_URL
 
-- **empty** => https://oauth2.example.com/userinfo/
-- => Specify the user info endpoint URL of the oauth2 provider. The trailing slash is MANDATORY (at least for Authentik)
+- => Specify the user info endpoint URL of the oauth2 provider. E.g. `https://oauth2.example.com/userinfo/`, where the trailing slash is MANDATORY (at least for Authentik)
 #### LDAP
 
 ##### LDAP_START_TLS
diff --git a/target/dovecot/dovecot-oauth2.conf.ext b/target/dovecot/dovecot-oauth2.conf.ext
index 3390df54..6b25c49e 100644
--- a/target/dovecot/dovecot-oauth2.conf.ext
+++ b/target/dovecot/dovecot-oauth2.conf.ext
@@ -1,3 +1,3 @@
-client_id = verySecretId
-client_secret = verySecretSecret
-introspection_url = https://oauth2.example.com/userinfo/
+client_id = 
+client_secret = 
+introspection_url = 
diff --git a/target/scripts/start-mailserver.sh b/target/scripts/start-mailserver.sh
index 2476e466..1f352229 100755
--- a/target/scripts/start-mailserver.sh
+++ b/target/scripts/start-mailserver.sh
@@ -62,6 +62,10 @@ function _register_functions() {
       _register_setup_function '_setup_ldap'
       ;;
 
+    ( 'OIDC' )
+      _dms_panic__fail_init 'OIDC user account provisioning - it is not yet implemented'
+      ;;
+
     ( * )
       _dms_panic__invalid_value "'${ACCOUNT_PROVISIONER}' is not a valid value for ACCOUNT_PROVISIONER"
       ;;